PCI: Disable AER & DPC on suspend
Get series with b4
b4 am [email protected]Versions newest first
- v9 Latest2 patches 1 replyIn review
Changes in v9 from the cover letter
- Drop pci_ancestor_pr3_present() and pm_suspend_via_firmware; do it unconditionally
- Clear DPC status before re-enabling DPC interrupt
Patches in v9 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | PCI/AER: Disable AER service on suspenddrivers/ | +18 | 0 replies | |
| 2/2 | PCI/DPC: Disable DPC service on suspenddrivers/ | +48 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Rafael J. Wysocki |
|---|---|
| Series | A-b |
| 1/2 | |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v9 0/2] PCI: Disable AER & DPC on suspend
From: Bjorn Helgaas <[email protected]>
This is an old series from Kai-Heng that I didn't handle soon enough. The intent is to fix several suspend/resume issues:
- Spurious wakeup from s2idle
(https://bugzilla.kernel.org/show_bug.cgi?id=216295)
- Steam Deck doesn't resume after suspend
(https://bugzilla.kernel.org/show_bug.cgi?id=218090)
- Unexpected ACS error and DPC event when resuming after suspend
(https://bugzilla.kernel.org/show_bug.cgi?id=209149)
It seems that a glitch when the link is powered down during suspend causes errors to be logged by AER. When AER is enabled, this causes an AER interrupt, and if that IRQ is shared with PME, it may cause a spurious wakeup.
Also, errors logged during link power-down and power-up seem to cause unwanted error reporting during resume.
This series disables AER interrupts, DPC triggering, and DPC interrupts during suspend. On resume, it clears AER and DPC error status before re-enabling their interrupts.
I added a couple cosmetic changes for the v9, but this is essentially all Kai-Heng's work. I'm just posting it as a v9 because I failed to act on this earlier.
Bjorn
v9:
- Drop pci_ancestor_pr3_present() and pm_suspend_via_firmware; do it unconditionally
- Clear DPC status before re-enabling DPC interrupt
v8: https://lore.kernel.org/r/[email protected]
- Wording.
- Add more bug reports.
v7:
- Wording.
- Disable AER completely (again) if power will be turned off
- Disable DPC completely (again) if power will be turned off
v6: https://lore.kernel.org/r/[email protected]
v5: https://lore.kernel.org/r/[email protected]
- Wording.
v4: https://lore.kernel.org/r/[email protected]
v3: https://lore.kernel.org/r/[email protected]
- Correct subject.
v2: https://lore.kernel.org/r/[email protected]
- Only disable AER IRQ.
- No more AER check on PME IRQ#.
- Use AER helper.
- Only disable DPC IRQ.
- No more DPC check on PME IRQ#.
v1: https://lore.kernel.org/r/[email protected]
Kai-Heng Feng (2):
PCI/AER: Disable AER service on suspend
PCI/DPC: Disable DPC service on suspend
drivers/pci/pcie/aer.c | 18 +++++++++++++ drivers/pci/pcie/dpc.c | 60 +++++++++++++++++++++++++++++++++--------- 2 files changed, 66 insertions(+), 12 deletions(-)
Signature · 1 line
2.34.1