Skip to content

DC Patches June 20, 2024

Alex Hung amd-gfx stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest39 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/39drm/amd/display: Temporarily disable HPO PG on DCN35drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c+1 -10 replies
2/39drm/amd/display: Refactor dccg401_get_other_enable_symclk_fedrivers/gpu/drm/amd/display/dc/dccg/dcn401/dcn401_dccg.c+22 -350 replies
3/39drm/amd/display: Remove redundant var from display_rq_dig_calc in dmldrivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c +3 more+18 -660 replies
4/39drm/amd/display: Remove unnecessary variabledrivers/gpu/drm/amd/display/dc/hwss/dcn10/dcn10_hwseq.c+0 -170 replies
5/39drm/amd/display: Fix cursor issues with ODMs and HW rotationsdrivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_cm.c drivers/gpu/drm/amd/display/dc/hubp/dcn401/dcn401_hubp.c drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c+19 -2040 replies
6/39drm/amd/display: Send DP_TOTAL_LTTPR_CNT during detection if LTTPR is presentdrivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c drivers/gpu/drm/amd/display/include/dpcd_defs.h+14 -10 replies
7/39drm/amd/display: Remove redundant checks for pipe_ctx->streamdrivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c drivers/gpu/drm/amd/display/dc/link/accessories/link_dp_cts.c+6 -70 replies
8/39drm/amd/display: Run DC_LOG_DC after checking link->link_encdrivers/gpu/drm/amd/display/dc/link/link_factory.c+3 -30 replies
9/39drm/amd/display: Fix cursor size issuesdrivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c+14 -00 replies
10/39drm/amd/display: Fix uninitialized variables in dcn401drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c+2 -20 replies
11/39drm/amd/display: Remove useless function calldrivers/gpu/drm/amd/display/dc/clk_mgr/dcn201/dcn201_clk_mgr.c+0 -20 replies
12/39drm/amd/display: Check and log for function error codesdrivers/gpu/drm/amd/display/dc/bios/command_table2.c drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c+13 -30 replies
13/39drm/amd/display: Check and log for function error codesdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c+8 -20 replies
14/39drm/amd/display: Check HDCP returned statusdrivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c+9 -60 replies
15/39drm/amd/display: Add Replay general cmddrivers/gpu/drm/amd/display/dc/dc_types.h drivers/gpu/drm/amd/display/dc/dce/dmub_replay.c+18 -10 replies
16/39drm/amd/display: Use sw cursor for DCN401 with rotationdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+29 -50 replies
17/39drm/amd/display: Always enable HPO for DCN4 dGPUdrivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_init.c+2 -10 replies
18/39drm/amd/display: resync OTG after DIO FIFO resyncdrivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c+2 -00 replies
19/39drm/amd/display: Call dpmm when checking mode supportdrivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_wrapper.c drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_top/dml_top.c drivers/gpu/drm/amd/display/dc/dml2/dml21/src/inc/dml2_internal_shared_types.h+19 -00 replies
20/39drm/amd/display: Add workaround to restrict max frac urgent for DPM0drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.h drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c+19 -10 replies
21/39drm/amd/display: Make DML2.1 P-State method force per streamdrivers/gpu/drm/amd/display/dc/dc.h drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_wrapper.c +1 more+5 -41 reply
22/39drm/amd/display: Fix reduced resolution and refresh ratedrivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c+11 -100 replies
23/39drm/amd/display: Add null checks before accessing struct elementsdrivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c +1 more+16 -100 replies
24/39drm/amd/display: Program CURSOR_DST_X_OFFSET in viewport spacedrivers/gpu/drm/amd/display/dc/hubp/dcn401/dcn401_hubp.c+10 -20 replies
25/39drm/amd/display: Reset DSC memory statusdrivers/gpu/drm/amd/display/dc/dsc/dcn20/dcn20_dsc.c drivers/gpu/drm/amd/display/dc/dsc/dcn20/dcn20_dsc.h drivers/gpu/drm/amd/display/dc/dsc/dcn35/dcn35_dsc.c+71 -200 replies
26/39drm/amd/display: Wait for double buffer update on ODM changesdrivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c drivers/gpu/drm/amd/display/dc/inc/hw/timing_generator.h drivers/gpu/drm/amd/display/dc/optc/dcn10/dcn10_optc.h +4 more+43 -10 replies
27/39drm/amd/display: Fix cursor issues with ODMs and magnificationdrivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c+9 -00 replies
28/39drm/amd/display: Add HW cursor visual confirmdrivers/gpu/drm/amd/display/dc/core/dc_stream.c drivers/gpu/drm/amd/display/dc/dc.h+30 -00 replies
29/39drm/amd/display: Remove a redundant check in authenticated_dpdrivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c+12 -150 replies
30/39drm/amd/display: Adjust reg field for DSC wait for disconnectdrivers/gpu/drm/amd/display/dc/dsc/dcn20/dcn20_dsc.h drivers/gpu/drm/amd/display/dc/dsc/dcn401/dcn401_dsc.c drivers/gpu/drm/amd/display/dc/dsc/dcn401/dcn401_dsc.h+6 -30 replies
31/39drm/amd/display: Fix 1DLUT setting for NL SDR blendingdrivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c+2 -20 replies
32/39drm/amd/display: Use periodic detection for ipx/headlessdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c+46 -100 replies
33/39drm/amd/display: Ensure curve to hw translation succeeddrivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_hwseq.c drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c+10 -40 replies
34/39drm/amd/display: Validate function returnsdrivers/gpu/drm/amd/display/dc/dc_dmub_srv.c drivers/gpu/drm/amd/display/dc/hubbub/dcn20/dcn20_hubbub.c drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training.c+8 -50 replies
35/39drm/amd/display: Remove always true conditiondrivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c+1 -30 replies
36/39drm/amd/display: Remove duplicate null checkdrivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c+0 -30 replies
37/39drm/amd: Add reg definitions for DCN401 DCCdrivers/gpu/drm/amd/include/asic_reg/dcn/dcn_4_1_0_sh_mask.h+110 -00 replies
38/39drm/amd/display: Enable DCC on DCN401drivers/gpu/drm/amd/display/dc/core/dc.c drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c drivers/gpu/drm/amd/display/dc/dc.h +19 more+433 -20 replies
39/39drm/amd/display: 3.2.290drivers/gpu/drm/amd/display/dc/dc.h+1 -10 replies

Reviews trailers per patch

All 39 patches have a Reviewed-by or Acked-by.

PatchNicholas KazlauskasCharlene LiuAlex HungWenjing LiuSridevi ArvindekarRodrigo SiqueiraSun peng LiAlvin LeeChaitanya DhereNevenko StuparSamson TamIlya BakoulinAurabindo PillaiHarry WentlandDaniel Wheeler
SeriesT-b
1/39R-b R-b A-b
2/39A-b R-b
3/39R-b A-b
4/39R-b A-b
5/39A-b R-b
6/39A-b R-b
7/39A-b R-b
8/39A-b R-b
9/39A-b R-b
10/39A-b R-b
11/39A-b R-b
12/39A-b R-b
13/39A-b R-b
14/39A-b R-b
15/39R-b A-b
16/39A-b R-b R-b
17/39A-b R-b
18/39A-b R-b
19/39A-b R-b
20/39R-b A-b
21/39A-b R-b
22/39A-b R-b
23/39A-b R-b
24/39A-b R-b
25/39R-b A-b
26/39A-b R-b
27/39A-b R-b
28/39A-b R-b
29/39A-b R-b
30/39A-b R-b
31/39A-b R-b
32/39A-b R-b
33/39A-b R-b
34/39A-b R-b
35/39A-b R-b
36/39A-b R-b
37/39A-b R-b
38/39A-b R-b
39/39A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 15 reviewers.

Read the v1 thread

Cover letter [PATCH 00/39] DC Patches June 20, 2024

This DC patchset brings improvements in multiple areas. In summary, we highlight:

* Enable DCC on DCN401
* Fix cursor issues
* Misc Coverity fixes

Cc Daniel Wheeler <[email protected]>

Alex Hung (12):
drm/amd/display: Remove redundant checks for pipe_ctx->stream drm/amd/display: Run DC_LOG_DC after checking link->link_enc drm/amd/display: Fix uninitialized variables in dcn401 drm/amd/display: Remove useless function call drm/amd/display: Check and log for function error codes drm/amd/display: Check and log for function error codes drm/amd/display: Check HDCP returned status drm/amd/display: Add null checks before accessing struct elements drm/amd/display: Ensure curve to hw translation succeed drm/amd/display: Validate function returns drm/amd/display: Remove always true condition drm/amd/display: Remove duplicate null check

Alvin Lee (2):
drm/amd/display: Program CURSOR_DST_X_OFFSET in viewport space drm/amd/display: Wait for double buffer update on ODM changes

Aric Cyr (1):
drm/amd/display: 3.2.290

Aurabindo Pillai (3):
drm/amd/display: Use sw cursor for DCN401 with rotation drm/amd: Add reg definitions for DCN401 DCC drm/amd/display: Enable DCC on DCN401

Daniel Sa (1):
drm/amd/display: Fix reduced resolution and refresh rate

Dillon Varone (1):
drm/amd/display: Make DML2.1 P-State method force per stream

Duncan Ma (1):
drm/amd/display: Reset DSC memory status

George Shen (1):
drm/amd/display: Call dpmm when checking mode support

Ivan Lipski (2):
drm/amd/display: Remove redundant var from display_rq_dig_calc in dml drm/amd/display: Remove unnecessary variable

Joan Lee (1):
drm/amd/display: Add Replay general cmd

Leo (Hanghong) Ma (1):
drm/amd/display: Always enable HPO for DCN4 dGPU

Michael Strauss (1):
drm/amd/display: Send DP_TOTAL_LTTPR_CNT during detection if LTTPR is
present

Nevenko Stupar (3):
drm/amd/display: Fix cursor issues with ODMs and HW rotations drm/amd/display: Fix cursor size issues drm/amd/display: Fix cursor issues with ODMs and magnification

Nicholas Susanto (1):
drm/amd/display: Temporarily disable HPO PG on DCN35

Relja Vojvodic (2):
drm/amd/display: Refactor dccg401_get_other_enable_symclk_fe drm/amd/display: Fix 1DLUT setting for NL SDR blending

Roman Li (1):
drm/amd/display: Use periodic detection for ipx/headless

Ryan Seto (2):
drm/amd/display: Add HW cursor visual confirm drm/amd/display: Adjust reg field for DSC wait for disconnect

Sung-huai Wang (1):
drm/amd/display: Add workaround to restrict max frac urgent for DPM0

TungYu Lu (1):
drm/amd/display: resync OTG after DIO FIFO resync

Wenjing Liu (1):
drm/amd/display: Remove a redundant check in authenticated_dp

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  39 ++-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |   3 +
 .../amd/display/amdgpu_dm/amdgpu_dm_crtc.c    |  48 ++-
 .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c |   5 +-
 .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c |   5 +-
 .../drm/amd/display/dc/bios/command_table2.c  |   3 +-
 .../dc/clk_mgr/dcn201/dcn201_clk_mgr.c        |   2 -
 .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c  |  10 +-
 .../dc/clk_mgr/dcn401/dcn401_clk_mgr.c        |  10 +-
 drivers/gpu/drm/amd/display/dc/core/dc.c      |  12 +
 .../drm/amd/display/dc/core/dc_hw_sequencer.c |  11 +
 .../gpu/drm/amd/display/dc/core/dc_stream.c   |  29 ++
 drivers/gpu/drm/amd/display/dc/dc.h           |   9 +-
 drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c  |   7 +-
 drivers/gpu/drm/amd/display/dc/dc_types.h     |   1 +
 .../amd/display/dc/dccg/dcn401/dcn401_dccg.c  |  57 ++--
 .../drm/amd/display/dc/dce/dce_link_encoder.c |   5 +-
 .../gpu/drm/amd/display/dc/dce/dmub_replay.c  |  18 +-
 .../amd/display/dc/dcn10/dcn10_link_encoder.c |   8 +-
 .../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c  |   2 +-
 .../dc/dml/dcn20/display_rq_dlg_calc_20.c     |  14 +-
 .../dc/dml/dcn20/display_rq_dlg_calc_20v2.c   |  14 +-
 .../dc/dml/dcn21/display_rq_dlg_calc_21.c     |  14 +-
 .../dc/dml/dcn30/display_rq_dlg_calc_30.c     |  14 +-
 .../dc/dml/dcn31/display_rq_dlg_calc_31.c     |  14 +-
 .../dc/dml/dcn314/display_rq_dlg_calc_314.c   |  14 +-
 .../dc/dml2/dml21/dml21_translation_helper.c  |   2 +-
 .../amd/display/dc/dml2/dml21/dml21_wrapper.c |   4 +-
 .../src/dml2_core/dml2_core_dcn4_calcs.c      |   4 +-
 .../dc/dml2/dml21/src/dml2_top/dml_top.c      |  17 ++
 .../src/inc/dml2_internal_shared_types.h      |   1 +
 .../drm/amd/display/dc/dml2/dml2_wrapper.c    |  29 +-
 .../drm/amd/display/dc/dml2/dml2_wrapper.h    |   6 +-
 .../amd/display/dc/dpp/dcn401/dcn401_dpp_cm.c |  50 ----
 .../drm/amd/display/dc/dsc/dcn20/dcn20_dsc.c  |  24 +-
 .../drm/amd/display/dc/dsc/dcn20/dcn20_dsc.h  |  13 +-
 .../drm/amd/display/dc/dsc/dcn35/dcn35_dsc.c  |  58 +++-
 .../amd/display/dc/dsc/dcn401/dcn401_dsc.c    |   2 +-
 .../amd/display/dc/dsc/dcn401/dcn401_dsc.h    |   3 +-
 .../display/dc/hubbub/dcn20/dcn20_hubbub.c    |   3 +-
 .../display/dc/hubbub/dcn30/dcn30_hubbub.c    |   3 +
 .../display/dc/hubbub/dcn31/dcn31_hubbub.c    |   3 +
 .../display/dc/hubbub/dcn401/dcn401_hubbub.c  | 280 ++++++++++++++++++
 .../display/dc/hubbub/dcn401/dcn401_hubbub.h  |   5 +
 .../amd/display/dc/hubp/dcn20/dcn20_hubp.h    |  14 +
 .../amd/display/dc/hubp/dcn401/dcn401_hubp.c  |  71 ++---
 .../amd/display/dc/hubp/dcn401/dcn401_hubp.h  |  14 +-
 .../amd/display/dc/hwss/dcn10/dcn10_hwseq.c   |  17 --
 .../amd/display/dc/hwss/dcn20/dcn20_hwseq.c   |  34 ++-
 .../amd/display/dc/hwss/dcn30/dcn30_hwseq.c   |   5 +-
 .../amd/display/dc/hwss/dcn32/dcn32_hwseq.c   |  11 +-
 .../amd/display/dc/hwss/dcn401/dcn401_hwseq.c | 169 ++++-------
 .../amd/display/dc/hwss/dcn401/dcn401_hwseq.h |   2 +
 .../amd/display/dc/hwss/dcn401/dcn401_init.c  |   2 +-
 .../drm/amd/display/dc/hwss/hw_sequencer.h    |   9 +
 .../gpu/drm/amd/display/dc/inc/core_types.h   |   3 +
 .../gpu/drm/amd/display/dc/inc/hw/dchubbub.h  |   4 +
 drivers/gpu/drm/amd/display/dc/inc/hw/hubp.h  |   1 +
 .../amd/display/dc/inc/hw/timing_generator.h  |   1 +
 .../display/dc/link/accessories/link_dp_cts.c |   2 +-
 .../drm/amd/display/dc/link/link_factory.c    |   6 +-
 .../dc/link/protocols/link_dp_capability.c    |  31 +-
 .../dc/link/protocols/link_dp_training.c      |   3 +-
 .../amd/display/dc/optc/dcn10/dcn10_optc.h    |   3 +-
 .../amd/display/dc/optc/dcn32/dcn32_optc.c    |  13 +
 .../amd/display/dc/optc/dcn32/dcn32_optc.h    |   2 +
 .../amd/display/dc/optc/dcn401/dcn401_optc.c  |   1 +
 .../amd/display/dc/optc/dcn401/dcn401_optc.h  |   1 +
 .../dc/resource/dcn35/dcn35_resource.c        |   5 +-
 .../dc/resource/dcn401/dcn401_resource.c      |   9 +
 .../dc/resource/dcn401/dcn401_resource.h      |   2 +
 .../gpu/drm/amd/display/include/dpcd_defs.h   |   5 +
 .../display/modules/hdcp/hdcp1_execution.c    |  24 +-
 .../drm/amd/display/modules/hdcp/hdcp_psp.c   |   3 -
 .../include/asic_reg/dcn/dcn_4_1_0_sh_mask.h  | 110 +++++++
 75 files changed, 1021 insertions(+), 431 deletions(-)
Signature · 1 line
2.34.1