Skip to content

net: dsa: vsc73xx: fix MDIO bus access and PHY operations

Pawel Dembicki lkml netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 0 repliesApplied 5/5
  2. v25 patches 2 repliesSuperseded
  3. v16 patches 18 repliesSuperseded

Patches in v3 All 5 applied

#Subject and filesSizeRepliesApplied
1/5net: dsa: vsc73xx: fix port MAC configuration in full duplex modedrivers/net/dsa/vitesse-vsc73xx-core.c+5 -10 repliesApplied
2/5net: dsa: vsc73xx: pass value in phy_write operationdrivers/net/dsa/vitesse-vsc73xx-core.c+1 -10 repliesApplied
3/5net: dsa: vsc73xx: check busy flag in MDIO operationsdrivers/net/dsa/vitesse-vsc73xx-core.c+36 -10 repliesApplied
4/5net: dsa: vsc73xx: allow phy resettingdrivers/net/dsa/vitesse-vsc73xx-core.c+0 -110 repliesApplied
5/5net: phy: vitesse: repair vsc73xx autonegotiationdrivers/net/phy/vitesse.c+0 -140 repliesApplied

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchLinus WalleijFlorian Fainelli
1/5R-b R-b
2/5R-b R-b
3/5R-b R-b
4/5R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net v3 0/5] net: dsa: vsc73xx: fix MDIO bus access and PHY operations

This series are extracted patches from net-next series [0].

The VSC73xx driver has issues with PHY configuration. This patch series fixes most of them.

The first patch synchronizes the register configuration routine with the datasheet recommendations.

Patches 2-3 restore proper communication on the MDIO bus. Currently, the write value isn't sent to the MDIO register, and without a busy check, communication with the PHY can be interrupted. This causes the PHY to receive improper configuration and autonegotiation could fail.

The fourth patch removes the PHY reset blockade, as it is no longer required.

After fixing the MDIO operations, autonegotiation became possible. The last patch removes the blockade, which became unnecessary after the MDIO operations fix.

[0] https://patchwork.kernel.org/project/netdevbpf/list/?series=874739&state=%2A&archive=both

Pawel Dembicki (5):
net: dsa: vsc73xx: fix port MAC configuration in full duplex mode
net: dsa: vsc73xx: pass value in phy_write operation
net: dsa: vsc73xx: check busy flag in MDIO operations
net: dsa: vsc73xx: allow phy resetting
net: phy: vitesse: repair vsc73xx autonegotiation

 drivers/net/dsa/vitesse-vsc73xx-core.c | 54 +++++++++++++++++++-------
 drivers/net/phy/vitesse.c              | 14 -------
 2 files changed, 41 insertions(+), 27 deletions(-)
Signature · 1 line
2.34.1