Skip to content

Combine the two UFS driver scsi_add_host() calls

Bart Van Assche linux-arm-msm linux-scsi 6 versions – Applied

Status from this message: Applied to 6.13/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest11 patches 11 repliesApplied
  2. v510 patches 8 repliesSuperseded
  3. v410 patches 10 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v39 patches6 repliesSuperseded
v29 patches15 repliesSuperseded
v19 patches1 replySuperseded

Changes in v6 from the cover letter

- Rebased this patch series on top of the v6.12-rc kernel.
- Removed the probe_start member variable again from struct ufs_hba.
- Renamed ufshcd_process_device_init_result() into ufshcd_process_probe_result().
- Converted a comment about UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH into an explicit test.

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/11scsi: ufs: core: Introduce ufshcd_add_scsi_host()drivers/ufs/core/ufshcd.c+59 -370 replies
2/11scsi: ufs: core: Introduce ufshcd_post_device_init()drivers/ufs/core/ufshcd.c+35 -270 replies
3/11scsi: ufs: core: Call ufshcd_add_scsi_host() laterdrivers/ufs/core/ufshcd.c+5 -110 replies
4/11scsi: ufs: core: Introduce ufshcd_process_probe_result()drivers/ufs/core/ufshcd.c+24 -110 replies
5/11scsi: ufs: core: Convert a comment into an explicit checkdrivers/ufs/core/ufshcd.c+3 -20 replies
6/11scsi: ufs: core: Move the ufshcd_device_init() callsdrivers/ufs/core/ufshcd.c+18 -130 replies
7/11scsi: ufs: core: Move the ufshcd_device_init(hba, true) calldrivers/ufs/core/ufshcd.c+8 -40 replies
8/11scsi: ufs: core: Expand the ufshcd_device_init(hba, true) calldrivers/ufs/core/ufshcd.c+55 -10 replies
9/11scsi: ufs: core: Remove code that is no longer neededdrivers/ufs/core/ufshcd.c+4 -220 replies
10/11scsi: ufs: core: Move the MCQ scsi_add_host() calldrivers/ufs/core/ufshcd.c+19 -220 replies
11/11scsi: ufs: core: Move code out of an if-statementdrivers/ufs/core/ufshcd.c+13 -199 replies

Reviews trailers per patch

4 of 11 patches have a Reviewed-by or Acked-by.

PatchAvri AltmanBean HuoBao D. NguyenManivannan SadhasivamNeil Armstrong
1/11R-b R-b R-b
2/11R-b R-b R-b
3/11R-b R-b R-b
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11R-b T-b T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v6 thread

Cover letter [PATCH v6 00/11] Combine the two UFS driver scsi_add_host() calls

Hi Martin,

In the UFS driver the legacy and MCQ scsi_add_host() calls occur in different functions. This patch series reduces the number of scsi_add_host() calls from two to one and hence makes the UFS driver easier to maintain.

Please consider this patch series for the next merge window.

Thanks,

Bart.

Changes compared to v5:
- Rebased this patch series on top of the v6.12-rc kernel.
- Removed the probe_start member variable again from struct ufs_hba.
- Renamed ufshcd_process_device_init_result() into ufshcd_process_probe_result().
- Converted a comment about UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH into an explicit test.

Changes compared to v4:
- Left out the changes that remove the 'init_dev_params' argument.
- Added a few new patches.

Changes compared to v3:
- Split patch "Move the MCQ scsi_add_host() call" into two patches to make it easier for reviewers.

Changes compared to v2:
- Improved several patch descriptions.
- Moved one source code comment.

Changes compared to v1:
- Fixed a compiler warning reported by the kernel build robot.
- Improved patch descriptions.

Bart Van Assche (11):
scsi: ufs: core: Introduce ufshcd_add_scsi_host()
scsi: ufs: core: Introduce ufshcd_post_device_init()
scsi: ufs: core: Call ufshcd_add_scsi_host() later
scsi: ufs: core: Introduce ufshcd_process_probe_result()
scsi: core: ufs: Convert a comment into an explicit check
scsi: ufs: core: Move the ufshcd_device_init() calls
scsi: ufs: core: Move the ufshcd_device_init(hba, true) call
scsi: ufs: core: Expand the ufshcd_device_init(hba, true) call
scsi: ufs: core: Remove code that is no longer needed
scsi: ufs: core: Move the MCQ scsi_add_host() call
scsi: ufs: core: Move code out of an if-statement

 drivers/ufs/core/ufshcd.c | 304 ++++++++++++++++++++++++--------------
 1 file changed, 189 insertions(+), 115 deletions(-)