Skip to content

KVM: Enable host userspace mapping for guest_memfd-backed memory for non-CoCo VMs

Fuad Tabba kvm kvmarm linux-arm-msm linux-mm 15 versions – NAK

Status from this message: NAK.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v16 Latest22 patches 39 repliesNAK
  2. v1521 patches 64 repliesSuperseded
  3. v1421 patches 37 repliesSuperseded
Earlier versions · 12
VersionPostedPatchesRepliesStatus
v1320 patches18 repliesSuperseded
v1218 patches56 repliesSuperseded
v1118 patches37 repliesSuperseded
v1016 patches44 repliesSuperseded
v917 patches69 repliesSuperseded
v813 patches49 repliesSuperseded
v79 patches24 repliesSuperseded
v610 patches10 repliesSuperseded
v59 patches21 repliesSuperseded
v410 patches13 repliesSuperseded
v311 patches42 repliesSuperseded
v2 RFC11 patches11 repliesSuperseded

Patches in v16

#Subject and filesSizeRepliesApplied
1/22KVM: Rename CONFIG_KVM_PRIVATE_MEM to CONFIG_KVM_GUEST_MEMFDarch/x86/include/asm/kvm_host.h include/linux/kvm_host.h virt/kvm/Kconfig +3 more+17 -170 replies
2/22KVM: x86: Have all vendor neutral sub-configs depend on KVM_X86, not just KVMarch/x86/kvm/Kconfig+8 -82 replies
3/22KVM: x86: Select KVM_GENERIC_PRIVATE_MEM directly from KVM_SW_PROTECTED_VMarch/x86/kvm/Kconfig+1 -12 replies
4/22KVM: x86: Select TDX's KVM_GENERIC_xxx dependencies iff CONFIG_KVM_INTEL_TDX=yarch/x86/kvm/Kconfig+2 -23 replies
5/22KVM: Rename CONFIG_KVM_GENERIC_PRIVATE_MEM to CONFIG_HAVE_KVM_ARCH_GMEM_POPULATEarch/x86/kvm/Kconfig include/linux/kvm_host.h virt/kvm/Kconfig +1 more+16 -113 replies
6/22KVM: Rename kvm_slot_can_be_private() to kvm_slot_has_gmem()arch/x86/kvm/mmu/mmu.c arch/x86/kvm/svm/sev.c include/linux/kvm_host.h +1 more+6 -60 replies
7/22KVM: Fix comments that refer to slots_lockinclude/linux/kvm_host.h virt/kvm/kvm_main.c+2 -20 replies
8/22KVM: Fix comment that refers to kvm uapi header pathinclude/linux/kvm_host.h+1 -10 replies
9/22KVM: x86: Enable KVM_GUEST_MEMFD for all 64-bit buildsarch/x86/include/asm/kvm_host.h arch/x86/kvm/Kconfig include/linux/kvm_host.h +1 more+9 -202 replies
10/22KVM: guest_memfd: Add plumbing to host to map guest_memfd pagesarch/x86/kvm/x86.c include/linux/kvm_host.h virt/kvm/guest_memfd.c+85 -02 replies
11/22KVM: guest_memfd: Track guest_memfd mmap support in memslotinclude/linux/kvm_host.h virt/kvm/guest_memfd.c+12 -10 replies
12/22KVM: x86/mmu: Rename .private_max_mapping_level() to .gmem_max_mapping_level()arch/x86/include/asm/kvm-x86-ops.h arch/x86/include/asm/kvm_host.h arch/x86/kvm/mmu/mmu.c +6 more+12 -120 replies
13/22KVM: x86/mmu: Hoist guest_memfd max level/order helpers "up" in mmu.carch/x86/kvm/mmu/mmu.c+36 -363 replies
14/22KVM: x86/mmu: Enforce guest_memfd's max order when recovering hugepagesarch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/mmu_internal.h arch/x86/kvm/mmu/tdp_mmu.c+50 -377 replies
15/22KVM: x86/mmu: Extend guest_memfd's max mapping level to shared mappingsarch/x86/include/asm/kvm_host.h arch/x86/kvm/mmu/mmu.c arch/x86/kvm/svm/sev.c +4 more+29 -159 replies
16/22KVM: arm64: Refactor user_mem_abort()arch/arm64/kvm/mmu.c+59 -510 replies
17/22KVM: arm64: Handle guest_memfd-backed guest page faultsarch/arm64/kvm/mmu.c+83 -30 replies
18/22KVM: arm64: nv: Handle VNCR_EL2-triggered faults backed by guest_memfdarch/arm64/kvm/nested.c+35 -60 replies
19/22KVM: arm64: Enable support for guest_memfd backed memoryarch/arm64/kvm/Kconfig arch/arm64/kvm/mmu.c+8 -00 replies
20/22KVM: Allow and advertise support for host mmap() on guest_memfd filesDocumentation/virt/kvm/api.rst include/uapi/linux/kvm.h virt/kvm/guest_memfd.c +1 more+19 -10 replies
21/22KVM: selftests: Do not use hardcoded page sizes in guest_memfd testtools/testing/selftests/kvm/Makefile.kvm tools/testing/selftests/kvm/guest_memfd_test.c+7 -50 replies
22/22KVM: selftests: guest_memfd mmap() test when mmap is supportedtools/testing/selftests/kvm/guest_memfd_test.c+173 -212 replies

Reviews trailers per patch

20 of 22 patches have a Reviewed-by or Acked-by.

PatchIra WeinyGavin ShanShivank GargVlastimil BabkaXiaoyao LiDavid HildenbrandMarc ZyngierTao ChanJames HoughtonAckerley Tng
1/22R-b R-b R-b R-b R-b
2/22R-b R-b
3/22R-b R-b
4/22R-b R-b
5/22R-b R-b R-b R-b R-b
6/22R-b R-b R-b R-b R-b
7/22R-b R-b R-b R-b R-b R-b
8/22R-b R-b R-b R-b R-b
9/22R-b R-b
10/22R-b R-b R-b A-b
11/22R-b R-b R-b A-b
12/22R-b A-b
13/22R-b R-b
14/22
15/22
16/22R-b R-b R-b
17/22R-b R-b R-b
18/22R-b
19/22R-b A-b R-b R-b
20/22R-b R-b R-b R-b
21/22R-b R-b R-b
22/22R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 10 reviewers.

Read the v16 thread

Cover letter [PATCH v16 00/22] KVM: Enable host userspace mapping for guest_memfd-backed memory for non-CoCo VMs

Main changes since v15 [1]:

* Rework and simplify Kconfig selection and dependencies.
* Always enable guest_memfd for KVM x86 (64-bit) and arm64, which simplifies the enablement checks.
* Based on kvm-x86/next: commit 33f843444e28 ("Merge branch 'vmx'").

This patch series enables host userspace mapping of guest_memfd-backed memory for non-CoCo VMs. This is required for several evolving KVM use cases:

* Allows VMMs like Firecracker to run guests entirely backed by guest_memfd [2]. This provides a unified memory management model for both confidential and non-confidential guests, simplifying VMM design.

* Enhanced Security via direct map removal: When combined with Patrick's series for direct map removal [3], this provides additional hardening against Spectre-like transient execution attacks by eliminating the need for host kernel direct maps of guest memory.

* Lays the groundwork for *restricted* mmap() support for guest_memfd-backed memory on CoCo platforms [4] that permit in-place sharing of guest memory with the host.

Patch breakdown:

* Patches 1-9: Primarily infrastructure refactoring, Kconfig cleaning, and renames to decouple guest_memfd from the concept of "private" memory.

* Patches 10-11: Add support for the host to map guest_memfd backed memory for non-CoCo VMs, which includes support for mmap() and fault handling. This is gated by a new configuration option, toggled by a new flag, and advertised to userspace by a new capability (introduced in patch 20).

* Patches 12-15: Implement x86 guest_memfd mmap support.

* Patches 16-19: Implement arm64 guest_memfd mmap support.

* Patch 20: Introduce the new capability to advertise this support and update the documentation.

* Patches 21-22: Update and expand selftests for guest_memfd to include mmap functionality and improve portability.

To test this patch series and boot a guest utilizing the new features, please refer to the instructions in v8 of the series [5]. Note that kvmtool for Linux 6.16 (available at [6]) is required, as the KVM_CAP_GMEM_MMAP capability number has changed, additionally, drop the --sw_protected kvmtool parameter to test with the default VM type.

Cheers,
/fuad

[1] https://lore.kernel.org/all/[email protected]/
[2] https://github.com/firecracker-microvm/firecracker/tree/feature/secret-hiding
[3] https://lore.kernel.org/all/[email protected]/
[4] https://lore.kernel.org/all/[email protected]/
[5] https://lore.kernel.org/all/[email protected]/
[6] https://android-kvm.googlesource.com/kvmtool/+/refs/heads/tabba/guestmem-basic-6.16

Ackerley Tng (1):
KVM: x86/mmu: Rename .private_max_mapping_level() to
.gmem_max_mapping_level()

Fuad Tabba (15):
KVM: Rename CONFIG_KVM_PRIVATE_MEM to CONFIG_KVM_GUEST_MEMFD
KVM: Rename CONFIG_KVM_GENERIC_PRIVATE_MEM to
CONFIG_HAVE_KVM_ARCH_GMEM_POPULATE
KVM: Rename kvm_slot_can_be_private() to kvm_slot_has_gmem()
KVM: Fix comments that refer to slots_lock
KVM: Fix comment that refers to kvm uapi header path
KVM: x86: Enable KVM_GUEST_MEMFD for all 64-bit builds
KVM: guest_memfd: Add plumbing to host to map guest_memfd pages
KVM: guest_memfd: Track guest_memfd mmap support in memslot
KVM: arm64: Refactor user_mem_abort()
KVM: arm64: Handle guest_memfd-backed guest page faults
KVM: arm64: nv: Handle VNCR_EL2-triggered faults backed by guest_memfd
KVM: arm64: Enable support for guest_memfd backed memory
KVM: Allow and advertise support for host mmap() on guest_memfd files
KVM: selftests: Do not use hardcoded page sizes in guest_memfd test
KVM: selftests: guest_memfd mmap() test when mmap is supported

Sean Christopherson (6):
KVM: x86: Have all vendor neutral sub-configs depend on KVM_X86, not
just KVM
KVM: x86: Select KVM_GENERIC_PRIVATE_MEM directly from
KVM_SW_PROTECTED_VM
KVM: x86: Select TDX's KVM_GENERIC_xxx dependencies iff
CONFIG_KVM_INTEL_TDX=y
KVM: x86/mmu: Hoist guest_memfd max level/order helpers "up" in mmu.c
KVM: x86/mmu: Enforce guest_memfd's max order when recovering
hugepages
KVM: x86/mmu: Extend guest_memfd's max mapping level to shared
mappings

 Documentation/virt/kvm/api.rst                |   9 +
 arch/arm64/kvm/Kconfig                        |   1 +
 arch/arm64/kvm/mmu.c                          | 203 ++++++++++++-----
 arch/arm64/kvm/nested.c                       |  41 +++-
 arch/x86/include/asm/kvm-x86-ops.h            |   2 +-
 arch/x86/include/asm/kvm_host.h               |   6 +-
 arch/x86/kvm/Kconfig                          |  26 ++-
 arch/x86/kvm/mmu/mmu.c                        | 143 +++++++-----
 arch/x86/kvm/mmu/mmu_internal.h               |   2 +-
 arch/x86/kvm/mmu/tdp_mmu.c                    |   2 +-
 arch/x86/kvm/svm/sev.c                        |   6 +-
 arch/x86/kvm/svm/svm.c                        |   2 +-
 arch/x86/kvm/svm/svm.h                        |   4 +-
 arch/x86/kvm/vmx/main.c                       |   7 +-
 arch/x86/kvm/vmx/tdx.c                        |   5 +-
 arch/x86/kvm/vmx/x86_ops.h                    |   2 +-
 arch/x86/kvm/x86.c                            |  11 +
 include/linux/kvm_host.h                      |  38 ++--
 include/uapi/linux/kvm.h                      |   2 +
 tools/testing/selftests/kvm/Makefile.kvm      |   1 +
 .../testing/selftests/kvm/guest_memfd_test.c  | 205 +++++++++++++++---
 virt/kvm/Kconfig                              |  15 +-
 virt/kvm/Makefile.kvm                         |   2 +-
 virt/kvm/guest_memfd.c                        |  81 ++++++-
 virt/kvm/kvm_main.c                           |  12 +-
 virt/kvm/kvm_mm.h                             |   4 +-
 26 files changed, 623 insertions(+), 209 deletions(-)

base-commit: 33f843444e28920d6e624c6c24637b4bb5d3c8de

Signature · 1 line
2.50.1.470.g6ba607880d-goog