Skip to content

ASoC: tas27{64,70}: improve support for Apple codec variants

James Calligeros asahi linux-devicetree linux-hwmon linux-sound lkml 5 versions – In review

Get series with b4
b4 am [email protected] change-id 20250214-apple-codec-changes-6e656dc1e24d

Versions newest first

  1. v5 Latest8 patches 1 replyIn review
  2. v410 patches 0 repliesSuperseded
  3. v320 patches 19 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v229 patches26 repliesSuperseded
v127 patches9 repliesSuperseded

Changes in v5 from the cover letter

- Dropped two commits that depended on TX idle stuff (sorry)
- Link to v4: https://lore.kernel.org/r/[email protected]

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8ASoC: tas2770: Power cycle amp on ISENSE/VSENSE changesound/soc/codecs/tas2770.c+28 -20 replies
2/8ASoC: tas2770: Support setting the PDM TX slotsound/soc/codecs/tas2770.c sound/soc/codecs/tas2770.h+31 -00 replies
3/8ASoC: tas2764: Reinit cache on part resetsound/soc/codecs/tas2764.c+3 -00 replies
4/8ASoC: tas2764: Enable main IRQssound/soc/codecs/tas2764.c+1 -10 replies
5/8ASoC: tas2764: Raise regmap range maximumsound/soc/codecs/tas2764.c+2 -20 replies
6/8ASoC: tas2764: Apply Apple quirkssound/soc/codecs/tas2764-quirks.h sound/soc/codecs/tas2764.c+219 -00 replies
7/8ASoC: tas2770: expose die temp to hwmonsound/soc/codecs/tas2770.c+96 -00 replies
8/8ASoC: tas2764: expose die temp to hwmonsound/soc/codecs/tas2764.c sound/soc/codecs/tas2764.h+92 -00 replies

Reviews trailers per patch

6 of 8 patches have a Reviewed-by or Acked-by.

PatchNeal Gompa
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/8] ASoC: tas27{64,70}: improve support for Apple codec variants

Hi all,

This series introduces a number of changes to the drivers for the Texas Instruments TAS2764 and TAS2770 amplifiers in order to introduce (and improve in the case of TAS2770) support for the variants of these amps found in Apple Silicon Macs.

Apple's variant of TAS2764 is known as SN012776, and as always with Apple is a subtly incompatible variant with a number of quirks. It is not publicly available. The TAS2770 variant is known as TAS5770L, and does not require incompatible handling.

Much as with the Cirrus codec patches, I do not
expect that we will get any official acknowledgement that these parts exist from TI, however I would be delighted to be proven wrong.

This series has been living in the downstream Asahi kernel tree[1] for over two years, and has been tested by many thousands of users by this point[2].

v4 drops the TDM idle TX slot behaviour patches. I experimented with the API discussed in v3, however this did not work on any of the machines I tested it with. More tweaking is probably needed.

[1] https://github.com/AsahiLinux/linux/tree/asahi-wip
[2] https://stats.asahilinux.org/

---
Changes in v5:
- Dropped two commits that depended on TX idle stuff (sorry)
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Moved remaining changes to the top of the set
- Dropped already merged commits
- hwmon now reads temp from regmap
- Bumped regmap max reg patch above Apple quirks patch
- Dropped TDM idle slot TX behaviour patches
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Add Rob's Acked-by to Devicetree compatible additions
- Dropped cherry-picked patches
- Droped abuse of regulator API
- Droped bespoke sysfs interface
- Rationalised temperature reading for hwmon interface
- Set SN012776 device ID with OF match data
- Changed probe ops reliant on device ID to case/switch statement
- Added documentation for new Devicetree properties
- Improved a number of poor quality commit messages
- Documented behaviour of die temperature ADC
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Changed author field of patch to match Martin's Signed-off-by
- Added Neal's Reviewed-by to reviewed patches
- Moved fixes to existing code to the top of the series
- Removed tas2764's explicit dependency on OF
- Removed complicated single-use tas2764 quirks macro and replaced with
if block
- Added hwmon interface for codec die temp
- Fixed a malformed commit message
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Hector Martin (3):
ASoC: tas2770: Power cycle amp on ISENSE/VSENSE change
ASoC: tas2770: Support setting the PDM TX slot
ASoC: tas2764: Enable main IRQs

James Calligeros (2):
ASoC: tas2770: expose die temp to hwmon
ASoC: tas2764: expose die temp to hwmon

Martin Povišer (3):
ASoC: tas2764: Reinit cache on part reset
ASoC: tas2764: Raise regmap range maximum
ASoC: tas2764: Apply Apple quirks

 sound/soc/codecs/tas2764-quirks.h | 180 +++++++++++++++++++++++++
 sound/soc/codecs/tas2764.c        | 137 ++++++++++++++++++-
 sound/soc/codecs/tas2764.h        |   3 +
 sound/soc/codecs/tas2770.c        | 151 ++++++++++++++++++++-
 sound/soc/codecs/tas2770.h        |   6 +
 5 files changed, 472 insertions(+), 5 deletions(-)

---
base-commit: 3a0f0a4355df0240485ed62b6bd6afa5b3e689c5
change-id: 20250214-apple-codec-changes-6e656dc1e24d

Best regards,

Signature · 1 line
James Calligeros <[email protected]>