ASoC: tas27{64,70}: improve support for Apple codec variants
v5 cover ASoC: tas27{64,70}: improve support for Apple codec variants
Hi all,
This series introduces a number of changes to the drivers for the Texas Instruments TAS2764 and TAS2770 amplifiers in order to introduce (and improve in the case of TAS2770) support for the variants of these amps found in Apple Silicon Macs.
Apple's variant of TAS2764 is known as SN012776, and as always with Apple is a subtly incompatible variant with a number of quirks. It is not publicly available. The TAS2770 variant is known as TAS5770L, and does not require incompatible handling.
Much as with the Cirrus codec patches, I do not
expect that we will get any official acknowledgement that these parts exist from TI, however I would be delighted to be proven wrong.
This series has been living in the downstream Asahi kernel tree[1] for over two years, and has been tested by many thousands of users by this point[2].
v4 drops the TDM idle TX slot behaviour patches. I experimented with the API discussed in v3, however this did not work on any of the machines I tested it with. More tweaking is probably needed.
[1] https://github.com/AsahiLinux/linux/tree/asahi-wip
[2] https://stats.asahilinux.org/
---
Changes in v5:
- Dropped two commits that depended on TX idle stuff (sorry)
- Link to v4: https://lore.kernel.org/r/[email protected]
Changes in v4:
- Moved remaining changes to the top of the set
- Dropped already merged commits
- hwmon now reads temp from regmap
- Bumped regmap max reg patch above Apple quirks patch
- Dropped TDM idle slot TX behaviour patches
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in v3:
- Add Rob's Acked-by to Devicetree compatible additions
- Dropped cherry-picked patches
- Droped abuse of regulator API
- Droped bespoke sysfs interface
- Rationalised temperature reading for hwmon interface
- Set SN012776 device ID with OF match data
- Changed probe ops reliant on device ID to case/switch statement
- Added documentation for new Devicetree properties
- Improved a number of poor quality commit messages
- Documented behaviour of die temperature ADC
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Changed author field of patch to match Martin's Signed-off-by
- Added Neal's Reviewed-by to reviewed patches
- Moved fixes to existing code to the top of the series
- Removed tas2764's explicit dependency on OF
- Removed complicated single-use tas2764 quirks macro and replaced with
if block
- Added hwmon interface for codec die temp
- Fixed a malformed commit message
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Hector Martin (3):
ASoC: tas2770: Power cycle amp on ISENSE/VSENSE change
ASoC: tas2770: Support setting the PDM TX slot
ASoC: tas2764: Enable main IRQs
James Calligeros (2):
ASoC: tas2770: expose die temp to hwmon
ASoC: tas2764: expose die temp to hwmon
Martin Povišer (3):
ASoC: tas2764: Reinit cache on part reset
ASoC: tas2764: Raise regmap range maximum
ASoC: tas2764: Apply Apple quirks
sound/soc/codecs/tas2764-quirks.h | 180 +++++++++++++++++++++++++ sound/soc/codecs/tas2764.c | 137 ++++++++++++++++++- sound/soc/codecs/tas2764.h | 3 + sound/soc/codecs/tas2770.c | 151 ++++++++++++++++++++- sound/soc/codecs/tas2770.h | 6 + 5 files changed, 472 insertions(+), 5 deletions(-)
---
base-commit: 3a0f0a4355df0240485ed62b6bd6afa5b3e689c5
change-id: 20250214-apple-codec-changes-6e656dc1e24d
Best regards,
Signature · 1 line
James Calligeros <[email protected]>
PATCH v5 1/8 ASoC: tas2770: Power cycle amp on ISENSE/VSENSE change
From: Hector Martin <[email protected]>
The ISENSE/VSENSE blocks are only powered up when the amplifier transitions from shutdown to active. This means that if those controls are flipped on while the amplifier is already playing back audio, they will have no effect.
Fix this by forcing a power cycle around transitions in those controls.
--- sound/soc/codecs/tas2770.c | 30 +++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-)
sound/soc/codecs/tas2770.c +28 -2
@@ -156,11 +156,37 @@ static const struct snd_kcontrol_new isense_switch =static const struct snd_kcontrol_new vsense_switch =SOC_DAPM_SINGLE ("Switch" ,TAS2770_PWR_CTRL ,2 ,1 ,1 ); +static int sense_event (struct snd_soc_dapm_widget *w, +struct snd_kcontrol *kcontrol,int event) +{ +struct snd_soc_component *component =snd_soc_dapm_to_component (w->dapm); +struct tas2770_priv *tas2770 =snd_soc_component_get_drvdata (component); + +/* +* Powering up ISENSE/VSENSE requires a trip through the shutdown state. +* Do that here to ensure that our changes are applied properly, otherwise +* we might end up with non-functional IVSENSE if playback started earlier, +* which would break software speaker protection. +*/ +switch (event) { +case SND_SOC_DAPM_PRE_REG : +return snd_soc_component_update_bits (component,TAS2770_PWR_CTRL , +TAS2770_PWR_CTRL_MASK , +TAS2770_PWR_CTRL_SHUTDOWN ); +case SND_SOC_DAPM_POST_REG : +return tas2770_update_pwr_ctrl (tas2770); +default : +return 0 ; + } +} +static const struct snd_soc_dapm_widget tas2770_dapm_widgets[] = {SND_SOC_DAPM_AIF_IN ("ASI1" ,"ASI1 Playback" ,0 ,SND_SOC_NOPM ,0 ,0 ),SND_SOC_DAPM_MUX ("ASI1 Sel" ,SND_SOC_NOPM ,0 ,0 , &tas2770_asi1_mux), -SND_SOC_DAPM_SWITCH ("ISENSE" ,TAS2770_PWR_CTRL ,3 ,1 , &isense_switch), -SND_SOC_DAPM_SWITCH ("VSENSE" ,TAS2770_PWR_CTRL ,2 ,1 , &vsense_switch), +SND_SOC_DAPM_SWITCH_E ("ISENSE" ,TAS2770_PWR_CTRL ,3 ,1 , &isense_switch, + sense_event,SND_SOC_DAPM_PRE_REG |SND_SOC_DAPM_POST_REG ), +SND_SOC_DAPM_SWITCH_E ("VSENSE" ,TAS2770_PWR_CTRL ,2 ,1 , &vsense_switch, + sense_event,SND_SOC_DAPM_PRE_REG |SND_SOC_DAPM_POST_REG ),SND_SOC_DAPM_DAC_E ("DAC" ,NULL ,SND_SOC_NOPM ,0 ,0 , tas2770_dac_event,SND_SOC_DAPM_POST_PMU |SND_SOC_DAPM_PRE_PMD ),SND_SOC_DAPM_OUTPUT ("OUT" ),
Signature · 1 line
2.49.0
PATCH v5 2/8 ASoC: tas2770: Support setting the PDM TX slot
In reply to James CalligerosFrom: Hector Martin <[email protected]>
We don't actually support configuring the PDM input right now. Rather, this is useful as a hack.
On Apple Silicon machines, amps are split between two I2S buses which are logically ANDed internally at the SoC. Odd and even slot groups are driven by amps on either bus respectively. Since the signals are ANDed, unused slot groups must be driven as zero to avoid corrupting the data from the other side.
On most recent machines (TAS2764-based), this is accomplished using the "SDOUT zero mask" feature of that chip. Unfortunately, TAS2770 does not support this. It does support zeroing out *all* unused slots, which works well for machines with a single amp per I2S bus. That is all, except one.
The 13" M1 MacBook Pro is the only machine using TAS2770 and two amps per I2S bus:
L Bus: SPK0I SPK0V Hi-Z Hi-Z SPK2I SPK2V Hi-Z Hi-Z R Bus: Hi-Z Hi-Z SPK1I SPK2V Hi-Z Hi-Z SPK3I SPK3V
To ensure uncorrupted data, we need to force all the Hi-Z periods to zero. We cannot use the "force all zero" feature, as that would cause a bus conflict between both amps. We can use the pull-down feature, but that leaves a few bits of garbage on the trailing edge of the speaker data, since the pull-down is weak.
This is where the PDM transmit feature comes in. With PDM grounded and disabled (the default state), the PDM slot is transmitted as all zeroes. We can use that to force a zero 16-bit slot after the voltage data for each speaker, cleaning it up. Then the pull-down ensures the line stays low for the subsequent slot:
L Bus: SPK0I SPK0V PDM0 PulDn SPK2I SPK2V PDM0 PulDn R Bus: PDM0 PulDn SPK1I SPK2V PDM0 PulDn SPK3I SPK3V
Yes, this is a horrible hack, but it beats adding dummy slots that would be visible to the userspace capture side. There may be some other way to fix the logical AND behavior on the MCA side... that would make this unnecessary.
("How does Apple deal with this"? - they don't, macOS does not use IVSENSE on TAS2770 machines even though it's physically wired up, but we want to do so on Linux.)
--- sound/soc/codecs/tas2770.c | 25 +++++++++++++++++++++++++ sound/soc/codecs/tas2770.h | 6 ++++++ 2 files changed, 31 insertions(+)
sound/soc/codecs/tas2770.c +25 -0
@@ -240,6 +240,19 @@ static int tas2770_set_ivsense_transmit(struct tas2770_priv *tas2770,return 0 ; } +static int tas2770_set_pdm_transmit (struct tas2770_priv *tas2770,int slot) +{ +struct snd_soc_component *component = tas2770->component; +int ret; + + ret =snd_soc_component_update_bits (component,TAS2770_TDM_CFG_REG7 , +TAS2770_TDM_CFG_REG7_PDM_MASK | +TAS2770_TDM_CFG_REG7_50_MASK , +TAS2770_TDM_CFG_REG7_PDM_ENABLE | + slot); +return ret; +} +static int tas2770_set_bitwidth (struct tas2770_priv *tas2770,int bitwidth) {int ret;
@@ -543,6 +556,13 @@ static int tas2770_codec_probe(struct snd_soc_component *component)return ret; } +if (tas2770->pdm_slot !=-1 ) { + ret =tas2770_set_pdm_transmit (tas2770, tas2770->pdm_slot); + +if (ret <0 ) +return ret; + } +return 0 ; }
@@ -682,6 +702,11 @@ static int tas2770_parse_dt(struct device *dev, struct tas2770_priv *tas2770) tas2770->v_sense_slot =-1 ; } + rc =fwnode_property_read_u32 (dev->fwnode,"ti,pdm-slot-no" , + &tas2770->pdm_slot); +if (rc) + tas2770->pdm_slot =-1 ; + tas2770->sdz_gpio =devm_gpiod_get_optional (dev,"shutdown" ,GPIOD_OUT_HIGH );if (IS_ERR (tas2770->sdz_gpio)) {if (PTR_ERR (tas2770->sdz_gpio) == -EPROBE_DEFER )
sound/soc/codecs/tas2770.h +6 -0
@@ -77,6 +77,11 @@#define TAS2770_TDM_CFG_REG6_ISNS_MASK BIT(6)#define TAS2770_TDM_CFG_REG6_ISNS_ENABLE BIT(6)#define TAS2770_TDM_CFG_REG6_50_MASK GENMASK(5, 0) +/* TDM Configuration Reg10 */ +#define TAS2770_TDM_CFG_REG7 TAS2770_REG(0X0, 0x11) +#define TAS2770_TDM_CFG_REG7_PDM_MASK BIT(6) +#define TAS2770_TDM_CFG_REG7_PDM_ENABLE BIT(6) +#define TAS2770_TDM_CFG_REG7_50_MASK GENMASK(5, 0)/* Brown Out Prevention Reg0 */ #define TAS2770_BO_PRV_REG0 TAS2770_REG(0X0, 0x1B)/* Interrupt MASK Reg0 */
@@ -138,6 +143,7 @@ struct tas2770_priv {struct device *dev;int v_sense_slot;int i_sense_slot; +int pdm_slot;bool dac_powered;bool unmuted; };
Signature · 1 line
2.49.0
PATCH v5 3/8 ASoC: tas2764: Reinit cache on part reset
In reply to James CalligerosFrom: Martin Povišer <[email protected]>
When the part is reset in component_probe, do not forget to reinit the regcache, otherwise the cache can get out of sync with the part's actual state. This fix is similar to commit 0a0342ede303 ("ASoC: tas2770: Reinit regcache on reset") which concerned the tas2770 driver.
--- sound/soc/codecs/tas2764.c | 3 +++ 1 file changed, 3 insertions(+)
sound/soc/codecs/tas2764.c +3 -0
@@ -546,6 +546,8 @@ static uint8_t sn012776_bop_presets[] = { 0x06, 0x3e, 0x37, 0x30, 0xff, 0xe6 }; +static const struct regmap_config tas2764_i2c_regmap; +static int tas2764_codec_probe (struct snd_soc_component *component) {struct tas2764_priv *tas2764 =snd_soc_component_get_drvdata (component);
@@ -559,6 +561,7 @@ static int tas2764_codec_probe(struct snd_soc_component *component) }tas2764_reset (tas2764); +regmap_reinit_cache (tas2764->regmap, &tas2764_i2c_regmap);if (tas2764->irq) { ret =snd_soc_component_write (tas2764->component,TAS2764_INT_MASK0 ,0xff );
Signature · 1 line
2.49.0
PATCH v5 4/8 ASoC: tas2764: Enable main IRQs
In reply to James CalligerosFrom: Hector Martin <[email protected]>
IRQ handling was added in commit dae191fb957f ("ASoC: tas2764: Add IRQ handling") however that same commit masks all interrupts coming from the chip. Unmask the "main" interrupts so that we can see and deal with a number of errors including clock, voltage, and current.
--- sound/soc/codecs/tas2764.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/tas2764.c +1 -1
@@ -564,7 +564,7 @@ static int tas2764_codec_probe(struct snd_soc_component *component)regmap_reinit_cache (tas2764->regmap, &tas2764_i2c_regmap);if (tas2764->irq) { - ret =snd_soc_component_write (tas2764->component,TAS2764_INT_MASK0 ,0xff ); + ret =snd_soc_component_write (tas2764->component,TAS2764_INT_MASK0 ,0x00 );if (ret <0 )return ret;
Signature · 1 line
2.49.0
PATCH v5 5/8 ASoC: tas2764: Raise regmap range maximum
In reply to James CalligerosFrom: Martin Povišer <[email protected]>
TAS2764 has a number of undocumented registers between page 0xf0 and 0xff. These are used to apply in-silicon quirks and workarounds at runtime.
Raise the regmap max register to 0xffff to cover any quirks registers.
--- sound/soc/codecs/tas2764.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/tas2764.c +2 -2
@@ -685,7 +685,7 @@ static const struct reg_default tas2764_reg_defaults[] = {static const struct regmap_range_cfg tas2764_regmap_ranges[] = { { .range_min =0 , - .range_max =1 *128 , + .range_max =0xffff , .selector_reg =TAS2764_PAGE , .selector_mask =0xff , .selector_shift =0 ,
@@ -715,7 +715,7 @@ static const struct regmap_config tas2764_i2c_regmap = { .cache_type = REGCACHE_RBTREE, .ranges = tas2764_regmap_ranges, .num_ranges = ARRAY_SIZE(tas2764_regmap_ranges), - .max_register = 1 * 128, + .max_register = 0xffff, };static int tas2764_parse_dt (struct device *dev,struct tas2764_priv *tas2764)
Signature · 1 line
2.49.0
PATCH v5 6/8 ASoC: tas2764: Apply Apple quirks
In reply to James CalligerosFrom: Martin Povišer <[email protected]>
Apple's SN012776 driver has some peculiar aspects to its behavior that are suspected to work around issues in the codec part. Add a module parameter for enabling individual quirks that should be imitated after the Apple driver.
Setting some of these by default seems to be required. For example, setting 0xf fixes an issue with transient overcurrent errors which can crash the chip until the next system reboot. To be safe, let's enable all of them by default.
--- sound/soc/codecs/tas2764-quirks.h | 180 +++++++++++++++++++++++++ sound/soc/codecs/tas2764.c | 39 ++++++ 2 files changed, 219 insertions(+)
sound/soc/codecs/tas2764-quirks.h new file +180 -0
@@ -0,0 +1,180 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __TAS2764_QUIRKS__ +#define __TAS2764_QUIRKS__ + +#include <linux/regmap.h> + +#include "tas2764.h" + +/* Bitmask of enabled Apple quirks */ +#define ENABLED_APPLE_QUIRKS 0x3f + +/* +* Disable noise gate and flip down reserved bit in NS_CFG0 +*/ +#define TAS2764_NOISE_GATE_DISABLE BIT(0) + +static const struct reg_sequence tas2764_noise_gate_dis_seq[] = { +REG_SEQ0 (TAS2764_REG (0x0 ,0x35 ),0xb0 ) +}; + +/* +* CONV_VBAT_PVDD_MODE=1 +*/ +#define TAS2764_CONV_VBAT_PVDD_MODE BIT(1) + +static const struct reg_sequence tas2764_conv_vbat_pvdd_mode_seq[] = { +REG_SEQ0 (TAS2764_REG (0x0 ,0x6b ),0x41 ) +}; + +/* +* Reset of DAC modulator when DSP is OFF +*/ +#define TAS2764_DMOD_RST BIT(2) + +static const struct reg_sequence tas2764_dmod_rst_seq[] = { +REG_SEQ0 (TAS2764_REG (0x0 ,0x76 ),0x0 ) +}; + +/* +* Unknown 0x133/0x137 writes (maybe TDM related) +*/ +#define TAS2764_UNK_SEQ0 BIT(3) + +static const struct reg_sequence tas2764_unk_seq0[] = { +REG_SEQ0 (TAS2764_REG (0x1 ,0x33 ),0x80 ), +REG_SEQ0 (TAS2764_REG (0x1 ,0x37 ),0x3a ), +}; + +/* +* Unknown 0x614 - 0x61f writes +*/ +#define TAS2764_APPLE_UNK_SEQ1 BIT(4) + +static const struct reg_sequence tas2764_unk_seq1[] = { +REG_SEQ0 (TAS2764_REG (0x6 ,0x14 ),0x0 ), +REG_SEQ0 (TAS2764_REG (0x6 ,0x15 ),0x13 ), +REG_SEQ0 (TAS2764_REG (0x6 ,0x16 ),0x52 ), +REG_SEQ0 (TAS2764_REG (0x6 ,0x17 ),0x0 ), +REG_SEQ0 (TAS2764_REG (0x6 ,0x18 ),0xe4 ), +REG_SEQ0 (TAS2764_REG (0x6 ,0x19 ),0xc ), +REG_SEQ0 (TAS2764_REG (0x6 ,0x16 ),0xaa ), +REG_SEQ0 (TAS2764_REG (0x6 ,0x1b ),0x0 ), +REG_SEQ0 (TAS2764_REG (0x6 ,0x1c ),0x12 ), +REG_SEQ0 (TAS2764_REG (0x6 ,0x1d ),0xa0 ), +REG_SEQ0 (TAS2764_REG (0x6 ,0x1e ),0xd8 ), +REG_SEQ0 (TAS2764_REG (0x6 ,0x1f ),0x0 ), +}; + +/* +* Unknown writes in the 0xfd page (with secondary paging inside) +*/ +#define TAS2764_APPLE_UNK_SEQ2 BIT(5) + +static const struct reg_sequence tas2764_unk_seq2[] = { +REG_SEQ0 (TAS2764_REG (0xfd ,0x0d ),0xd ), +REG_SEQ0 (TAS2764_REG (0xfd ,0x6c ),0x2 ), +REG_SEQ0 (TAS2764_REG (0xfd ,0x6d ),0xf ), +REG_SEQ0 (TAS2764_REG (0xfd ,0x0d ),0x0 ), +}; + +/* +* Disable 'Thermal Threshold 1' +*/ +#define TAS2764_THERMAL_TH1_DISABLE BIT(6) + +static const struct reg_sequence tas2764_thermal_th1_dis_seq[] = { +REG_SEQ0 (TAS2764_REG (0x1 ,0x47 ),0x2 ), +}; + +/* +* Imitate Apple's shutdown dance +*/ +#define TAS2764_SHUTDOWN_DANCE BIT(7) + +static const struct reg_sequence tas2764_shutdown_dance_init_seq[] = { +/* +* SDZ_MODE=01 (immediate) +* +* We want the shutdown to happen under the influence of +* the magic writes in the 0xfdXX region, so make sure +* the shutdown is immediate and there's no grace period +* followed by the codec part. +*/ +REG_SEQ0 (TAS2764_REG (0x0 ,0x7 ),0x60 ), +}; + +static const struct reg_sequence tas2764_pre_shutdown_seq[] = { +REG_SEQ0 (TAS2764_REG (0xfd ,0x0d ),0xd ),/* switch hidden page */ +REG_SEQ0 (TAS2764_REG (0xfd ,0x64 ),0x4 ),/* do write (unknown semantics) */ +REG_SEQ0 (TAS2764_REG (0xfd ,0x0d ),0x0 ),/* switch hidden page back */ +}; + +static const struct reg_sequence tas2764_post_shutdown_seq[] = { +REG_SEQ0 (TAS2764_REG (0xfd ,0x0d ),0xd ), +REG_SEQ0 (TAS2764_REG (0xfd ,0x64 ),0x0 ),/* revert write from pre sequence */ +REG_SEQ0 (TAS2764_REG (0xfd ,0x0d ),0x0 ), +}; + +static int tas2764_do_quirky_pwr_ctrl_change (struct tas2764_priv *tas2764, +unsigned int target) +{ +unsigned int curr; +int ret; + + curr =snd_soc_component_read_field (tas2764->component, +TAS2764_PWR_CTRL , +TAS2764_PWR_CTRL_MASK ); + +if (target == curr) +return 0 ; + +/* Handle power state transition to shutdown */ +if (target ==TAS2764_PWR_CTRL_SHUTDOWN && + (curr ==TAS2764_PWR_CTRL_MUTE || curr ==TAS2764_PWR_CTRL_ACTIVE )) { + ret =regmap_multi_reg_write (tas2764->regmap, tas2764_pre_shutdown_seq, +ARRAY_SIZE (tas2764_pre_shutdown_seq)); +if (!ret) + ret =snd_soc_component_update_bits (tas2764->component, +TAS2764_PWR_CTRL , +TAS2764_PWR_CTRL_MASK , +TAS2764_PWR_CTRL_SHUTDOWN ); +if (!ret) + ret =regmap_multi_reg_write (tas2764->regmap, + tas2764_post_shutdown_seq, +ARRAY_SIZE (tas2764_post_shutdown_seq)); + } + + ret =snd_soc_component_update_bits (tas2764->component,TAS2764_PWR_CTRL , +TAS2764_PWR_CTRL_MASK , target); + +return ret; +} + +/* +* Via devicetree (TODO): +* - switch from spread spectrum to class-D switching +* - disable edge control +* - set BOP settings (the BOP config bits *and* BOP_SRC) +*/ + +/* +* Other setup TODOs: +* - DVC ramp rate +*/ + +static const struct tas2764_quirk_init_sequence { +const struct reg_sequence *seq; +int len; +} tas2764_quirk_init_sequences[] = { + { tas2764_noise_gate_dis_seq,ARRAY_SIZE (tas2764_noise_gate_dis_seq) }, + { tas2764_dmod_rst_seq,ARRAY_SIZE (tas2764_dmod_rst_seq) }, + { tas2764_conv_vbat_pvdd_mode_seq,ARRAY_SIZE (tas2764_conv_vbat_pvdd_mode_seq) }, + { tas2764_unk_seq0,ARRAY_SIZE (tas2764_unk_seq0) }, + { tas2764_unk_seq1,ARRAY_SIZE (tas2764_unk_seq1) }, + { tas2764_unk_seq2,ARRAY_SIZE (tas2764_unk_seq2) }, + { tas2764_thermal_th1_dis_seq,ARRAY_SIZE (tas2764_thermal_th1_dis_seq) }, + { tas2764_shutdown_dance_init_seq,ARRAY_SIZE (tas2764_shutdown_dance_init_seq) }, +}; + +#endif /* __TAS2764_QUIRKS__ */
sound/soc/codecs/tas2764.c +39 -0
@@ -45,6 +45,8 @@ struct tas2764_priv {bool unmuted; }; +#include "tas2764-quirks.h" +static const char *tas2764_int_ltch0_msgs[8 ] = {"fault: over temperature" ,/* INT_LTCH0 & BIT(0) */ "fault: over current" ,
@@ -122,6 +124,9 @@ static int tas2764_update_pwr_ctrl(struct tas2764_priv *tas2764)else val =TAS2764_PWR_CTRL_SHUTDOWN ; +if (ENABLED_APPLE_QUIRKS &TAS2764_SHUTDOWN_DANCE ) +return tas2764_do_quirky_pwr_ctrl_change (tas2764, val); + ret =snd_soc_component_update_bits (component,TAS2764_PWR_CTRL ,TAS2764_PWR_CTRL_MASK , val);if (ret <0 )
@@ -548,6 +553,30 @@ static uint8_t sn012776_bop_presets[] = {static const struct regmap_config tas2764_i2c_regmap; +static int tas2764_apply_init_quirks (struct tas2764_priv *tas2764) +{ +int ret, i; + +for (i =0 ; i <ARRAY_SIZE (tas2764_quirk_init_sequences); i++) { +const struct tas2764_quirk_init_sequence *init_seq = + &tas2764_quirk_init_sequences[i]; + +if (!init_seq->seq) +continue ; + +if (!(BIT (i) &ENABLED_APPLE_QUIRKS )) +continue ; + + ret =regmap_multi_reg_write (tas2764->regmap, init_seq->seq, + init_seq->len); + +if (ret <0 ) +return ret; + } + +return 0 ; +} +static int tas2764_codec_probe (struct snd_soc_component *component) {struct tas2764_priv *tas2764 =snd_soc_component_get_drvdata (component);
@@ -617,6 +646,13 @@ static int tas2764_codec_probe(struct snd_soc_component *component)if (ret <0 )return ret; } + +/* Apply all enabled Apple quirks */ + ret =tas2764_apply_init_quirks (tas2764); + +if (ret <0 ) +return ret; +break ;default :break ;
@@ -701,6 +737,9 @@ static bool tas2764_volatile_register(struct device *dev, unsigned int reg) case TAS2764_INT_LTCH0 ... TAS2764_INT_LTCH4:case TAS2764_INT_CLK_CFG :return true; + case TAS2764_REG(0xf0, 0x0) ... TAS2764_REG(0xff, 0x0): +/* TI's undocumented registers for the application of quirks */ +return true;default :return false; }
Signature · 1 line
2.49.0
PATCH v5 7/8 ASoC: tas2770: expose die temp to hwmon
In reply to James CalligerosTAS2770 includes an ADC which reports the chip's die temperature. As per the datasheet, the temperature in degrees Celsius is derived by taking the raw value stored in the ADC's registers, dividing by 16, then subtracting 93.
Create and register a hwmon device to expose the chip's die temperature to the hwmon interface.
The ADC is shut down during software shutdown mode, and its registers are initialised to 0 on reset. This means that the die temperature will read -93 *C until the chip has been fully powered up at least once (e.g. the PCM its attached to is opened). Once the chip is put into software shutdown again, the ADC will also shut down. The last value sampled before this happens will persist in the ADC's registers.
--- sound/soc/codecs/tas2770.c | 96 +++++++++++++++++++++++++ 1 file changed, 96 insertions(+)
sound/soc/codecs/tas2770.c +96 -0
@@ -12,6 +12,7 @@#include <linux/err.h> #include <linux/init.h> #include <linux/delay.h> +#include <linux/hwmon.h> #include <linux/pm.h> #include <linux/i2c.h> #include <linux/gpio/consumer.h>
@@ -530,6 +531,88 @@ static struct snd_soc_dai_driver tas2770_dai_driver[] = { }, }; +static int tas2770_read_die_temp (struct tas2770_priv *tas2770,long *result) +{ +int ret =0 ; +int reading, msb, lsb; + + ret =regmap_read (tas2770->regmap,TAS2770_TEMP_MSB , &msb); +if (ret) +return ret; + + ret =regmap_read (tas2770->regmap,TAS2770_TEMP_LSB , &lsb); +if (ret) +return ret; + + reading = (msb <<4 ) | (lsb >>4 ); + +/* +* As per datasheet: divide register by 16 and subtract 93 to get +* degrees Celsius. hwmon requires millidegrees. Let's avoid rounding +* errors by subtracting 93 * 16 then multiplying by 1000 / 16. +* +* NOTE: The ADC registers are initialised to 0 on reset. This means +* that the temperature will read -93 *C until the chip is brought out +* of software shutdown (e.g. the PCM it's attached to is opened). The +* ADC is also shut down in software shutdown/low-power mode, so the +* value read back from its registers will be the last value sampled +* before entering software shutdown. +*/ + *result = (reading - (93 *16 )) * (1000 /16 ); +return 0 ; +} + +static umode_t tas2770_hwmon_is_visible (const void *data, +enum hwmon_sensor_types type,u32 attr, +int channel) +{ +if (type != hwmon_temp) +return 0 ; + +switch (attr) { +case hwmon_temp_input: +return 0444 ; +default : +break ; + } + +return 0 ; +} + +static int tas2770_hwmon_read (struct device *dev, +enum hwmon_sensor_types type, +u32 attr,int channel,long *val) +{ +struct tas2770_priv *tas2770 =dev_get_drvdata (dev); +int ret; + +switch (attr) { +case hwmon_temp_input: + ret =tas2770_read_die_temp (tas2770, val); +break ; +default : + ret = -EOPNOTSUPP ; +break ; + } + +return ret; +} + +static const struct hwmon_channel_info *const tas2770_hwmon_info[] = { +HWMON_CHANNEL_INFO (temp,HWMON_T_INPUT ), +NULL +}; + +static const struct hwmon_ops tas2770_hwmon_ops = { + .is_visible = tas2770_hwmon_is_visible, + .read = tas2770_hwmon_read, +}; + +static const struct hwmon_chip_info tas2770_hwmon_chip_info = { + .ops = &tas2770_hwmon_ops, + .info = tas2770_hwmon_info, +}; +static const struct regmap_config tas2770_i2c_regmap;static int tas2770_codec_probe (struct snd_soc_component *component)
@@ -758,6 +841,19 @@ static int tas2770_i2c_probe(struct i2c_client *client) } } +if (IS_REACHABLE (CONFIG_HWMON )) { +struct device *hwmon; + + hwmon =devm_hwmon_device_register_with_info (&client->dev,"tas2770" , + tas2770, + &tas2770_hwmon_chip_info, +NULL ); +if (IS_ERR (hwmon)) { +return dev_err_probe (&client->dev,PTR_ERR (hwmon), +"Failed to register temp sensor\n" ); + } + } + result =tas2770_register_codec (tas2770);if (result)dev_err (tas2770->dev,"Register codec failed.\n" );
Signature · 1 line
2.49.0
PATCH v5 8/8 ASoC: tas2764: expose die temp to hwmon
In reply to James CalligerosTAS2764 contains an ADC that reports the chip's die temperature. The temperature in degrees Celsius is yielded by subtracting 93 from the raw value reported by the ADC.
Expose the codec die temperature to the hwmon interface.
The chip will initialise the temperature register to 2.6 *C to avoid triggering over temp protection. As the ADC is powered down during software shutdown, this value will persist until the chip is fully powered up (e.g. when the PCM it's attached to is opened). When the chip is powered back down, the last value sampled will persist in the register.
--- sound/soc/codecs/tas2764.c | 89 +++++++++++++++++++++++++ sound/soc/codecs/tas2764.h | 3 + 2 files changed, 92 insertions(+)
sound/soc/codecs/tas2764.c +89 -0
@@ -8,6 +8,7 @@#include <linux/err.h> #include <linux/init.h> #include <linux/delay.h> +#include <linux/hwmon.h> #include <linux/pm.h> #include <linux/i2c.h> #include <linux/gpio/consumer.h>
@@ -577,6 +578,80 @@ static int tas2764_apply_init_quirks(struct tas2764_priv *tas2764)return 0 ; } +static int tas2764_read_die_temp (struct tas2764_priv *tas2764,long *result) +{ +int ret, reg; + + ret =regmap_read (tas2764->regmap,TAS2764_TEMP , ®); +if (ret) +return ret; +/* +* As per datasheet, subtract 93 from raw value to get degrees +* Celsius. hwmon wants millidegrees. +* +* NOTE: The chip will initialise the TAS2764_TEMP register to +* 2.6 *C to avoid triggering temperature protection. Since the +* ADC is powered down during software shutdown, this value will +* persist until the chip is fully powered up (e.g. the PCM it's +* attached to is opened). The ADC will power down again when +* the chip is put back into software shutdown, with the last +* value sampled persisting in the ADC's register. +*/ + *result = (reg -93 ) *1000 ; +return 0 ; +} + +static umode_t tas2764_hwmon_is_visible (const void *data, +enum hwmon_sensor_types type,u32 attr, +int channel) +{ +if (type != hwmon_temp) +return 0 ; + +switch (attr) { +case hwmon_temp_input: +return 0444 ; +default : +break ; + } + +return 0 ; +} + +static int tas2764_hwmon_read (struct device *dev, +enum hwmon_sensor_types type, +u32 attr,int channel,long *val) +{ +struct tas2764_priv *tas2764 =dev_get_drvdata (dev); +int ret; + +switch (attr) { +case hwmon_temp_input: + ret =tas2764_read_die_temp (tas2764, val); +break ; +default : + ret = -EOPNOTSUPP ; +break ; + } + +return ret; +} + +static const struct hwmon_channel_info *const tas2764_hwmon_info[] = { +HWMON_CHANNEL_INFO (temp,HWMON_T_INPUT ), +NULL +}; + +static const struct hwmon_ops tas2764_hwmon_ops = { + .is_visible = tas2764_hwmon_is_visible, + .read = tas2764_hwmon_read, +}; + +static const struct hwmon_chip_info tas2764_hwmon_chip_info = { + .ops = &tas2764_hwmon_ops, + .info = tas2764_hwmon_info, +}; +static int tas2764_codec_probe (struct snd_soc_component *component) {struct tas2764_priv *tas2764 =snd_soc_component_get_drvdata (component);
@@ -825,6 +900,20 @@ static int tas2764_i2c_probe(struct i2c_client *client) } } +if (IS_REACHABLE (CONFIG_HWMON )) { +struct device *hwmon; + + hwmon =devm_hwmon_device_register_with_info (&client->dev,"tas2764" , + tas2764, + &tas2764_hwmon_chip_info, +NULL ); +if (IS_ERR (hwmon)) { +return dev_err_probe (&client->dev,PTR_ERR (hwmon), +"Failed to register temp sensor\n" ); + } + } + + return devm_snd_soc_register_component(tas2764->dev, &soc_component_driver_tas2764, tas2764_dai_driver,
sound/soc/codecs/tas2764.h +3 -0
@@ -117,6 +117,9 @@#define TAS2764_INT_LTCH3 TAS2764_REG(0x0, 0x50)#define TAS2764_INT_LTCH4 TAS2764_REG(0x0, 0x51) +/* Readout Registers */ +#define TAS2764_TEMP TAS2764_REG(0x0, 0x56) +/* Clock/IRQ Settings */ #define TAS2764_INT_CLK_CFG TAS2764_REG(0x0, 0x5c)#define TAS2764_INT_CLK_CFG_IRQZ_CLR BIT(2)
Signature · 1 line
2.49.0
Mark Brown
maintainerQuoted 11 lines · James Calligeros
This series introduces a number of changes to the drivers for the Texas Instruments TAS2764 and TAS2770 amplifiers in order to introduce (and improve in the case of TAS2770) support for the variants of these amps found in Apple Silicon Macs.
Apple's variant of TAS2764 is known as SN012776, and as always with Apple is a subtly incompatible variant with a number of quirks. It is not publicly available. The TAS2770 variant is known as TAS5770L, and does not require incompatible handling.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/8] ASoC: tas2770: Power cycle amp on ISENSE/VSENSE change
commit: f529c91be8a34ac12e7599bf87c65b6f4a2c9f5c
[2/8] ASoC: tas2770: Support setting the PDM TX slot
commit: 7699892ad3cf3a9afc8c63886344f6e2b73166e2
[3/8] ASoC: tas2764: Reinit cache on part reset
commit: 592ab3936b096da5deb64d4c906edbeb989174d6
[4/8] ASoC: tas2764: Enable main IRQs
commit: dd50f0e38563f15819059c923bf142200453e003
[5/8] ASoC: tas2764: Raise regmap range maximum
commit: f0aff451f399d09aaf2a23c4e2ef2077b9857ca5
[6/8] ASoC: tas2764: Apply Apple quirks
commit: f33b01e0947d81c514bc8ff31ad28cae7ff6d91f
[7/8] ASoC: tas2770: expose die temp to hwmon
commit: ff73e2780169a43617cc339686f5bd3d74fa8652
[8/8] ASoC: tas2764: expose die temp to hwmon
commit: 186dfc85f9a824e3f8383322747ca75e988486e9All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark