Skip to content

i2c: core: Move client towards fwnode

Andy Shevchenko linux-i2c linux-media lkml 6 versions – Applied

Status from this message: Applied to for-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest7 patches 2 repliesApplied
  2. v47 patches 14 repliesSuperseded
  3. v37 patches 7 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v2 posting 2/26 patches3 repliesSuperseded
v2 posting 1/21 patch2 repliesApplied
v11 patch1 replySuperseded

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/7i2c: core: Drop duplicate check before calling OF APIsdrivers/i2c/i2c-core-base.c+7 -110 replies
2/7i2c: core: Unify the firmware node type checkdrivers/i2c/i2c-core-base.c drivers/i2c/i2c-core-slave.c+17 -100 replies
3/7i2c: core: Switch to fwnode APIs to get IRQdrivers/i2c/i2c-core-base.c+4 -50 replies
4/7i2c: core: Reuse fwnode variable where it makes sensedrivers/i2c/i2c-core-base.c+3 -30 replies
5/7i2c: core: Do not dereference fwnode in struct devicedrivers/i2c/i2c-core-base.c drivers/i2c/i2c-core-of.c+10 -100 replies
6/7i2c: core: Deprecate of_node in struct i2c_board_infoinclude/linux/i2c.h+1 -10 replies
7/7media: i2c: ds90ub960: Remove of_node assignmentdrivers/media/i2c/ds90ub960.c+0 -10 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchTomi ValkeinenSakari Ailus
1/7T-b R-b A-b
2/7T-b R-b A-b
3/7T-b R-b A-b
4/7T-b R-b A-b
5/7T-b R-b A-b
6/7T-b R-b A-b
7/7T-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/7] i2c: core: Move client towards fwnode

The struct i2c_board_info has of_node and fwnode members. This is quite confusing as they are of the same semantics and it's tend to have an issue if user assigns both. Luckily there is only a single driver that does this and fix is provided in the last patch. Nevertheless the series moves the client handling code to use fwnode and deprecates the of_node member in the respective documentation.

In v5:
- reformatted conditionals to make media CI happy (media CI)
- updated commit messages in patches 3 & 6 to make it more clear (Wolfram)

In v4:
- fixed spelling in the first patch commit message (Sakari)
- wrapped the commit message in the patch before the last (Sakari)
- added tag to the last patch (Tomi)

In v3:
- fixed compile issues with i2c-core-slave.c (LKP)
- fixed compile issues with IRQ APIs, i.e. missing header (LKP)
- added patch for the only user which assigns two fields (Tomi)
- added tags (Tomi)

In v2:
- covered i2c-core-slave.c where it makes sense
- covered i2c-core-of.c where it makes sense
- rebased on top of the latest code base

Andy Shevchenko (7):
i2c: core: Drop duplicate check before calling OF APIs
i2c: core: Unify the firmware node type check
i2c: core: Switch to fwnode APIs to get IRQ
i2c: core: Reuse fwnode variable where it makes sense
i2c: core: Do not dereference fwnode in struct device
i2c: core: Deprecate of_node in struct i2c_board_info
media: i2c: ds90ub960: Remove of_node assignment

 drivers/i2c/i2c-core-base.c   | 61 +++++++++++++++++------------------
 drivers/i2c/i2c-core-of.c     |  1 -
 drivers/i2c/i2c-core-slave.c  | 12 ++++---
 drivers/media/i2c/ds90ub960.c |  1 -
 include/linux/i2c.h           |  2 +-
 5 files changed, 39 insertions(+), 38 deletions(-)
Signature · 1 line
2.47.2