i3c: master: Drop duplicate check before calling OF APIs
PATCH 1/1 i3c: master: Drop duplicate check before calling OF APIs
OF APIs are usually NULL-aware and returns an error in case when device node is not present or supported. We already have a check for the returned value, no need to check for the parameter.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/i3c/master.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/i3c/master.c +2 -4
@@ -2486,7 +2486,7 @@ static int i3c_master_i2c_adapter_init(struct i3c_master_controller *master)struct i2c_adapter *adap =i3c_master_to_i2c_adapter (master);struct i2c_dev_desc *i2cdev;struct i2c_dev_boardinfo *i2cboardinfo; -int ret, id = -ENODEV ; +int ret, id; adap->dev.parent = master->dev.parent; adap->owner = master->dev.parent->driver->owner;
@@ -2497,9 +2497,7 @@ static int i3c_master_i2c_adapter_init(struct i3c_master_controller *master) adap->timeout =1000 ; adap->retries =3 ; -if (master->dev.of_node) - id =of_alias_get_id (master->dev.of_node,"i2c" ); - + id =of_alias_get_id (master->dev.of_node,"i2c" );if (id >=0 ) { adap->nr = id; ret =i2c_add_numbered_adapter (adap);
Signature · 1 line
2.47.2
Quoted 3 lines · Andy Shevchenko
OF APIs are usually NULL-aware and returns an error in case when device node is not present or supported. We already have a check for the returned value, no need to check for the parameter.
Ignore this, it is partially done.
Signature · 2 lines
With Best Regards, Andy Shevchenko