Skip to content

hw/riscv/virt.c: memmap usage cleanup

Daniel Henrique Barboza qemu-devel qemu-riscv 2 versions – Applied

Status from this message: Applied to riscv-to-apply.next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 9 repliesApplied
  2. v19 patches 12 repliesSuperseded

Changes from v2 from the cover letter

- patch 9:
- in create_fdt_socket_memory(), change 'addr' to hwaddr and use the HWADDR_PRIx fmt type
- v1 link: https://lore.kernel.org/qemu-riscv/[email protected]/

[1] https://lore.kernel.org/qemu-riscv/[email protected]/
[2] https://lore.kernel.org/qemu-riscv/[email protected]/

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/9hw/riscv/virt.c: enforce s->memmap use in machine_init()hw/riscv/virt.c+27 -270 replies
2/9hw/riscv/virt.c: remove trivial virt_memmap referenceshw/riscv/virt.c+14 -151 reply
3/9hw/riscv/virt.c: use s->memmap in virt_machine_done()hw/riscv/virt.c+7 -81 reply
4/9hw/riscv/virt.c: add 'base' arg in create_fw_cfg()hw/riscv/virt.c+2 -31 reply
5/9hw/riscv/virt.c: use s->memmap in create_fdt() pathhw/riscv/virt.c+10 -91 reply
6/9hw/riscv/virt.c: use s->memmap in create_fdt_sockets() pathhw/riscv/virt.c+47 -421 reply
7/9hw/riscv/virt.c: use s->memmap in create_fdt_virtio()hw/riscv/virt.c+10 -71 reply
8/9hw/riscv/virt.c: use s->memmap in finalize_fdt() functionshw/riscv/virt.c+22 -221 reply
9/9hw/riscv/virt.c: remove 'long' casts in fmt stringshw/riscv/virt.c+17 -151 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchAlistair FrancisJoel StanleyPhilippe Mathieu-Daudé
1/9R-b R-b
2/9R-b
3/9R-b
4/9R-b R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/9] hw/riscv/virt.c: memmap usage cleanup

Hi,

In this new version a small change was made in patch 9 after discussions with Joel during v1 [1]. The idea is that we want to be consistent (as close as we can) with the idea that a memory address is a hwaddr type.

This new version does not conflict with "hw/riscv/virt: device tree reg cleanups" from Joel [2].

No other changes made. Patches based on alistair/riscv-to-apply.next.

Changes from v2:
- patch 9:
- in create_fdt_socket_memory(), change 'addr' to hwaddr and use the HWADDR_PRIx fmt type
- v1 link: https://lore.kernel.org/qemu-riscv/[email protected]/

[1] https://lore.kernel.org/qemu-riscv/[email protected]/
[2] https://lore.kernel.org/qemu-riscv/[email protected]/

Daniel Henrique Barboza (9):
hw/riscv/virt.c: enforce s->memmap use in machine_init() hw/riscv/virt.c: remove trivial virt_memmap references hw/riscv/virt.c: use s->memmap in virt_machine_done() hw/riscv/virt.c: add 'base' arg in create_fw_cfg() hw/riscv/virt.c: use s->memmap in create_fdt() path hw/riscv/virt.c: use s->memmap in create_fdt_sockets() path hw/riscv/virt.c: use s->memmap in create_fdt_virtio() hw/riscv/virt.c: use s->memmap in finalize_fdt() functions hw/riscv/virt.c: remove 'long' casts in fmt strings

 hw/riscv/virt.c | 272 +++++++++++++++++++++++++-----------------------
 1 file changed, 140 insertions(+), 132 deletions(-)
Signature · 1 line
2.49.0