Skip to content

remoteproc: imx_rproc: allow attaching to running core kicked by the bootloader

Hiago De Franco imx linux-arm-kernel linux-pm linux-remoteproc lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 10 repliesIn review
  2. v63 patches 5 repliesSuperseded
  3. v53 patches 9 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v43 patches15 repliesSuperseded
v33 patches1 replySuperseded
v23 patches27 repliesSuperseded
v13 patches6 repliesSuperseded

Changes in v7 from the cover letter

- Added Peng reviewed-by.

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3pmdomain: core: introduce dev_pm_genpd_is_on()drivers/pmdomain/core.c include/linux/pm_domain.h+39 -00 replies
2/3remoteproc: imx_rproc: skip clock enable when M-core is managed by the SCUdrivers/remoteproc/imx_rproc.c+2 -20 replies
3/3remoteproc: imx_rproc: detect and attach to pre-booted remote coresdrivers/remoteproc/imx_rproc.c+32 -57 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchBjorn AnderssonPeng FanUlf Hansson
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/3] remoteproc: imx_rproc: allow attaching to running core kicked by the bootloader

From: Hiago De Franco <[email protected]>

This patch series depends on Ulf's patches that are currently under review, "pmdomain: Add generic ->sync_state() support to genpd" [1]. Without them, this series is not going to work.

For the i.MX8X and i.MX8 family SoCs, currently when the remotecore is started by the bootloader and the M core and A core are in the same partition, the driver is not capable to detect the remote core and report the correct state of it.

This patch series implement a new function, dev_pm_genpd_is_on(), which returns the power status of a given power domain (M core power domains IMX_SC_R_M4_0_PID0 and IMX_SC_R_M4_0_MU_1A in this case). If it is already powered on, the driver will attach to it.

Finally, the imx_rproc_clk_enable() function was also changed to make it return before dev_clk_get() is called, as it currently generates an SCU fault reset if the remote core is already running and the kernel tries to enable the clock again. These changes are a follow up from a v1 sent to imx_rproc [2] and from a reported regression [3].

[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/
[3] https://lore.kernel.org/lkml/20250404141713.ac2ntcsjsf7epdfa@hiago-nb/

v7:
- Added Peng reviewed-by.
v6:
- https://lore.kernel.org/all/[email protected]/
v5:
- https://lore.kernel.org/all/[email protected]/
v4:
- https://lore.kernel.org/lkml/[email protected]/
v3:
- https://lore.kernel.org/all/[email protected]/
v2:
- https://lore.kernel.org/lkml/[email protected]/
v1:
- https://lore.kernel.org/lkml/[email protected]/

Hiago De Franco (3):
pmdomain: core: introduce dev_pm_genpd_is_on()
remoteproc: imx_rproc: skip clock enable when M-core is managed by the
SCU
remoteproc: imx_rproc: detect and attach to pre-booted remote cores

 drivers/pmdomain/core.c        | 33 +++++++++++++++++++++++++++
 drivers/remoteproc/imx_rproc.c | 41 ++++++++++++++++++++++++++++------
 include/linux/pm_domain.h      |  6 +++++
 3 files changed, 73 insertions(+), 7 deletions(-)
Signature · 1 line
2.39.5