Skip to content

further mt7988 devicetree work

Frank Wunderlich linux-arm-kernel linux-devicetree linux-mediatek linux-pm lkml netdev 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest13 patches 7 repliesIn review 6 of 13 applied
  2. v816 patches 10 repliesApplied
  3. v714 patches 11 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v615 patches0 repliesSuperseded
v513 patches11 repliesSuperseded
v413 patches7 repliesSuperseded
v313 patches23 repliesSuperseded
v214 patches7 repliesApplied
v19 of 14 patches16 repliesSuperseded

Changes in v9 from the cover letter

- dropped patches already applied (cci,gpio-leds,unused pins)
- added patches to add RSS IRQs, IRQ-names and sram-node for mt7986
note: mt7981 does not have a ethernet node yet
- set minItems for Filogic (MT798x) IRQs/Names to 8 needed to update MT7986 binding example because of this
- add sram:false to non-Filogic SoCs

Patches in v9 6 of 13 applied

#Subject and filesSizeRepliesApplied
1/13dt-bindings: net: mediatek,net: update mac subnode pattern for mt7988Documentation/devicetree/bindings/net/mediatek,net.yaml+1 -10 repliesApplied
2/13dt-bindings: net: mediatek,net: allow up to 8 IRQsDocumentation/devicetree/bindings/net/mediatek,net.yaml+9 -51 replyApplied
3/13dt-bindings: net: mediatek,net: allow irq namesDocumentation/devicetree/bindings/net/mediatek,net.yaml+36 -01 replyApplied
4/13dt-bindings: net: mediatek,net: add sram propertyDocumentation/devicetree/bindings/net/mediatek,net.yaml+12 -01 replyApplied
5/13dt-bindings: net: dsa: mediatek,mt7530: add dsa-port definition for mt7988Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml+13 -10 repliesApplied
6/13dt-bindings: net: dsa: mediatek,mt7530: add internal mdio busDocumentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml+10 -00 repliesApplied
7/13arm64: dts: mediatek: mt7986: add sram nodearch/arm64/boot/dts/mediatek/mt7986a.dtsi+11 -10 replies
8/13arm64: dts: mediatek: mt7986: add interrupts for RSS and interrupt namesarch/arm64/boot/dts/mediatek/mt7986a.dtsi+7 -10 replies
9/13arm64: dts: mediatek: mt7988: add basic ethernet-nodesarch/arm64/boot/dts/mediatek/mt7988a.dtsi+134 -30 replies
10/13arm64: dts: mediatek: mt7988: add switch nodearch/arm64/boot/dts/mediatek/mt7988a.dtsi+148 -00 replies
11/13arm64: dts: mediatek: mt7988a-bpi-r4: add aliases for ethernetarch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi+6 -00 replies
12/13arm64: dts: mediatek: mt7988a-bpi-r4: add sfp cages and link to gmacarch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4-2g5.dts arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dts arch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi+49 -00 replies
13/13arm64: dts: mediatek: mt7988a-bpi-r4: configure switch phys and ledsarch/arm64/boot/dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi+61 -00 replies

Reviews trailers per patch

10 of 13 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiAngeloGioacchino Del RegnoRob Herring (Arm)
1/13R-b
2/13R-b
3/13R-b R-b
4/13R-b R-b
5/13R-b R-b
6/13R-b R-b
7/13
8/13
9/13
10/13R-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v9 thread

Cover letter [PATCH v9 00/13] further mt7988 devicetree work

From: Frank Wunderlich <[email protected]>

This series continues mt7988 devicetree work

- Extend cpu frequency scaling with CCI
- GPIO leds
- Basic network-support (ethernet controller + builtin switch + SFP Cages)

depencies (i hope this list is complete and latest patches/series linked):

support interrupt-names is optional again as i re-added the reserved IRQs (they are not unusable as i thought and can allow features in future)
https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/

needs change in mtk ethernet driver for the sram to be read from separate node:
https://patchwork.kernel.org/project/netdevbpf/patch/c2b9242229d06af4e468204bcf42daa1535c3a72.1751461762.git.daniel@makrotopia.org/

for SFP-Function (macs currently disabled):

PCS clearance which is a 1.5 year discussion currently ongoing

Daniel asked netdev for a way 2 go:
https://lore.kernel.org/netdev/[email protected]/

e.g. something like this (one of):
* https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/ (v6)
* https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/ (v4)
* https://patchwork.kernel.org/project/netdevbpf/patch/ba4e359584a6b3bc4b3470822c42186d5b0856f9.1721910728.git.daniel@makrotopia.org/

full usxgmii driver:
https://patchwork.kernel.org/project/netdevbpf/patch/07845ec900ba41ff992875dce12c622277592c32.1702352117.git.daniel@makrotopia.org/

first PCS-discussion is here:
https://patchwork.kernel.org/project/netdevbpf/patch/8aa905080bdb6760875d62cb3b2b41258837f80e.1702352117.git.daniel@makrotopia.org/
some more here:
https://lore.kernel.org/netdev/[email protected]/

and then dts nodes for sgmiisys+usxgmii+2g5 firmware

when above depencies are solved the mac1/2 can be enabled and 2.5G phy/SFP slots will work.

changes:
v9:
- dropped patches already applied (cci,gpio-leds,unused pins)
- added patches to add RSS IRQs, IRQ-names and sram-node for mt7986
note: mt7981 does not have a ethernet node yet
- set minItems for Filogic (MT798x) IRQs/Names to 8 needed to update MT7986 binding example because of this
- add sram:false to non-Filogic SoCs

v8:
- splitted binding into irq-count and irq-names and updated description
- fixed typo in mt7621 section "interrupt-namess"
- splitted binding changes into fixes (mac) and additions (sram)
- dropped change of reg (simple count to description)
- change ethernet register size to 0x40000

v7:
- fixed rebasing error while splitting dt-binding patch

v6:
binding:
- split out the interrupt-names into separate patch
- update irq(name) min count to 4
- move interrupt-names up
- add sram-property
- drop second reg entry and minitems as there is only 1 item left

dts:
- fix whitespace-errors for pdma irqs (spaces vs. tabs)
- move sram from eth reg to own sram node (needs CONFIG_SRAM)

v5:
- add reserved irqs and change names
- update binding for 8 irqs with different names (rx,tx => fe1+fe2, rx-ringX => pdmaX) (dropped Robs RB due to this change again, sorry)

v4:
net-binding:
- allow interrupt names and increase max interrupts to 6 because of RSS/LRO interrupts (dropped Robs RB due to this change)

dts-patches:
- add interrupts for RSS/LRO and interrupt-names for ethernet node
- eth-reg and clock whitespace-fix
- comment for fixed-link on gmac0
- drop phy-mode properties as suggested by andrew
- drop phy-connection-type on 2g5 board
- reorder some properties
- update 2g5 phy node
- unit-name dec instead of hex to match reg property
- move compatible before reg
- drop phy-mode

v3:
- dropped patches already applied (SPI+thermal)
- added soc specific cci compatible (new binding patch + changed dts)
- enable 2g5 phy because driver is now merged
- add patch for cleaning up unnecessary pins
- add patch for gpio-leds
- add patch for adding ethernet aliases

v2:
- change reg to list of items in eth binding
- changed mt7530 binding:
- unevaluatedProperties=false
- mediatek,pio subproperty
- from patternProperty to property
- board specific properties like led function and labels moved to bpi-r4 dtsi

Frank Wunderlich (13):
dt-bindings: net: mediatek,net: update mac subnode pattern for mt7988
dt-bindings: net: mediatek,net: allow up to 8 IRQs
dt-bindings: net: mediatek,net: allow irq names
dt-bindings: net: mediatek,net: add sram property
dt-bindings: net: dsa: mediatek,mt7530: add dsa-port definition for

    mt7988

dt-bindings: net: dsa: mediatek,mt7530: add internal mdio bus
arm64: dts: mediatek: mt7986: add sram node
arm64: dts: mediatek: mt7986: add interrupts for RSS and interrupt
names
arm64: dts: mediatek: mt7988: add basic ethernet-nodes
arm64: dts: mediatek: mt7988: add switch node
arm64: dts: mediatek: mt7988a-bpi-r4: add aliases for ethernet
arm64: dts: mediatek: mt7988a-bpi-r4: add sfp cages and link to gmac
arm64: dts: mediatek: mt7988a-bpi-r4: configure switch phys and leds

 .../bindings/net/dsa/mediatek,mt7530.yaml     |  24 +-
 .../devicetree/bindings/net/mediatek,net.yaml |  64 +++-
 arch/arm64/boot/dts/mediatek/mt7986a.dtsi     |  20 +-
 .../mediatek/mt7988a-bananapi-bpi-r4-2g5.dts  |  11 +
 .../dts/mediatek/mt7988a-bananapi-bpi-r4.dts  |  19 ++
 .../dts/mediatek/mt7988a-bananapi-bpi-r4.dtsi |  86 ++++++
 arch/arm64/boot/dts/mediatek/mt7988a.dtsi     | 285 +++++++++++++++++-
 7 files changed, 497 insertions(+), 12 deletions(-)
Signature · 1 line
2.43.0