Skip to content

ramfb: Add property to control if load the romfile

Shaoqin Huang qemu-arm qemu-devel 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v11 Latest3 patches 2 repliesIn review
  2. v102 patches 0 repliesSuperseded
  3. v92 patches 4 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v72 patches4 repliesSuperseded
v62 patches6 repliesSuperseded
v52 patches0 repliesSuperseded
v42 patches11 repliesSuperseded
v32 patches6 repliesSuperseded
v21 patch9 repliesSuperseded
v11 patch9 repliesSuperseded

Changes in v11 from the cover letter

- Move TYPE* from hw/vfio/pci.h to hw/vfio/types.h

Patches in v11 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ramfb: Add property to control if load the romfilehw/display/ramfb-standalone.c hw/display/ramfb-stubs.c hw/display/ramfb.c +4 more+15 -70 replies
2/3vfio: Move the TYPE_* to hw/vfio/types.hhw/vfio/pci.h hw/vfio/types.h+22 -91 reply
3/3hw/i386: Add the ramfb romfile compatibilityhw/core/machine.c hw/display/ramfb-standalone.c hw/i386/microvm.c +3 more+20 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMichael S. TsirkinZhao LiuEric Auger
1/3R-b R-b
2/3R-b
3/3A-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v11 thread

Cover letter [PATCH v11 0/3] ramfb: Add property to control if load the romfile

Currently the ramfb device loads the vgabios-ramfb.bin unconditionally, but only the x86 need the vgabios-ramfb.bin, this can cause that when use the release package on arm64 it can't find the vgabios-ramfb.bin.

Because only seabios will use the vgabios-ramfb.bin, load the rom logic is x86-specific. For other !x86 platforms, the edk2 ships an EFI driver for ramfb, so they don't need to load the romfile.

So add a new property use-legacy-x86-rom in both ramfb and vfio_pci device, because the vfio display also use the ramfb_setup() to load the vgabios-ramfb.bin file.

After have this property, the machine type can set the compatibility to not load the vgabios-ramfb.bin if the arch doesn't need it.

Then I set the use_legacy_x86_rom property to false by default, and only set it to true on x86 since only x86 will need it.

At the same time, set the "use-legacy-x86-rom" property to true on those historical versioned machine types in order to avoid the memory layout being changed.

Changelog:
---------
v10 -> v11:
- Move TYPE* from hw/vfio/pci.h to hw/vfio/types.h
v9 -> v10:
- Fix the long line.
- Add the reviewed-by and ack.
v8 -> v9:
- Improve the commit message.
v7 -> v8:
- Set the property in microvm machine type.
v6 -> v7:
- Set the property into hw_compat_10_0 instead of hw_compat_9_2.
v5 -> v6:
- Set the property to true on those historical versioned machine types.
v4 -> v5:
- Fix some typo error.
- Set the property in piix machine type.
v3 -> v4:
- Set the new property to false by default, only set it to true on x86.
v2 -> v3:
- Fix the underscore error.
- Add a new patch to set the property in arm compatibility.
v1 -> v2:
- Change the property name.

v9: https://lore.kernel.org/all/[email protected]/
v7: https://lore.kernel.org/all/[email protected]/
v6: https://lore.kernel.org/all/[email protected]/
v5: https://lore.kernel.org/all/[email protected]/
v4: https://lore.kernel.org/all/[email protected]/
v3: https://lore.kernel.org/all/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/
v1: https://lore.kernel.org/all/[email protected]/

Shaoqin Huang (3):
ramfb: Add property to control if load the romfile
vfio: Move the TYPE_* to hw/vfio/types.h hw/i386: Add the ramfb romfile compatibility

 hw/core/machine.c             |  2 ++
 hw/display/ramfb-standalone.c |  5 ++++-
 hw/display/ramfb-stubs.c      |  2 +-
 hw/display/ramfb.c            |  6 ++++--
 hw/i386/microvm.c             |  3 +++
 hw/i386/pc_piix.c             | 10 ++++++++++
 hw/i386/pc_q35.c              |  3 +++
 hw/vfio/display.c             |  4 ++--
 hw/vfio/pci.c                 |  2 ++
 hw/vfio/pci.h                 | 11 ++---------
 hw/vfio/types.h               | 21 +++++++++++++++++++++
 include/hw/display/ramfb.h    |  2 +-
 12 files changed, 55 insertions(+), 16 deletions(-)
 create mode 100644 hw/vfio/types.h
Signature · 1 line
2.40.1