KEYS: trusted_tpm1: HMAC fix and cleanup
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest posting 2/23 patches 4 repliesIn review
- v2 posting 1/22 patches 7 repliesSuperseded
- v12 patches 10 repliesSuperseded
Changes in v2 from the cover letter
- Added the requested note to the commit message of patch 1.
- Added a Reviewed-by tag
Patches in v2 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | KEYS: trusted_tpm1: Compare HMAC values in constant timesecurity/ | +4 | 1 reply | |
| 2/3 | KEYS: trusted_tpm1: Use SHA-1 library instead of crypto_shashsecurity/ security/ | +36 | 1 reply | |
| 3/3 | KEYS: trusted_tpm1: Move private functionality out of public headerinclude/ security/ | +72 | 2 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Jarkko Sakkinen |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/3] KEYS: trusted_tpm1: HMAC fix and cleanup
Patch 1 fixes the HMAC-SHA1 comparison in trusted_tpm1 to be constant-time.
Patch 2 simplifies the SHA-1 and HMAC-SHA1 computation in trusted_tpm1 by using library APIs instead of crypto_shash. Note that this depends on the SHA-1 and HMAC-SHA1 library APIs that were merged for v6.17-rc1.
Patch 3 is a trusted_tpm1 cleanup that moves private functionality out of a public header.
Changed in v2:
- Added the requested note to the commit message of patch 1.
- Added a Reviewed-by tag
Eric Biggers (3):
KEYS: trusted_tpm1: Compare HMAC values in constant time
KEYS: trusted_tpm1: Use SHA-1 library instead of crypto_shash
KEYS: trusted_tpm1: Move private functionality out of public header
include/keys/trusted_tpm.h | 79 ------ security/keys/trusted-keys/Kconfig | 5 +- security/keys/trusted-keys/trusted_tpm1.c | 284 ++++++++-------------- 3 files changed, 100 insertions(+), 268 deletions(-)
base-commit: 561c80369df0733ba0574882a1635287b20f9de2
Signature · 1 line
2.50.1