Skip to content

Fix Several Test Failures

Andrew Hamilton grub-devel 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 1 replyIn review
  2. v63 patches 4 repliesSuperseded
  3. v53 patches 5 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v43 patches2 repliesSuperseded
v33 patches0 repliesSuperseded
v22 of 3 patches2 repliesSuperseded
v13 patches2 repliesSuperseded

Changes in v7 from the cover letter

- Add '-q' option to grep commands to avoid output to stdout.
- Combine multiple piped greps into one in zfs_zstd_test

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tests: Split ZFS ZSTD Test Into New File.gitignore Makefile.util.def tests/zfs_test.in +1 more+37 -10 replies
2/3tests: Avoid Test Failure in erofs for label lengthtests/util/grub-fs-tester.in+5 -20 replies
3/3tests: Support Changed mkfs.ext2 Behavior for -r Flagtests/util/grub-fs-tester.in+5 -10 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDaniel KiperGlenn Washburn
SeriesR-b
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/3] Fix Several Test Failures

Correct several test failures observed while running GRUB 'make check' on Debian 13. The test failures fixed here are:

1. ZFS ZSTD - Test was failing zfs_test due to lack of support in zfs-fuse for zstd compression. This specific test case was split into a new test file allowing failing early if zstd is
not supported to avoid masking other possible (future) zfs test failures.
2. Correct test failure in erofs_test in newer Linux distros caused by a change in mkfs.erofs to limit the maximum file system label length to 15 characters. Reduce the label used for testing to work within this limit.
3. Correct test failure in ext234_test in newer Linux distros caused by a change in e2fsprogs that removed the ability to set "version 0" ext2 file systems using the "-r" flag. Instead a new flag is added to support this. Update the test to support the old method in older distros and the new method in newer distros.

Changes since v6:
- Add '-q' option to grep commands to avoid output to stdout.
- Combine multiple piped greps into one in zfs_zstd_test

Changes since v5:
- Change return code from 77 to 99 in zstd test

Changes since v4:
- Change return code from 99 to 77 in zstd test

Changes since v3:
- Rebase changes against current master branch.

Changes since v2:
- Change return code from 77 to 99 in zstd test

Changes since v1:
- Remove unrelated changes to .gitignore

Andrew Hamilton (3):
tests: Split ZFS ZSTD Test Into New File
tests: Avoid Test Failure in erofs for label length
tests: Support Changed mkfs.ext2 Behavior for -r Flag

 .gitignore                   |  1 +
 Makefile.util.def            |  6 ++++++
 tests/util/grub-fs-tester.in | 13 ++++++++++---
 tests/zfs_test.in            |  1 -
 tests/zfs_zstd_test.in       | 30 ++++++++++++++++++++++++++++++
 5 files changed, 47 insertions(+), 4 deletions(-)
 create mode 100644 tests/zfs_zstd_test.in
Signature · 7 lines
2.43.0


_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel