Skip to content

arm64: allwinner: a523: Enable MCU PRCM and NPU

Chen-Yu Tsai linux-arm-kernel linux-clk linux-devicetree linux-sunxi lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 9 repliesIn review
  2. v18 patches 15 repliesSuperseded

Changes in v2 from the cover letter · 18 lines

- Dropped dual divider clock rate read-back fix that is already merged
- DT binding
- Moved "r-ahb" clock to the end of the list and added "r-apb0" clock
- Add NPU clk
- Move .num to after list of clks
- MCU CCU clk driver
- Added comment for "fixed" dividers in audio PLL clock
- Corrected variable names for audio PLL divider clocks
- Added comment for the reversed order of some of the DSP clock's parents when compared to the manual
- Added comments for clocks and resets only found in the BSP driver
- Corrected register offset for i2s3-asrc and bus-mcu-pwm0 clocks
- Made "r-ahb" and new "r-apb0" external bus clocks the parents of the bus gate clocks, with comments if guessed which one applies
- Moved .num_clks to after the list of clocks, making it obvious that the value needs to be added if more clocks are added to the list
- MCU CCU DT node
- Enlarged MCU PRCM register range to 0x200
- Moved "r-ahb" clock to the end of the list and added "r-apb0" clock
- Link to v1
https://lore.kernel.org/all/[email protected]/

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7dt-bindings: clock: sun55i-a523-ccu: Add missing NPU module clockinclude/dt-bindings/clock/sun55i-a523-ccu.h+1 -00 replies
2/7dt-bindings: clock: sun55i-a523-ccu: Add A523 MCU CCU clock controllerDocumentation/devicetree/bindings/clock/allwinner,sun55i-a523-ccu.yaml include/dt-bindings/clock/sun55i-a523-mcu-ccu.h include/dt-bindings/reset/sun55i-a523-mcu-ccu.h+119 -20 replies
3/7clk: sunxi-ng: sun55i-a523-ccu: Add missing NPU module clockdrivers/clk/sunxi-ng/ccu-sun55i-a523.c drivers/clk/sunxi-ng/ccu-sun55i-a523.h+18 -172 replies
4/7clk: sunxi-ng: div: support power-of-two dividersdrivers/clk/sunxi-ng/ccu_div.h+18 -01 reply
5/7clk: sunxi-ng: add support for the A523/T527 MCU CCUdrivers/clk/sunxi-ng/Kconfig drivers/clk/sunxi-ng/Makefile drivers/clk/sunxi-ng/ccu-sun55i-a523-mcu.c+476 -01 reply
6/7arm64: dts: allwinner: a523: Add MCU PRCM CCU nodearch/arm64/boot/dts/allwinner/sun55i-a523.dtsi+27 -01 reply
7/7arm64: dts: allwinner: a523: Add NPU device nodearch/arm64/boot/dts/allwinner/sun55i-a523.dtsi+12 -01 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchAndre PrzywaraRob Herring (Arm)Jernej Skrabec
1/7R-b A-b
2/7R-b
3/7R-b R-b
4/7R-b
5/7R-b
6/7R-b R-b
7/7R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/7] arm64: allwinner: a523: Enable MCU PRCM and NPU

From: Chen-Yu Tsai <[email protected]>

Hi folks,

This is v2 of my A523 MCU PRCM and NPU support series.

Changes since v1:
- Dropped dual divider clock rate read-back fix that is already merged
- DT binding
- Moved "r-ahb" clock to the end of the list and added "r-apb0" clock
- Add NPU clk
- Move .num to after list of clks
- MCU CCU clk driver
- Added comment for "fixed" dividers in audio PLL clock
- Corrected variable names for audio PLL divider clocks
- Added comment for the reversed order of some of the DSP clock's parents when compared to the manual
- Added comments for clocks and resets only found in the BSP driver
- Corrected register offset for i2s3-asrc and bus-mcu-pwm0 clocks
- Made "r-ahb" and new "r-apb0" external bus clocks the parents of the bus gate clocks, with comments if guessed which one applies
- Moved .num_clks to after the list of clocks, making it obvious that the value needs to be added if more clocks are added to the list
- MCU CCU DT node
- Enlarged MCU PRCM register range to 0x200
- Moved "r-ahb" clock to the end of the list and added "r-apb0" clock
- Link to v1
https://lore.kernel.org/all/[email protected]/

The MCU PRCM is a Power, Reset & Clock Management block that has some clock and reset controls for the MCU, DSP and some peripherals that the MCU could use.

The NPU is a Vivante IP block. It is clocked from the NPU PLL from the main clock unit, but the bus clock and reset controls lie in the MCU PRCM.

Patch 1 adds the missing NPU module clock to the main clock control unit's binding.

Patch 2 adds the binding for the MCU PRCM clock control unit

Patch 3 adds the missing NPU module clock.

Patch 4 adds support for power-of-two dividers to the sunxi-ng clk library.

Patch 5 adds a new driver for the A523 MCU PRCM CCU.

Patch 6 adds a device node for the MCU PRCM CCU.

Patch 7 adds a device node for the NPU.

The NPU was only lightly tested: the driver correctly probes and detects a model GC9000, revision 9003.

Please have a look. All patches will be merged through the sunxi tree.

Thanks
ChenYu

Chen-Yu Tsai (7):
dt-bindings: clock: sun55i-a523-ccu: Add missing NPU module clock
dt-bindings: clock: sun55i-a523-ccu: Add A523 MCU CCU clock controller
clk: sunxi-ng: sun55i-a523-ccu: Add missing NPU module clock
clk: sunxi-ng: div: support power-of-two dividers
clk: sunxi-ng: add support for the A523/T527 MCU CCU
arm64: dts: allwinner: a523: Add MCU PRCM CCU node
arm64: dts: allwinner: a523: Add NPU device node

 .../clock/allwinner,sun55i-a523-ccu.yaml      |  37 +-
 .../arm64/boot/dts/allwinner/sun55i-a523.dtsi |  39 ++
 drivers/clk/sunxi-ng/Kconfig                  |   5 +
 drivers/clk/sunxi-ng/Makefile                 |   2 +
 drivers/clk/sunxi-ng/ccu-sun55i-a523-mcu.c    | 469 ++++++++++++++++++
 drivers/clk/sunxi-ng/ccu-sun55i-a523.c        |  21 +-
 drivers/clk/sunxi-ng/ccu-sun55i-a523.h        |  14 -
 drivers/clk/sunxi-ng/ccu_div.h                |  18 +
 include/dt-bindings/clock/sun55i-a523-ccu.h   |   1 +
 .../dt-bindings/clock/sun55i-a523-mcu-ccu.h   |  54 ++
 .../dt-bindings/reset/sun55i-a523-mcu-ccu.h   |  30 ++
 11 files changed, 671 insertions(+), 19 deletions(-)
 create mode 100644 drivers/clk/sunxi-ng/ccu-sun55i-a523-mcu.c
 delete mode 100644 drivers/clk/sunxi-ng/ccu-sun55i-a523.h
 create mode 100644 include/dt-bindings/clock/sun55i-a523-mcu-ccu.h
 create mode 100644 include/dt-bindings/reset/sun55i-a523-mcu-ccu.h
Signature · 1 line
2.39.5