Skip to content

drm/panthor: initial mt8196 support

Chia-I Wu dri-devel linux-arm-kernel linux-devicetree linux-mediatek lkml 2 versions – Applied

Status from this message: Applied to drm-misc-next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 8 repliesApplied
  2. v1 RFC2 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- drop RFC as this series works with the downstream GPUEB driver, and should work with Nicolas's GPUEB driver posted to
https://lore.kernel.org/lkml/[email protected]/
with no change.
- remove CONFIG_DRM_PANTHOR_SOC_MT8196 and panthor_soc*.[ch], as this initial support is just about ASN hash.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2dt-bindings: gpu: mali-valhall-csf: add MediaTek MT8196 compatibleDocumentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml+1 -05 replies
2/2drm/panthor: add custom ASN_HASH support for mt8196drivers/gpu/drm/panthor/panthor_device.c drivers/gpu/drm/panthor/panthor_device.h drivers/gpu/drm/panthor/panthor_drv.c +2 more+50 -12 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBoris BrezillonConor DooleySteven Price
1/2A-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/2] drm/panthor: initial mt8196 support

MediaTek MT8196 has Mali-G925-Immortalis, for which panthor gained support recently. But the soc also requires custom ASN hash to be enabled. This series introduces panthor_soc_data for per-soc data and uses it to enable custom ASN hash on MT8196.

The clk/regulator provider on MT8196 is GPUEB, whose driver[1] needs to be cleaned up and upstreamed separately.

This initial support also lacks support for some hw configs. On some configs, panthor is expected to query a mask from efuse to mask out unavailable shader cores from ptdev->gpu_info.shader_present. This requires extending panthor_soc_data with a callback to read the mask.

This is an RFC because the dependent drivers are not ready yet. But I would like to gather opinions on having panthor_soc_data for soc-specific data and having CONFIG_DRM_PANTHOR_SOC_MT8196 for soc-specific code.

[1] https://gitlab.freedesktop.org/olv/kernel/-/commit/170d5fc90f817dc90bde54b32872c59cf5c77779

---
v2:

- drop RFC as this series works with the downstream GPUEB driver, and should work with Nicolas's GPUEB driver posted to
https://lore.kernel.org/lkml/[email protected]/
with no change.
- remove CONFIG_DRM_PANTHOR_SOC_MT8196 and panthor_soc*.[ch], as this initial support is just about ASN hash.

Chia-I Wu (2):
dt-bindings: gpu: mali-valhall-csf: add MediaTek MT8196 compatible drm/panthor: add custom ASN_HASH support for mt8196

 .../bindings/gpu/arm,mali-valhall-csf.yaml    |  1 +
 drivers/gpu/drm/panthor/panthor_device.c      |  2 ++
 drivers/gpu/drm/panthor/panthor_device.h      | 14 +++++++++++
 drivers/gpu/drm/panthor/panthor_drv.c         |  6 +++++
 drivers/gpu/drm/panthor/panthor_gpu.c         | 25 ++++++++++++++++++-
 drivers/gpu/drm/panthor/panthor_regs.h        |  4 +++
 6 files changed, 51 insertions(+), 1 deletion(-)
Signature · 1 line
2.51.0.384.g4c02a37b29-goog