Add SDCA class driver
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest13 patches 2 repliesIn review
- v313 patches 5 repliesSuperseded
- v213 patches 1 replySuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 16 replies | Superseded |
Changes in v4 from the cover letter
- Switch back to scoped_guard in sdca_fdl_process
- Change select to depends to avoid some issues around being able to select non-building configs
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | ASoC: SDCA: Remove duplicated module macrossound/ sound/ | +0 | 0 replies | |
| 2/13 | ASoC: SDCA: Fix missing dash in HIDE DisCo propertysound/ | +1 | 0 replies | |
| 3/13 | ASoC: SDCA: Add missing forward declaration in headerinclude/ | +1 | 0 replies | |
| 4/13 | ASoC: SDCA: Correct FDL locking in sdca_fdl_process()sound/ | +45 | 0 replies | |
| 5/13 | ASoC: SDCA: Add comment for function reset pollingsound/ | +4 | 0 replies | |
| 6/13 | ASoC: SDCA: Move most of the messages from info to debugsound/ | +24 | 0 replies | |
| 7/13 | ASoC: SDCA: Use helper macros for control identificationsound/ | +14 | 0 replies | |
| 8/13 | ASoC: SDCA: Factor out helper to process Control defaultssound/ | +39 | 0 replies | |
| 9/13 | ASoC: SDCA: Populate regmap cache for readable Controlssound/ | +22 | 0 replies | |
| 10/13 | ASoC: SDCA: Add helper to write initialization writesinclude/ sound/ | +18 | 0 replies | |
| 11/13 | ASoC: SDCA: add function devicesinclude/ sound/ sound/ +2 more | +148 | 0 replies | |
| 12/13 | ASoC: SDCA: Add basic SDCA class driverinclude/ sound/ sound/ +2 more | +357 | 0 replies | |
| 13/13 | ASoC: SDCA: Add basic SDCA function driversound/ sound/ sound/ | +469 | 0 replies |
Reviews trailers per patch
All 13 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Bard Liao | Maciej Strozek | Peter Ujfalusi | Richard Fitzgerald | Vinod Koul |
|---|---|---|---|---|---|
| Series | R-b | ||||
| 1/13 | T-b | R-b | R-b | T-b | |
| 2/13 | T-b | R-b | R-b | T-b | |
| 3/13 | T-b | R-b | R-b | T-b | |
| 4/13 | T-b | R-b | R-b | T-b | |
| 5/13 | T-b | R-b | R-b | T-b | |
| 6/13 | T-b | R-b | R-b | T-b | |
| 7/13 | T-b | R-b | R-b | T-b | |
| 8/13 | T-b | R-b | R-b | T-b | |
| 9/13 | T-b | R-b | R-b | T-b | |
| 10/13 | T-b | R-b | R-b | T-b | A-b |
| 11/13 | T-b | R-b | R-b | T-b | |
| 12/13 | T-b | R-b | R-b | T-b | |
| 13/13 | T-b | R-b | R-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v4 00/13] Add SDCA class driver
This series adds an initial SDCA class driver, this consists of a primary driver attached to the SoundWire device, and auxiliary drivers representing each of the functions of the SDCA device. These drivers all use the APIs added over the past series's to provide the class functionality, as such these final drivers themselves are quite thin.
Also a few fix ups at the start of the series that have gathered up whilst the last SDCA series was in review.
Thanks,
Charles
Changes since v3:
- Switch back to scoped_guard in sdca_fdl_process
- Change select to depends to avoid some issues around being able to select non-building configs
Changes since v2:
- Updated the locking in sdca_fdl_process
- Correct some spelling in comments
- Renamed suspend/resume functions to be a little short
Changes since v1:
- Add a bunch of bug fix patches
- Change some prints to dbgs
- Add some additional comments
- Flip order on regcache operations in resume
Charles Keepax (12):
ASoC: SDCA: Remove duplicated module macros
ASoC: SDCA: Fix missing dash in HIDE DisCo property
ASoC: SDCA: Add missing forward declaration in header
ASoC: SDCA: Correct FDL locking in sdca_fdl_process()
ASoC: SDCA: Add comment for function reset polling
ASoC: SDCA: Move most of the messages from info to debug
ASoC: SDCA: Use helper macros for control identification
ASoC: SDCA: Factor out helper to process Control defaults
ASoC: SDCA: Populate regmap cache for readable Controls
ASoC: SDCA: Add helper to write initialization writes
ASoC: SDCA: Add basic SDCA class driver
ASoC: SDCA: Add basic SDCA function driver
Pierre-Louis Bossart (1):
ASoC: SDCA: add function devices
include/linux/soundwire/sdw_registers.h | 2 + include/sound/sdca.h | 14 + include/sound/sdca_regmap.h | 2 + sound/soc/sdca/Kconfig | 18 + sound/soc/sdca/Makefile | 10 +- sound/soc/sdca/sdca_class.c | 304 ++++++++++++++++ sound/soc/sdca/sdca_class.h | 37 ++ sound/soc/sdca/sdca_class_function.c | 460 ++++++++++++++++++++++++ sound/soc/sdca/sdca_fdl.c | 93 ++--- sound/soc/sdca/sdca_function_device.c | 117 ++++++ sound/soc/sdca/sdca_function_device.h | 15 + sound/soc/sdca/sdca_functions.c | 52 ++- sound/soc/sdca/sdca_hid.c | 3 - sound/soc/sdca/sdca_interrupts.c | 39 +- sound/soc/sdca/sdca_regmap.c | 89 +++-- 15 files changed, 1132 insertions(+), 123 deletions(-) create mode 100644 sound/soc/sdca/sdca_class.c create mode 100644 sound/soc/sdca/sdca_class.h create mode 100644 sound/soc/sdca/sdca_class_function.c create mode 100644 sound/soc/sdca/sdca_function_device.c create mode 100644 sound/soc/sdca/sdca_function_device.h
Signature · 1 line
2.47.3