Skip to content

Add SDCA class driver

Charles Keepax linux-sound 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest13 patches 2 repliesIn review
  2. v313 patches 5 repliesSuperseded
  3. v213 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches16 repliesSuperseded

Changes in v4 from the cover letter

- Switch back to scoped_guard in sdca_fdl_process
- Change select to depends to avoid some issues around being able to select non-building configs

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13ASoC: SDCA: Remove duplicated module macrossound/soc/sdca/sdca_hid.c sound/soc/sdca/sdca_interrupts.c+0 -60 replies
2/13ASoC: SDCA: Fix missing dash in HIDE DisCo propertysound/soc/sdca/sdca_functions.c+1 -10 replies
3/13ASoC: SDCA: Add missing forward declaration in headerinclude/sound/sdca.h+1 -00 replies
4/13ASoC: SDCA: Correct FDL locking in sdca_fdl_process()sound/soc/sdca/sdca_fdl.c+45 -440 replies
5/13ASoC: SDCA: Add comment for function reset pollingsound/soc/sdca/sdca_fdl.c+4 -00 replies
6/13ASoC: SDCA: Move most of the messages from info to debugsound/soc/sdca/sdca_functions.c+24 -260 replies
7/13ASoC: SDCA: Use helper macros for control identificationsound/soc/sdca/sdca_interrupts.c+14 -220 replies
8/13ASoC: SDCA: Factor out helper to process Control defaultssound/soc/sdca/sdca_regmap.c+39 -220 replies
9/13ASoC: SDCA: Populate regmap cache for readable Controlssound/soc/sdca/sdca_regmap.c+22 -100 replies
10/13ASoC: SDCA: Add helper to write initialization writesinclude/sound/sdca_regmap.h sound/soc/sdca/sdca_regmap.c+18 -00 replies
11/13ASoC: SDCA: add function devicesinclude/sound/sdca.h sound/soc/sdca/Kconfig sound/soc/sdca/Makefile +2 more+148 -20 replies
12/13ASoC: SDCA: Add basic SDCA class driverinclude/linux/soundwire/sdw_registers.h sound/soc/sdca/Kconfig sound/soc/sdca/Makefile +2 more+357 -00 replies
13/13ASoC: SDCA: Add basic SDCA function driversound/soc/sdca/Kconfig sound/soc/sdca/Makefile sound/soc/sdca/sdca_class_function.c+469 -00 replies

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBard LiaoMaciej StrozekPeter UjfalusiRichard FitzgeraldVinod Koul
SeriesR-b
1/13T-b R-b R-b T-b
2/13T-b R-b R-b T-b
3/13T-b R-b R-b T-b
4/13T-b R-b R-b T-b
5/13T-b R-b R-b T-b
6/13T-b R-b R-b T-b
7/13T-b R-b R-b T-b
8/13T-b R-b R-b T-b
9/13T-b R-b R-b T-b
10/13T-b R-b R-b T-b A-b
11/13T-b R-b R-b T-b
12/13T-b R-b R-b T-b
13/13T-b R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/13] Add SDCA class driver

This series adds an initial SDCA class driver, this consists of a primary driver attached to the SoundWire device, and auxiliary drivers representing each of the functions of the SDCA device. These drivers all use the APIs added over the past series's to provide the class functionality, as such these final drivers themselves are quite thin.

Also a few fix ups at the start of the series that have gathered up whilst the last SDCA series was in review.

Thanks,
Charles

Changes since v3:
- Switch back to scoped_guard in sdca_fdl_process
- Change select to depends to avoid some issues around being able to select non-building configs

Changes since v2:
- Updated the locking in sdca_fdl_process
- Correct some spelling in comments
- Renamed suspend/resume functions to be a little short

Changes since v1:
- Add a bunch of bug fix patches
- Change some prints to dbgs
- Add some additional comments
- Flip order on regcache operations in resume

Charles Keepax (12):
ASoC: SDCA: Remove duplicated module macros
ASoC: SDCA: Fix missing dash in HIDE DisCo property
ASoC: SDCA: Add missing forward declaration in header
ASoC: SDCA: Correct FDL locking in sdca_fdl_process()
ASoC: SDCA: Add comment for function reset polling
ASoC: SDCA: Move most of the messages from info to debug
ASoC: SDCA: Use helper macros for control identification
ASoC: SDCA: Factor out helper to process Control defaults
ASoC: SDCA: Populate regmap cache for readable Controls
ASoC: SDCA: Add helper to write initialization writes
ASoC: SDCA: Add basic SDCA class driver
ASoC: SDCA: Add basic SDCA function driver

Pierre-Louis Bossart (1):
ASoC: SDCA: add function devices

 include/linux/soundwire/sdw_registers.h |   2 +
 include/sound/sdca.h                    |  14 +
 include/sound/sdca_regmap.h             |   2 +
 sound/soc/sdca/Kconfig                  |  18 +
 sound/soc/sdca/Makefile                 |  10 +-
 sound/soc/sdca/sdca_class.c             | 304 ++++++++++++++++
 sound/soc/sdca/sdca_class.h             |  37 ++
 sound/soc/sdca/sdca_class_function.c    | 460 ++++++++++++++++++++++++
 sound/soc/sdca/sdca_fdl.c               |  93 ++---
 sound/soc/sdca/sdca_function_device.c   | 117 ++++++
 sound/soc/sdca/sdca_function_device.h   |  15 +
 sound/soc/sdca/sdca_functions.c         |  52 ++-
 sound/soc/sdca/sdca_hid.c               |   3 -
 sound/soc/sdca/sdca_interrupts.c        |  39 +-
 sound/soc/sdca/sdca_regmap.c            |  89 +++--
 15 files changed, 1132 insertions(+), 123 deletions(-)
 create mode 100644 sound/soc/sdca/sdca_class.c
 create mode 100644 sound/soc/sdca/sdca_class.h
 create mode 100644 sound/soc/sdca/sdca_class_function.c
 create mode 100644 sound/soc/sdca/sdca_function_device.c
 create mode 100644 sound/soc/sdca/sdca_function_device.h
Signature · 1 line
2.47.3