Skip to content

Improve usage of 'ret' variable and make pcf_doAdress() void

Cezar Chiru linux-i2c lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2i2c: pcf8584: Move 'ret' variable inside for loop, goto out if ret < 0.drivers/i2c/algos/i2c-algo-pcf.c+8 -40 replies
2/2i2c: pcf8584: Make pcf_doAddress() function voiddrivers/i2c/algos/i2c-algo-pcf.c+2 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/2] Improve usage of 'ret' variable and make pcf_doAdress() void

Hello maintainers,

This patch series is a response to Change Requests made by Andi Shyti on [PATCH v7 0/3] i2c: pcf8584: Fix errors and warnings reported by checkpatch and more specific on PATCH: i2c: pcf8584: Move 'ret' variable inside for loop, break if ret < 0.
Also a comment from Andy Shevchenko about using goto instead of break since the goto was used in other error path branches so it makes sense to be consistent.

Patches are dependent on each other that's why the need for a new patch series.

Change Requests:
-remove initialization of 'ret' variable inside for loop of pcf_xfer() as it is not needed
-change pcf_doAddress() function type from int to void as it always returns 0.

Testing:
*built kernel and modules with I2C_ALGOPCF=m and my 2 patches applied on top of 6.18.0-rc1.
*installed kernel and external modules generated by build on my laptop *rebooted and loaded i2c-algo-pcf.ko without i2c_debug parameter. *when loading the .ko with i2c_debug parameter an error is seen in dmesg and this is expected as the parameter was removed.
*No success message related to i2c_algo_pcf was seen in dmesg but also no failures.
*Module loading and unloading successful.
*No PCF8584 Hardware was available

Cezar Chiru (2):
i2c: pcf8584: Move 'ret' variable inside for loop, goto out if ret <

    0.

i2c: pcf8584: Make pcf_doAddress() function void

 drivers/i2c/algos/i2c-algo-pcf.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

--
2.43.0