Skip to content

clk: spacemit: Fix module build for spacemit common ccu driver

Inochi Amaoto linux-clk linux-riscv lkml spacemit 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 2 repliesApplied
  2. v31 patch 1 replySuperseded
  3. v11 patch 5 repliesSuperseded

Changes in v4 from the cover letter

1. patch 1: change Makefile to trigger module build actually
2. patch 2: new patch for remove internal Kconfig entry

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/2clk: spacemit: Respect Kconfig setting when building modulesdrivers/clk/spacemit/Makefile drivers/clk/spacemit/ccu-k1.c drivers/clk/spacemit/ccu_common.c +3 more+25 -20 replies
2/2clk: spacemit: Hide common clock driver from user controllerdrivers/clk/spacemit/Kconfig+6 -80 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchYixun Lan
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] clk: spacemit: Fix module build for spacemit common ccu driver

Currently, the SPACEMIT_CCU entry is only a switch for enabling entry SPACEMIT_K1_CCU. It does not guide the build for common clock codes even if it is a tristate entry. This makes this entry useless.

Change the Makefile to add a separate build for common clock logic, so the SPACEMIT_CCU entry takes effect, also add necessary MODULE_LICENSE()/MODULE_DESCRIPTION()/EXPORT_SYMBOL() for the module build.

This patch mostly fix the build problem, and it should serve as a basic for the incoming K3 clock driver. See link.

Change from v3:
1. patch 1: change Makefile to trigger module build actually
2. patch 2: new patch for remove internal Kconfig entry

Change from v2:
1. change namespace name to CLK_SPACEMIT

Change from v1:
1. Use EXPORT_SYMBOL_NS_GPL to export clock ops

Inochi Amaoto (2):
clk: spacemit: Respect Kconfig setting when building modules
clk: spacemit: Hide common clock driver from user controller

 drivers/clk/spacemit/Kconfig      | 14 ++++++--------
 drivers/clk/spacemit/Makefile     |  9 +++++++--
 drivers/clk/spacemit/ccu-k1.c     |  1 +
 drivers/clk/spacemit/ccu_common.c |  6 ++++++
 drivers/clk/spacemit/ccu_ddn.c    |  1 +
 drivers/clk/spacemit/ccu_mix.c    |  9 +++++++++
 drivers/clk/spacemit/ccu_pll.c    |  1 +
 7 files changed, 31 insertions(+), 10 deletions(-)
 create mode 100644 drivers/clk/spacemit/ccu_common.c

--
2.52.0