clk: spacemit: Fix module build for spacemit common ccu driver
Subsystems (3)
PATCH v3 1/1 clk: spacemit: Fix module build for spacemit common ccu driver
For build spacemit common clock driver as a module, the build process require MODULE_LICENSE()/MODULE_DESCRIPTION() globally and EXPORT_SYMBOL() for every exposed symbol. Otherwise, the build will fail.
Add these missing hints, so the driver can be built as a module.
--- drivers/clk/spacemit/ccu-k1.c | 1 + drivers/clk/spacemit/ccu_ddn.c | 1 + drivers/clk/spacemit/ccu_mix.c | 9 +++++++++ drivers/clk/spacemit/ccu_pll.c | 5 +++++ 4 files changed, 16 insertions(+)
drivers/clk/spacemit/ccu-k1.c +1 -0
@@ -1204,6 +1204,7 @@ static struct platform_driver k1_ccu_driver = { };module_platform_driver (k1_ccu_driver); +MODULE_IMPORT_NS ("CLK_SPACEMIT" );MODULE_DESCRIPTION ("SpacemiT K1 CCU driver" );MODULE_AUTHOR ("Haylen Chu <[email protected]>" );MODULE_LICENSE ("GPL" );
drivers/clk/spacemit/ccu_ddn.c +1 -0
@@ -84,3 +84,4 @@ const struct clk_ops spacemit_ccu_ddn_ops = { .determine_rate = ccu_ddn_determine_rate, .set_rate = ccu_ddn_set_rate, }; +EXPORT_SYMBOL_NS_GPL (spacemit_ccu_ddn_ops,"CLK_SPACEMIT" );
drivers/clk/spacemit/ccu_mix.c +9 -0
@@ -198,24 +198,28 @@ const struct clk_ops spacemit_ccu_gate_ops = { .enable = ccu_gate_enable, .is_enabled = ccu_gate_is_enabled, }; +EXPORT_SYMBOL_NS_GPL (spacemit_ccu_gate_ops,"CLK_SPACEMIT" );const struct clk_ops spacemit_ccu_factor_ops = { .determine_rate = ccu_factor_determine_rate, .recalc_rate = ccu_factor_recalc_rate, .set_rate = ccu_factor_set_rate, }; +EXPORT_SYMBOL_NS_GPL (spacemit_ccu_factor_ops,"CLK_SPACEMIT" );const struct clk_ops spacemit_ccu_mux_ops = { .determine_rate = ccu_mix_determine_rate, .get_parent = ccu_mux_get_parent, .set_parent = ccu_mux_set_parent, }; +EXPORT_SYMBOL_NS_GPL (spacemit_ccu_mux_ops,"CLK_SPACEMIT" );const struct clk_ops spacemit_ccu_div_ops = { .determine_rate = ccu_mix_determine_rate, .recalc_rate = ccu_div_recalc_rate, .set_rate = ccu_mix_set_rate, }; +EXPORT_SYMBOL_NS_GPL (spacemit_ccu_div_ops,"CLK_SPACEMIT" );const struct clk_ops spacemit_ccu_factor_gate_ops = { .disable = ccu_gate_disable,
@@ -226,6 +230,7 @@ const struct clk_ops spacemit_ccu_factor_gate_ops = { .recalc_rate = ccu_factor_recalc_rate, .set_rate = ccu_factor_set_rate, }; +EXPORT_SYMBOL_NS_GPL (spacemit_ccu_factor_gate_ops,"CLK_SPACEMIT" );const struct clk_ops spacemit_ccu_mux_gate_ops = { .disable = ccu_gate_disable,
@@ -236,6 +241,7 @@ const struct clk_ops spacemit_ccu_mux_gate_ops = { .get_parent = ccu_mux_get_parent, .set_parent = ccu_mux_set_parent, }; +EXPORT_SYMBOL_NS_GPL (spacemit_ccu_mux_gate_ops,"CLK_SPACEMIT" );const struct clk_ops spacemit_ccu_div_gate_ops = { .disable = ccu_gate_disable,
@@ -246,6 +252,7 @@ const struct clk_ops spacemit_ccu_div_gate_ops = { .recalc_rate = ccu_div_recalc_rate, .set_rate = ccu_mix_set_rate, }; +EXPORT_SYMBOL_NS_GPL (spacemit_ccu_div_gate_ops,"CLK_SPACEMIT" );const struct clk_ops spacemit_ccu_mux_div_gate_ops = { .disable = ccu_gate_disable,
@@ -259,6 +266,7 @@ const struct clk_ops spacemit_ccu_mux_div_gate_ops = { .recalc_rate = ccu_div_recalc_rate, .set_rate = ccu_mix_set_rate, }; +EXPORT_SYMBOL_NS_GPL (spacemit_ccu_mux_div_gate_ops,"CLK_SPACEMIT" );const struct clk_ops spacemit_ccu_mux_div_ops = { .get_parent = ccu_mux_get_parent,
@@ -268,3 +276,4 @@ const struct clk_ops spacemit_ccu_mux_div_ops = { .recalc_rate = ccu_div_recalc_rate, .set_rate = ccu_mix_set_rate, }; +EXPORT_SYMBOL_NS_GPL (spacemit_ccu_mux_div_ops,"CLK_SPACEMIT" );
drivers/clk/spacemit/ccu_pll.c +5 -0
@@ -7,6 +7,7 @@#include <linux/clk-provider.h> #include <linux/math.h> #include <linux/regmap.h> +#include <linux/module.h> #include "ccu_common.h" #include "ccu_pll.h"
@@ -157,3 +158,7 @@ const struct clk_ops spacemit_ccu_pll_ops = { .determine_rate = ccu_pll_determine_rate, .is_enabled = ccu_pll_is_enabled, }; +EXPORT_SYMBOL_NS_GPL (spacemit_ccu_pll_ops,"CLK_SPACEMIT" ); + +MODULE_DESCRIPTION ("SpacemiT CCU common clock driver" ); +MODULE_LICENSE ("GPL" );
Signature · 1 line
2.52.0
Hi Inochi,
Quoted 7 lines · Inochi Amaoto
For build spacemit common clock driver as a module, the build process require MODULE_LICENSE()/MODULE_DESCRIPTION() globally and
EXPORT_SYMBOL()for every exposed symbol. Otherwise, the build will fail.Add these missing hints, so the driver can be built as a module.
Quoted 9 lines
Fixes 1b72c59db0ad ("clk: spacemit: Add clock support for SpacemiT K1 SoC")Signed-off-by Inochi Amaoto <[email protected]>--- drivers/clk/spacemit/ccu-k1.c | 1 + drivers/clk/spacemit/ccu_ddn.c | 1 + drivers/clk/spacemit/ccu_mix.c | 9 +++++++++ drivers/clk/spacemit/ccu_pll.c | 5 +++++ 4 files changed, 16 insertions(+)
[snip]..
Quoted 18 lines
drivers/clk/spacemit/ccu_pll.c +3
-0@@ -7,6 +7,7 @@#include <linux/clk-provider.h> #include <linux/math.h> #include <linux/regmap.h> +#include <linux/module.h> #include "ccu_common.h" #include "ccu_pll.h" @@ -157,3 +158,7 @@ const struct clk_ops spacemit_ccu_pll_ops = { .determine_rate = ccu_pll_determine_rate, .is_enabled = ccu_pll_is_enabled, }; +EXPORT_SYMBOL_NS_GPL (spacemit_ccu_pll_ops,"CLK_SPACEMIT" ); +
..
drivers/clk/spacemit/ccu_pll.c const struct clk_ops spacemit_ccu_pll_ops = { · line 164
Quoted 2 lines
drivers/clk/spacemit/ccu_pll.c +2
-0+MODULE_DESCRIPTION ("SpacemiT CCU common clock driver" ); +MODULE_LICENSE ("GPL" );
can you creat a separate file ccu_commom.c, and put above change there?
the reason I request this is that I'm trying to refactor the driver and will extract common code into file ccu_common.c, with this coming change, it's more proper to do this adjustment, which will avoid future code movement, refer the link [1] of the review of K3 clock for why I'm requesting this
to Stephen, if you have no objection, I'd hope this patch can be taken via v6.19-rc2-fixes, and then I will do other follow-up clock patches on top of it, I can send a PR for this fix..
if with above change, please add my R-b
Signature · 1 line
Yixun Lan (dlan)