RFC target/riscv/debug: Sdtrig fixes and TT Ascalon support
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest25 patches 24 repliesIn review
Patches in v1 No applies recorded yet
Reviews trailers per patch
17 of 25 patches have a Reviewed-by or Acked-by.
| Patch | Daniel Henrique Barboza | Chao Liu |
|---|---|---|
| 1/25 | R-b | R-b |
| 2/25 | R-b | |
| 3/25 | R-b | R-b |
| 4/25 | R-b | |
| 5/25 | ||
| 6/25 | R-b | |
| 7/25 | R-b | |
| 8/25 | R-b | |
| 9/25 | R-b | |
| 10/25 | R-b | |
| 11/25 | R-b | |
| 12/25 | R-b | |
| 13/25 | R-b | |
| 14/25 | R-b | |
| 15/25 | R-b | |
| 16/25 | ||
| 17/25 | R-b | |
| 18/25 | R-b | |
| 19/25 | ||
| 20/25 | ||
| 21/25 | ||
| 22/25 | ||
| 23/25 | ||
| 24/25 | ||
| 25/25 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 00/25] target/riscv/debug: Sdtrig fixes and TT Ascalon support
Hi,
Sorry for the big series. The Ascalon CPU implements Sdtrig with 2 different types of mcontrol6 trigger and the icount trigger, so in the course of testing and bringing up OpenSBI and Linux support for this, I've accumulated quite a lot.
My new year resolution is to start being better upstream contributor, it's taken me a while with changing jobs and architectures. So I don't expect others to drop everything to review this! Joel has been prodding me, and noted there is some other Sdtrig work going on with the v1.0 support patches.
I think the debug v1.0 patches are somewhat orthogonal to this series, but both are addressing aspects of a common problem of Sdtrig implementation specifics. I wonder if these should be reconciled or left separate. Sdtrig v1.00/v0.13 configuration is a single boolean which is feasible as a CPU property. Whereas the entire space of Sdtrig implementation seems like too much to make configurable in that way.
Any thoughts would be welcome.
Thanks,
Nick
Nicholas Piggin (25):
target/riscv/debug: Check only mcontrol triggers for break/watchpoint
matching
target/riscv/debug: Handle changing trigger types target/riscv/debug: Implement permissive type unavailable trigger target/riscv/debug: Fix icount trigger privilege check target/riscv/debug: Update itrigger_enabled after changing privilege target/riscv/debug: Implement get_trigger_action for icount type
trigger
target/riscv/debug: Fix migration post_load icount_enabled() test target/riscv/debug: Fix icount privilege matching icount_enabled()
test
target/riscv/debug: Implement icount trigger textra matching target/riscv/debug: Maintain itrigger_enabled in
helper_itrigger_match()
target/riscv/debug: Fix breakpoint matching action target/riscv/debug: Put mcontrol load/store match address into tval target/riscv/debug: Remove breakpoints on reset target/riscv/debug: Move debug CPU post_load details into debug.c target/riscv/debug: Insert breakpoints after migration target/riscv/debug: Remove itrigger icount-enabled mode target/riscv/debug: Advertise icount trigger type in tinfo target/riscv/debug: Reset trigger type to unavailable target/riscv/debug: Add new debug state format target/riscv/debug: Migrate mcontext using new sdtrig vmstate target/riscv/debug: Implementation specific Sdtrig configuration target/riscv/debug: Support heterogeneous trigger types target/riscv/debug: Support heterogeneous mcontrol access types target/riscv/debug: Emulate TT Ascalon Sdtrig target/riscv/debug: Fix minor comment typos
target/riscv/cpu.c | 65 ++++- target/riscv/cpu.h | 41 ++- target/riscv/cpu_helper.c | 10 +- target/riscv/csr.c | 7 +- target/riscv/debug.c | 571 ++++++++++++++++++++----------------- target/riscv/debug.h | 19 +- target/riscv/machine.c | 96 ++++++- target/riscv/tcg/tcg-cpu.c | 5 +- 8 files changed, 510 insertions(+), 304 deletions(-)
Signature · 1 line
2.51.0