Skip to content

staging: most: dim2: clean up error handling in fsl_mx6_enable

Artem Lytkin linux-staging lkml 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesNew
  2. v2 posting 2/23 patches 1 replySuperseded
  3. v2 posting 1/23 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches1 replySuperseded

Changes in v3 from the cover letter

- No code changes, resending as new thread to resolve duplicate v2 submissions (sorry for the noise)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: most: dim2: replace IS_ERR_OR_NULL with IS_ERR for devm_clk_getdrivers/staging/most/dim2/dim2.c+2 -20 replies
2/3staging: most: dim2: use dev_err_probe and proper error codes for clockdrivers/staging/most/dim2/dim2.c+5 -60 replies
3/3staging: most: dim2: remove unnecessary string indirection in dev_errdrivers/staging/most/dim2/dim2.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/3] staging: most: dim2: clean up error handling in fsl_mx6_enable

This series cleans up error handling in fsl_mx6_enable(), split into separate logical changes per Dan Carpenter's review of v1.

Patch 1 replaces IS_ERR_OR_NULL() with IS_ERR() since devm_clk_get() never returns NULL.

Patch 2 replaces dev_err() + hardcoded -EFAULT with dev_err_probe() and PTR_ERR() to propagate correct error codes and handle probe deferral properly.

Patch 3 removes unnecessary string indirection in dev_err() calls ("%s\n", "message" -> "message\n").

Changes since v2:
- No code changes, resending as new thread to resolve duplicate v2 submissions (sorry for the noise)

Changes since v1:
- Split combined patch into 3 separate patches (one change per patch)
- Extended string indirection fix to all three enable functions

Artem Lytkin (3):
staging: most: dim2: replace IS_ERR_OR_NULL with IS_ERR for
devm_clk_get
staging: most: dim2: use dev_err_probe and proper error codes for
clock
staging: most: dim2: remove unnecessary string indirection in dev_err

 drivers/staging/most/dim2/dim2.c | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)
Signature · 1 line
2.43.0