Skip to content

KVM: s390: Introducing kvm_arch_set_irq_inatomic Fast Inject

Douglas Freimuth kvm linux-s390 lkml 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest3 patches 1 replyIn review
  2. v93 patches 4 repliesSuperseded
  3. v83 patches 3 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v73 patches3 repliesSuperseded
v64 patches2 repliesSuperseded
v54 patches8 repliesSuperseded
v43 patches7 repliesSuperseded
v33 patches6 repliesSuperseded
v23 patches7 repliesSuperseded
v13 patches10 repliesSuperseded

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3KVM: s390: Add map/unmap ioctl and clean mappings post-guestarch/s390/include/asm/kvm_host.h arch/s390/kvm/interrupt.c arch/s390/kvm/kvm-s390.c +1 more+194 -430 replies
2/3KVM: s390: Enable adapter_indicators_set to use mapped pagesarch/s390/kvm/interrupt.c+63 -240 replies
3/3KVM: s390: Introducing kvm_arch_set_irq_inatomic fast injectarch/s390/include/asm/kvm_host.h arch/s390/kvm/intercept.c arch/s390/kvm/interrupt.c +2 more+241 -650 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMatthew RosatoClaudio Imbrenda
SeriesA-b
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [PATCH v10 0/3] KVM: s390: Introducing kvm_arch_set_irq_inatomic Fast Inject

s390 needs this series of three patches in order to enable a non-blocking path for irqfd injection on s390 via kvm_arch_set_irq_inatomic(). Before these changes, kvm_arch_set_irq_inatomic() would just return -EWOULDBLOCK and place all interrupts on the global work queue, which must subsequently be processed by a different thread. This series of patches implements an s390 version of inatomic and is relevant to virtio-blk and virtio-net and was tested against virtio-pci and virtio-ccw.

The inatomic fast path cannot lose control since it is running with interrupts disabled. This meant making the following changes that exist on the slow path today. First, the adapter_indicators page needs to be mapped since it is accessed with interrupts disabled, so we added map/unmap functions. Second, access to shared resources between the fast and slow paths needed to be changed from mutex and semaphores to spin_lock's. Finally, the memory allocation on the slow path utilizes GFP_KERNEL_ACCOUNT but we had to implement the fast path with GFP_ATOMIC allocation. Each of these enhancements were required to prevent blocking on the fast inject path.

s390 doesn't support a PREEMPT_RT kernel and this patch doesn't either. Given this fact, we are not using raw_spin_lock instead we are using regular spin_lock.

Statistical counters have been added to enable analysis of irq injection on the fast path and slow path including io_390_inatomic, io_flic_inject_airq, io_set_adapter_int and io_390_inatomic_no_inject. And
counters have been added to analyze map/unmap of the adapter_indicator pages in non-Secure Execution environments and to track fencing of Fast Inject in Secure Execution environments. In order to take advantage of this kernel series with virtio-pci, a QEMU that includes the 's390x/pci: set kvm_msi_via_irqfd_allowed' fix is needed. Additionally, the guest xml needs a thread pool and threads explicitly assigned per disk device using the common way of defining threads for disks.

Patch 1 enables map/unmap of adapter indicator pages but for Secure Execution environments it avoids the long term mapping.

v9->v10: Streamline logic in register_io_adapter()

Douglas Freimuth (3):
KVM: s390: Add map/unmap ioctl and clean mappings post-guest
KVM: s390: Enable adapter_indicators_set to use mapped pages
KVM: s390: Introducing kvm_arch_set_irq_inatomic fast inject

 arch/s390/include/asm/kvm_host.h |  11 +-
 arch/s390/kvm/intercept.c        |   5 +-
 arch/s390/kvm/interrupt.c        | 559 ++++++++++++++++++++++++-------
 arch/s390/kvm/kvm-s390.c         |  30 +-
 arch/s390/kvm/kvm-s390.h         |   5 +-
 5 files changed, 488 insertions(+), 122 deletions(-)
Signature · 1 line
2.54.0