KVM: s390: Introducing kvm_arch_set_irq_inatomic Fast Inject
v10 cover KVM: s390: Introducing kvm_arch_set_irq_inatomic Fast Inject
s390 needs this series of three patches in order to enable a non-blocking path for irqfd injection on s390 via kvm_arch_set_irq_inatomic(). Before these changes, kvm_arch_set_irq_inatomic() would just return -EWOULDBLOCK and place all interrupts on the global work queue, which must subsequently be processed by a different thread. This series of patches implements an s390 version of inatomic and is relevant to virtio-blk and virtio-net and was tested against virtio-pci and virtio-ccw.
The inatomic fast path cannot lose control since it is running with interrupts disabled. This meant making the following changes that exist on the slow path today. First, the adapter_indicators page needs to be mapped since it is accessed with interrupts disabled, so we added map/unmap functions. Second, access to shared resources between the fast and slow paths needed to be changed from mutex and semaphores to spin_lock's. Finally, the memory allocation on the slow path utilizes GFP_KERNEL_ACCOUNT but we had to implement the fast path with GFP_ATOMIC allocation. Each of these enhancements were required to prevent blocking on the fast inject path.
s390 doesn't support a PREEMPT_RT kernel and this patch doesn't either. Given this fact, we are not using raw_spin_lock instead we are using regular spin_lock.
Statistical counters have been added to enable analysis of irq injection on the fast path and slow path including io_390_inatomic, io_flic_inject_airq, io_set_adapter_int and io_390_inatomic_no_inject. And
counters have been added to analyze map/unmap of the adapter_indicator pages in non-Secure Execution environments and to track fencing of Fast Inject in Secure Execution environments. In order to take advantage of this kernel series with virtio-pci, a QEMU that includes the 's390x/pci: set kvm_msi_via_irqfd_allowed' fix is needed. Additionally, the guest xml needs a thread pool and threads explicitly assigned per disk device using the common way of defining threads for disks.
Patch 1 enables map/unmap of adapter indicator pages but for Secure Execution environments it avoids the long term mapping.
v9->v10: Streamline logic in register_io_adapter()
Douglas Freimuth (3):
KVM: s390: Add map/unmap ioctl and clean mappings post-guest
KVM: s390: Enable adapter_indicators_set to use mapped pages
KVM: s390: Introducing kvm_arch_set_irq_inatomic fast inject
arch/s390/include/asm/kvm_host.h | 11 +- arch/s390/kvm/intercept.c | 5 +- arch/s390/kvm/interrupt.c | 559 ++++++++++++++++++++++++------- arch/s390/kvm/kvm-s390.c | 30 +- arch/s390/kvm/kvm-s390.h | 5 +- 5 files changed, 488 insertions(+), 122 deletions(-)
Signature · 1 line
2.54.0
PATCH v10 1/3 KVM: s390: Add map/unmap ioctl and clean mappings post-guest
s390 needs map/unmap ioctls, which map the adapter set indicator pages, so the pages can be accessed when interrupts are disabled. The mappings are cleaned up when the guest is removed. pin_user_pages_remote is used for both the ioctl as well as the pin-on-demand logic in adapter_indicators_set().
Map/Unmap ioctls are fenced in order to avoid the longterm pinning in Secure Execution environments. In Secure Execution environments the path of execution available before this patch is followed.
Statistical counters to count map/unmap functions for adapter indicator pages are added. The counters can be used to analyze map/unmap functions in non-Secure Execution environments and similarly can be used to analyze Secure Execution environments where the counters will not be incremented as the adapter indicator pages are not mapped.
--- arch/s390/include/asm/kvm_host.h | 5 + arch/s390/kvm/interrupt.c | 227 +++++++++++++++++++++++++------ arch/s390/kvm/kvm-s390.c | 3 + arch/s390/kvm/kvm-s390.h | 2 + 4 files changed, 194 insertions(+), 43 deletions(-)
arch/s390/include/asm/kvm_host.h +5 -0
@@ -448,6 +448,8 @@ struct kvm_vcpu_arch {struct kvm_vm_stat {struct kvm_vm_stat_generic generic;u64 inject_io; +u64 io_390_adapter_map; +u64 io_390_adapter_unmap;u64 inject_float_mchk;u64 inject_pfault_done;u64 inject_service_signal;
@@ -479,6 +481,9 @@ struct s390_io_adapter {bool masked;bool swap;bool suppressible; +spinlock_t maps_lock; +struct list_head maps; +unsigned int nr_maps; };#define MAX_S390_IO_ADAPTERS ((MAX_ISC + 1) * 8)
arch/s390/kvm/interrupt.c +184 -43
288 lines not on this page · raw message
arch/s390/kvm/kvm-s390.c +3 -0
@@ -68,6 +68,8 @@const struct kvm_stats_desc kvm_vm_stats_desc[] = {KVM_GENERIC_VM_STATS (),STATS_DESC_COUNTER (VM , inject_io), +STATS_DESC_COUNTER (VM , io_390_adapter_map), +STATS_DESC_COUNTER (VM , io_390_adapter_unmap),STATS_DESC_COUNTER (VM , inject_float_mchk),STATS_DESC_COUNTER (VM , inject_pfault_done),STATS_DESC_COUNTER (VM , inject_service_signal),
@@ -2513,6 +2515,7 @@ static int kvm_s390_handle_pv(struct kvm *kvm, struct kvm_pv_cmd *cmd)if (kvm_s390_pv_is_protected (kvm))break ; +kvm_s390_unmap_all_adapters (kvm);mmap_write_lock (kvm->mm);/* * Disable creation of new THPs. Existing THPs can stay, they
arch/s390/kvm/kvm-s390.h +2 -0
@@ -560,6 +560,8 @@ void kvm_s390_gisa_disable(struct kvm *kvm);void kvm_s390_gisa_enable (struct kvm *kvm);int __init kvm_s390_gib_init (u8 nisc);void kvm_s390_gib_destroy (void ); +void kvm_s390_unmap_all_adapters (struct kvm *kvm); +/* implemented in guestdbg.c */ void kvm_s390_backup_guest_per_regs (struct kvm_vcpu *vcpu);
Signature · 1 line
2.54.0
PATCH v10 2/3 KVM: s390: Enable adapter_indicators_set to use mapped pages
In reply to Douglas FreimuthThe s390 adapter_indicators_set function can now be optimized to use long-term mapped pages when available so that work can be processed on a fast path when interrupts are disabled.
If adapter indicator pages are not mapped then local mapping is done on a slow path as it is prior to this patch. For example, Secure Execution environments will take the local mapping path as it does prior to this patch.
--- arch/s390/kvm/interrupt.c | 87 ++++++++++++++++++++++++++++----------- 1 file changed, 63 insertions(+), 24 deletions(-)
arch/s390/kvm/interrupt.c +63 -24
@@ -2892,41 +2892,80 @@ static unsigned long get_ind_bit(__u64 addr, unsigned long bit_nr, bool swap)return swap ? (bit ^ (BITS_PER_LONG -1 )) : bit; } +static struct s390_map_info *get_map_info (struct s390_io_adapter *adapter, +u64 addr) +{ +struct s390_map_info *map; + +if (!adapter) +return NULL ; + +list_for_each_entry (map, &adapter->maps, list) { +if (map->addr == addr) +return map; + } +return NULL ; +} +static int adapter_indicators_set (struct kvm *kvm,struct s390_io_adapter *adapter,struct kvm_s390_adapter_int *adapter_int) {unsigned long bit;int summary_set, idx; -struct page *ind_page, *summary_page; +struct s390_map_info *ind_info, *summary_info;void *map; +struct page *ind_page, *summary_page; +unsigned long flags; - ind_page =pin_map_page (kvm, adapter_int->ind_addr,0 ); -if (!ind_page) -return -1 ; - summary_page =pin_map_page (kvm, adapter_int->summary_addr,0 ); -if (!summary_page) { + ind_page =NULL ; + +spin_lock_irqsave (&adapter->maps_lock, flags); + ind_info =get_map_info (adapter, adapter_int->ind_addr); +if (!ind_info) { +spin_unlock_irqrestore (&adapter->maps_lock, flags); + ind_page =pin_map_page (kvm, adapter_int->ind_addr,0 ); +if (!ind_page) +return -1 ; + idx =srcu_read_lock (&kvm->srcu); + map =page_address (ind_page); + bit =get_ind_bit (adapter_int->ind_addr, + adapter_int->ind_offset, adapter->swap); +set_bit (bit, map); +mark_page_dirty (kvm, adapter_int->ind_gaddr >>PAGE_SHIFT ); +set_page_dirty_lock (ind_page); +srcu_read_unlock (&kvm->srcu, idx);unpin_user_page (ind_page); -return -1 ; + }else { + map =page_address (ind_info->page); + bit =get_ind_bit (ind_info->addr, adapter_int->ind_offset, adapter->swap); +set_bit (bit, map); +spin_unlock_irqrestore (&adapter->maps_lock, flags); + } +spin_lock_irqsave (&adapter->maps_lock, flags); + summary_info =get_map_info (adapter, adapter_int->summary_addr); +if (!summary_info) { +spin_unlock_irqrestore (&adapter->maps_lock, flags); + summary_page =pin_map_page (kvm, adapter_int->summary_addr,0 ); +if (WARN_ON_ONCE (!summary_page)) +return -1 ; + idx =srcu_read_lock (&kvm->srcu); + map =page_address (summary_page); + bit =get_ind_bit (adapter_int->summary_addr, + adapter_int->summary_offset, adapter->swap); + summary_set =test_and_set_bit (bit, map); +mark_page_dirty (kvm, adapter_int->summary_gaddr >>PAGE_SHIFT ); +set_page_dirty_lock (summary_page); +srcu_read_unlock (&kvm->srcu, idx); +unpin_user_page (summary_page); + }else { + map =page_address (summary_info->page); + bit =get_ind_bit (summary_info->addr, adapter_int->summary_offset, + adapter->swap); + summary_set =test_and_set_bit (bit, map); +spin_unlock_irqrestore (&adapter->maps_lock, flags); } - idx =srcu_read_lock (&kvm->srcu); - map =page_address (ind_page); - bit =get_ind_bit (adapter_int->ind_addr, - adapter_int->ind_offset, adapter->swap); -set_bit (bit, map); -mark_page_dirty (kvm, adapter_int->ind_gaddr >>PAGE_SHIFT ); -set_page_dirty_lock (ind_page); - map =page_address (summary_page); - bit =get_ind_bit (adapter_int->summary_addr, - adapter_int->summary_offset, adapter->swap); - summary_set =test_and_set_bit (bit, map); -mark_page_dirty (kvm, adapter_int->summary_gaddr >>PAGE_SHIFT ); -set_page_dirty_lock (summary_page); -srcu_read_unlock (&kvm->srcu, idx); - -unpin_user_page (ind_page); -unpin_user_page (summary_page);return summary_set ?0 :1 ; }
Signature · 1 line
2.54.0
[email protected]
AI reviewRe: [PATCH v10 2/3] KVM: s390: Enable adapter_indicators_set to use mapped pages
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: - [High] Host-userspace reachable WARN_ON_ONCE when pinning the summary page fails. - [High] Broken…
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] Host-userspace reachable WARN_ON_ONCE when pinning the summary page fails.
- [High] Broken atomicity: The indicator bit is set in guest memory before validating the summary page, leaving the guest in an inconsistent state on error.
- [High] The fast path for long-term mapped adapter indicators modifies guest memory without updating KVM's dirty page tracking, breaking live migration. --
commit eab5dd8ef6ef5a366acb6ed92a72330259c39430
Author: Douglas Freimuth <[email protected]>
KVM: s390: Enable adapter_indicators_set to use mapped pages
This commit optimizes the s390 adapter_indicators_set function to use long-term mapped pages when available. It introduces a fast path that operates under a spinlock, falling back to the existing pin-and-map slow path if the mapped pages are not found.
Quoted 4 lines
arch/s390/kvm/interrupt.c +0
-0
[ ... ]
Quoted 1 line
arch/s390/kvm/interrupt.c +0
-0@@ -2892,41 +2892,80 @@ static unsigned long get_ind_bit(__u64 addr, unsigned long bit_nr, bool swap)
[ ... ]
Quoted 4 lines
static int adapter_indicators_set(struct kvm *kvm,
arch/s390/kvm/interrupt.c +0
-0struct s390_io_adapter *adapter, struct kvm_s390_adapter_int *adapter_int) {
[ ... ]
arch/s390/kvm/interrupt.c static unsigned long get_ind_bit(__u64 addr, unsigned long bit_nr, bool swap) · line 2934
Quoted 12 lines
arch/s390/kvm/interrupt.c +12
-0+spin_lock_irqsave (&adapter->maps_lock, flags); + ind_info =get_map_info (adapter, adapter_int->ind_addr); +if (!ind_info) { +spin_unlock_irqrestore (&adapter->maps_lock, flags); + ind_page =pin_map_page (kvm, adapter_int->ind_addr,0 ); +if (!ind_page) +return -1 ; + idx =srcu_read_lock (&kvm->srcu); + map =page_address (ind_page); + bit =get_ind_bit (adapter_int->ind_addr, + adapter_int->ind_offset, adapter->swap); +set_bit (bit, map);
[Severity: High]
If the indicator bit is set here, but the subsequent attempt to resolve or pin the summary page fails and the function returns -1, does this code leave the indicator bit permanently set in guest memory?
Prior to this patch, both pages were successfully pinned before any bits were mutated, ensuring an all-or-nothing update.
arch/s390/kvm/interrupt.c static unsigned long get_ind_bit(__u64 addr, unsigned long bit_nr, bool swap) · line 2943
Quoted 9 lines
arch/s390/kvm/interrupt.c +9
-0+mark_page_dirty (kvm, adapter_int->ind_gaddr >>PAGE_SHIFT ); +set_page_dirty_lock (ind_page); +srcu_read_unlock (&kvm->srcu, idx); +unpin_user_page (ind_page); + }else { + map =page_address (ind_info->page); + bit =get_ind_bit (ind_info->addr, adapter_int->ind_offset, adapter->swap); +set_bit (bit, map); +spin_unlock_irqrestore (&adapter->maps_lock, flags);
[Severity: High]
By modifying the long-term mapped adapter indicator directly in the host virtual mapping, does this bypass KVM's dirty page tracking?
The slow path calls mark_page_dirty() and set_page_dirty_lock(), but the fast path skips them. Could this cause the migrated guest to lose interrupt delivery notifications if the updated indicator pages are not transferred to the destination VM?
arch/s390/kvm/interrupt.c static unsigned long get_ind_bit(__u64 addr, unsigned long bit_nr, bool swap) · line 2951
Quoted 8 lines
arch/s390/kvm/interrupt.c +8
-0+ } +spin_lock_irqsave (&adapter->maps_lock, flags); + summary_info =get_map_info (adapter, adapter_int->summary_addr); +if (!summary_info) { +spin_unlock_irqrestore (&adapter->maps_lock, flags); + summary_page =pin_map_page (kvm, adapter_int->summary_addr,0 ); +if (WARN_ON_ONCE (!summary_page)) +return -1 ;
[Severity: High]
Since the summary address is derived from guest-controlled KVM routing entries and managed by host userspace, could a malicious or misbehaving userspace process trigger this warning by unmapping the memory or providing an invalid address?
The KVM subsystem guidelines note that asserts whose conditions can be driven by unprivileged host userspace are a host-side denial of service, especially if panic_on_warn is enabled. Is it better to just return -1 here without the warning?
Quoted 5 lines
arch/s390/kvm/interrupt.c +5
-0+ idx =srcu_read_lock (&kvm->srcu); + map =page_address (summary_page); + bit =get_ind_bit (adapter_int->summary_addr, + adapter_int->summary_offset, adapter->swap); + summary_set =test_and_set_bit (bit, map);
arch/s390/kvm/interrupt.c static unsigned long get_ind_bit(__u64 addr, unsigned long bit_nr, bool swap) · line 2966
Quoted 10 lines
arch/s390/kvm/interrupt.c +10
-0+mark_page_dirty (kvm, adapter_int->summary_gaddr >>PAGE_SHIFT ); +set_page_dirty_lock (summary_page); +srcu_read_unlock (&kvm->srcu, idx); +unpin_user_page (summary_page); + }else { + map =page_address (summary_info->page); + bit =get_ind_bit (summary_info->addr, adapter_int->summary_offset, + adapter->swap); + summary_set =test_and_set_bit (bit, map); +spin_unlock_irqrestore (&adapter->maps_lock, flags);
[Severity: High]
Similar to the indicator page fast path above, does this code also bypass KVM dirty page tracking for the summary page when a mapped info structure is found?
Quoted 21 lines
arch/s390/kvm/interrupt.c +0
-17} - idx =srcu_read_lock (&kvm->srcu); - map =page_address (ind_page); - bit =get_ind_bit (adapter_int->ind_addr, - adapter_int->ind_offset, adapter->swap); -set_bit (bit, map); -mark_page_dirty (kvm, adapter_int->ind_gaddr >>PAGE_SHIFT ); -set_page_dirty_lock (ind_page); - map =page_address (summary_page); - bit =get_ind_bit (adapter_int->summary_addr, - adapter_int->summary_offset, adapter->swap); - summary_set =test_and_set_bit (bit, map); -mark_page_dirty (kvm, adapter_int->summary_gaddr >>PAGE_SHIFT ); -set_page_dirty_lock (summary_page); -srcu_read_unlock (&kvm->srcu, idx); - -unpin_user_page (ind_page); -unpin_user_page (summary_page);return summary_set ?0 :1 ; }
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
PATCH v10 3/3 KVM: s390: Introducing kvm_arch_set_irq_inatomic fast inject
In reply to Douglas Freimuths390 needs a fast path for irq injection, and along those lines we introduce kvm_arch_set_irq_inatomic. Instead of placing all interrupts on the global work queue as it does today, this patch provides a fast path for irq injection.
The inatomic fast path cannot lose control since it is running with interrupts disabled. This meant making the following changes that exist on the slow path today. First, the adapter_indicators page needs to be mapped since it is accessed with interrupts disabled, so we added map/unmap functions. Second, access to shared resources between the fast and slow paths needed to be changed from mutex and semaphores to spin_lock's. Finally, the memory allocation on the slow path utilizes GFP_KERNEL_ACCOUNT but we had to implement the fast path with GFP_ATOMIC allocation. Each of these enhancements were required to prevent blocking on the fast inject path.
Fencing of Fast Inject in Secure Execution environments is enabled in the patch series by not mapping adapter indicator pages. In Secure Execution environments the path of execution available before this patch is followed.
Statistical counters have been added to enable analysis of irq injection on the fast path and slow path including io_390_inatomic, io_flic_inject_airq, io_set_adapter_int and io_390_inatomic_no_inject. The no inject counter captures adapter masked, coalesced and suppressed interrupts.
--- arch/s390/include/asm/kvm_host.h | 6 +- arch/s390/kvm/intercept.c | 5 +- arch/s390/kvm/interrupt.c | 265 ++++++++++++++++++++++++------- arch/s390/kvm/kvm-s390.c | 27 +++- arch/s390/kvm/kvm-s390.h | 3 +- 5 files changed, 241 insertions(+), 65 deletions(-)
arch/s390/include/asm/kvm_host.h +5 -1
@@ -359,7 +359,7 @@ struct kvm_s390_float_interrupt {struct kvm_s390_mchk_info mchk;struct kvm_s390_ext_info srv_signal;int last_sleep_cpu; -struct mutex ais_lock; +spinlock_t ais_lock;u8 simm;u8 nimm; };
@@ -450,6 +450,10 @@ struct kvm_vm_stat {u64 inject_io;u64 io_390_adapter_map;u64 io_390_adapter_unmap; +u64 io_390_inatomic; +u64 io_flic_inject_airq; +u64 io_set_adapter_int; +u64 io_390_inatomic_no_inject;u64 inject_float_mchk;u64 inject_pfault_done;u64 inject_service_signal;
arch/s390/kvm/intercept.c +3 -2
@@ -517,8 +517,9 @@ static int handle_pv_spx(struct kvm_vcpu *vcpu)static int handle_pv_sclp (struct kvm_vcpu *vcpu) {struct kvm_s390_float_interrupt *fi = &vcpu->kvm->arch.float_int; +unsigned long flags; -spin_lock (&fi->lock); +spin_lock_irqsave (&fi->lock, flags);/* * 2 cases: * a: an sccb answering interrupt was already pending or in flight.
@@ -534,7 +535,7 @@ static int handle_pv_sclp(struct kvm_vcpu *vcpu) fi->srv_signal.ext_params |=0x43000 ;set_bit (IRQ_PEND_EXT_SERVICE , &fi->pending_irqs);clear_bit (IRQ_PEND_EXT_SERVICE , &fi->masked_irqs); -spin_unlock (&fi->lock); +spin_unlock_irqrestore (&fi->lock, flags);return 0 ; }
arch/s390/kvm/interrupt.c +208 -57
589 lines not on this page · raw message
arch/s390/kvm/kvm-s390.c +23 -4
@@ -70,6 +70,10 @@ const struct kvm_stats_desc kvm_vm_stats_desc[] = {STATS_DESC_COUNTER (VM , inject_io),STATS_DESC_COUNTER (VM , io_390_adapter_map),STATS_DESC_COUNTER (VM , io_390_adapter_unmap), +STATS_DESC_COUNTER (VM , io_390_inatomic), +STATS_DESC_COUNTER (VM , io_flic_inject_airq), +STATS_DESC_COUNTER (VM , io_set_adapter_int), +STATS_DESC_COUNTER (VM , io_390_inatomic_no_inject),STATS_DESC_COUNTER (VM , inject_float_mchk),STATS_DESC_COUNTER (VM , inject_pfault_done), STATS_DESC_COUNTER(VM, inject_service_signal),
@@ -2851,6 +2855,7 @@ int kvm_arch_vm_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg)void __user *argp = (void __user *)arg;struct kvm_device_attr attr;int r; +struct kvm_s390_interrupt_info *inti;switch (ioctl) {case KVM_S390_INTERRUPT : {
@@ -2859,7 +2864,12 @@ int kvm_arch_vm_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg) r = -EFAULT ;if (copy_from_user (&s390int, argp,sizeof (s390int)))break ; - r =kvm_s390_inject_vm (kvm, &s390int); + inti =kzalloc_obj (*inti,GFP_KERNEL_ACCOUNT ); +if (!inti) +return -ENOMEM ; + r =kvm_s390_inject_vm (kvm, &s390int, inti); +if (r) +kfree (inti);break ; }case KVM_CREATE_IRQCHIP : {
@@ -3257,7 +3267,7 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)mutex_unlock (&kvm->lock); } -mutex_init (&kvm->arch.float_int.ais_lock); +spin_lock_init (&kvm->arch.float_int.ais_lock);spin_lock_init (&kvm->arch.float_int.lock);for (i =0 ; i <FIRQ_LIST_COUNT ; i++)INIT_LIST_HEAD (&kvm->arch.float_int.lists[i]);
@@ -4379,19 +4389,28 @@ int kvm_s390_try_set_tod_clock(struct kvm *kvm, const struct kvm_s390_vm_tod_clo }static void __kvm_inject_pfault_token (struct kvm_vcpu *vcpu,bool start_token, -unsigned long token) +unsigned long token) {struct kvm_s390_interrupt inti;struct kvm_s390_irq irq; +struct kvm_s390_interrupt_info *inti_mem =NULL ; +int ret =0 ;if (start_token) { irq.u.ext.ext_params2 = token; irq.type =KVM_S390_INT_PFAULT_INIT ;WARN_ON_ONCE (kvm_s390_inject_vcpu (vcpu, &irq)); }else { + inti_mem =kzalloc_obj (*inti_mem,GFP_KERNEL_ACCOUNT ); +if (WARN_ON_ONCE (!inti_mem)) +return ; + inti.type =KVM_S390_INT_PFAULT_DONE ; inti.parm64 = token; -WARN_ON_ONCE (kvm_s390_inject_vm (vcpu->kvm, &inti)); + ret =kvm_s390_inject_vm (vcpu->kvm, &inti, inti_mem); +if (ret) +kfree (inti_mem); +WARN_ON_ONCE (ret); } }
arch/s390/kvm/kvm-s390.h +2 -1
@@ -376,7 +376,8 @@ int __must_check kvm_s390_deliver_pending_interrupts(struct kvm_vcpu *vcpu);void kvm_s390_clear_local_irqs (struct kvm_vcpu *vcpu);void kvm_s390_clear_float_irqs (struct kvm *kvm);int __must_check kvm_s390_inject_vm (struct kvm *kvm, -struct kvm_s390_interrupt *s390int); +struct kvm_s390_interrupt *s390int, +struct kvm_s390_interrupt_info *inti);int __must_check kvm_s390_inject_vcpu (struct kvm_vcpu *vcpu,struct kvm_s390_irq *irq); static inline int kvm_s390_inject_prog_irq(struct kvm_vcpu *vcpu,
Signature · 1 line
2.54.0
[email protected]
AI reviewRe: [PATCH v10 3/3] KVM: s390: Introducing kvm_arch_set_irq_inatomic fast inject
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
New issues:
- [High] Missing KVM Dirty Page Tracking during Fast IRQ Injection.
Pre-existing issues:
- [High] Guest-Triggerable WARNING / Denial of Service on memory allocation failure. --
commit 87294ba489c0602b2b9baebf0c40ddd4f77205c0
Author: Douglas Freimuth <[email protected]>
Subject: KVM: s390: Introducing kvm_arch_set_irq_inatomic fast inject
This patch introduces a fast path for irq injection on s390 via kvm_arch_set_irq_inatomic. It avoids placing interrupts on the global work queue by directly mapping adapter indicator pages and accessing shared resources using spinlocks instead of mutexes.
Quoted 4 lines
arch/s390/kvm/interrupt.c +0
-0
[ ... ]
Quoted 14 lines
arch/s390/kvm/interrupt.c +10
-0@@ -2969,6 +2998,44 @@ static int adapter_indicators_set(struct kvm *kvm,return summary_set ?0 :1 ; } +static int adapter_indicators_set_fast (struct kvm *kvm, +struct s390_io_adapter *adapter, +struct kvm_s390_adapter_int *adapter_int, +int setbit) +{ +unsigned long bit; +int summary_set; +struct s390_map_info *ind_info, *summary_info; +void *map; +
arch/s390/kvm/interrupt.c static int adapter_indicators_set(struct kvm *kvm, · line 3020
Quoted 10 lines
arch/s390/kvm/interrupt.c +10
-0+spin_lock (&adapter->maps_lock); + ind_info =get_map_info (adapter, adapter_int->ind_addr); +if (!ind_info) { +spin_unlock (&adapter->maps_lock); +return -EWOULDBLOCK ; + } + map =page_address (ind_info->page); + bit =get_ind_bit (ind_info->addr, adapter_int->ind_offset, adapter->swap); +if (setbit) +set_bit (bit, map);
[Severity: High]
Does this bypass dirty page tracking? Since the guest memory is directly mutated here using the kernel virtual address mapping, the hardware dirty bit won't be set.
It appears KVM must explicitly invoke mark_page_dirty() (or an equivalent) to record this modification in the memory slot's dirty bitmap. Without it, pending interrupts injected via the fast path might be lost after live migration, leading to guest I/O hangs or data corruption.
Quoted 4 lines
arch/s390/kvm/interrupt.c +4
-0+ summary_info =get_map_info (adapter, adapter_int->summary_addr); +if (!summary_info) { +spin_unlock (&adapter->maps_lock); +return -EWOULDBLOCK ;
arch/s390/kvm/interrupt.c static int adapter_indicators_set(struct kvm *kvm, · line 3034
Quoted 10 lines
arch/s390/kvm/interrupt.c +10
-0+ } + map =page_address (summary_info->page); + bit =get_ind_bit (summary_info->addr, adapter_int->summary_offset, + adapter->swap); +/* If setbit then set summary bit. Else if falling back to the slow path */ +/* with setbit==0 then clear the summary bit so the slow path re-injects */ +if (setbit) + summary_set =test_and_set_bit (bit, map); +else + summary_set =test_and_clear_bit (bit, map);
[Severity: High]
Similarly, does the summary page modification here also need explicit dirty page tracking?
Quoted 3 lines
arch/s390/kvm/interrupt.c +3
-0+spin_unlock (&adapter->maps_lock); +return summary_set ?0 :1 ; +}
[ ... ]
Quoted 4 lines
arch/s390/kvm/kvm-s390.c +0
-0
[ ... ]
Quoted 10 lines
arch/s390/kvm/kvm-s390.c +2
-1@@ -4379,19 +4389,28 @@ int kvm_s390_try_set_tod_clock(struct kvm *kvm, const struct kvm_s390_vm_tod_clo }static void __kvm_inject_pfault_token (struct kvm_vcpu *vcpu,bool start_token, -unsigned long token) +unsigned long token) {struct kvm_s390_interrupt inti;struct kvm_s390_irq irq; +struct kvm_s390_interrupt_info *inti_mem =NULL ;
arch/s390/kvm/kvm-s390.c int kvm_s390_try_set_tod_clock(struct kvm *kvm, const struct kvm_s390_vm_tod_clo · line 4406
Quoted 10 lines
arch/s390/kvm/kvm-s390.c +4
-0+int ret =0 ;if (start_token) { irq.u.ext.ext_params2 = token; irq.type =KVM_S390_INT_PFAULT_INIT ;WARN_ON_ONCE (kvm_s390_inject_vcpu (vcpu, &irq)); }else { + inti_mem =kzalloc_obj (*inti_mem,GFP_KERNEL_ACCOUNT ); +if (WARN_ON_ONCE (!inti_mem)) +return ;
[Severity: High]
This isn't a bug introduced by this patch, but does this guest-triggerable warning create a Denial of Service risk?
The KVM subsystem guidelines explicitly state there should be no guest- or host-userspace-reachable WARN_ON or BUG_ON. If this allocation fails (e.g. under host memory pressure, or if a malicious guest deliberately exhausts its memory cgroup limits via asynchronous page faults), it will hit this warning. On systems configured with panic_on_warn=1, an unprivileged guest could intentionally crash the host.
Quoted 10 lines
arch/s390/kvm/kvm-s390.c +5
-1+ inti.type =KVM_S390_INT_PFAULT_DONE ; inti.parm64 = token; -WARN_ON_ONCE (kvm_s390_inject_vm (vcpu->kvm, &inti)); + ret =kvm_s390_inject_vm (vcpu->kvm, &inti, inti_mem); +if (ret) +kfree (inti_mem); +WARN_ON_ONCE (ret); } }
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
Quoted 34 lines · On Thu, 4 Jun 2026 21:27:52 +0200 Douglas Freimuth <[email protected]>…
s390 needs this series of three patches in order to enable a non-blocking path for irqfd injection on s390 via
kvm_arch_set_irq_inatomic(). Before these changes,kvm_arch_set_irq_inatomic()would just return-EWOULDBLOCKand place all interrupts on the global work queue, which must subsequently be processed by a different thread. This series of patches implements an s390 version of inatomic and is relevant to virtio-blk and virtio-net and was tested against virtio-pci and virtio-ccw.The inatomic fast path cannot lose control since it is running with interrupts disabled. This meant making the following changes that exist on the slow path today. First, the
adapter_indicatorspage needs to be mapped since it is accessed with interrupts disabled, so we added map/unmap functions. Second, access to shared resources between the fast and slow paths needed to be changed from mutex and semaphores to spin_lock's. Finally, the memory allocation on the slow path utilizesGFP_KERNEL_ACCOUNTbut we had to implement the fast path withGFP_ATOMICallocation. Each of these enhancements were required to prevent blocking on the fast inject path.s390 doesn't support a
PREEMPT_RTkernel and this patch doesn't either. Given this fact, we are not usingraw_spin_lockinstead we are using regularspin_lock.Statistical counters have been added to enable analysis of irq injection on the fast path and slow path including
io_390_inatomic,io_flic_inject_airq,io_set_adapter_intandio_390_inatomic_no_inject. And
counters have been added to analyze map/unmap of theadapter_indicatorpages in non-Secure Execution environments and to track fencing of Fast Inject in Secure Execution environments. In order to take advantage of this kernel series with virtio-pci, a QEMU that includes the 's390x/pci: setkvm_msi_via_irqfd_allowed' fix is needed. Additionally, the guest xml needs a thread pool and threads explicitly assigned per disk device using the common way of defining threads for disks.
Quoted 3 lines
Patch 1 enables map/unmap of adapter indicator pages but for Secure Execution environments it avoids the long term mapping.
Whole series:
Quoted 14 lines
v9->v10: Streamline logic inregister_io_adapter()Douglas Freimuth (3):
KVM: s390: Add map/unmap ioctl and clean mappings post-guest
KVM: s390: Enableadapter_indicators_setto use mapped pages
KVM: s390: Introducingkvm_arch_set_irq_inatomicfast injectarch/s390/include/asm/kvm_host.h | 11 +- arch/s390/kvm/intercept.c | 5 +- arch/s390/kvm/interrupt.c | 559 ++++++++++++++++++++++++------- arch/s390/kvm/kvm-s390.c | 30 +- arch/s390/kvm/kvm-s390.h | 5 +- 5 files changed, 488 insertions(+), 122 deletions(-)