dpll: add frequency monitoring feature
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 0 repliesApplied 3/3
- v33 patches 3 repliesSuperseded
- v23 patches 7 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 3 patches | 6 replies | Superseded |
Changes in v4 from the cover letter
- Moved freq_monitor_{g,s}et validation from netlink to pin registration with WARN_ON (Vadim)
Patches in v4 All 3 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | dpll: add frequency monitoring to netlink specDocumentation/ Documentation/ drivers/ +1 more | +62 | 0 replies | Applied |
| 2/3 | dpll: add frequency monitoring callback opsdrivers/ drivers/ include/ | +104 | 0 replies | Applied |
| 3/3 | dpll: zl3073x: implement frequency monitoringdrivers/ drivers/ drivers/ +1 more | +187 | 0 replies | Applied |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Vadim Fedorenko | Petr Oros |
|---|---|---|
| 1/3 | R-b | |
| 2/3 | R-b | |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/3] dpll: add frequency monitoring feature
This series adds support for monitoring the measured input frequency of DPLL input pins via the DPLL netlink interface.
Some DPLL devices can measure the actual frequency being received on input pins. The approach mirrors the existing phase-offset-monitor
feature: a device-level attribute (DPLL_A_FREQUENCY_MONITOR) enables or disables monitoring, and a per-pin attribute (DPLL_A_PIN_MEASURED_FREQUENCY) exposes the measured frequency in millihertz (mHz) when monitoring is enabled.
Patch 1 adds the new attributes to the DPLL netlink spec (dpll.yaml), the DPLL_PIN_MEASURED_FREQUENCY_DIVIDER constant, regenerates the auto-generated UAPI header and netlink policy, and updates Documentation/driver-api/dpll.rst.
Patch 2 adds the callback operations (freq_monitor_get/set for devices, measured_freq_get for pins) and the corresponding netlink GET/SET handlers in the DPLL core. The core only invokes measured_freq_get when the frequency monitor is enabled on the parent device. The freq_monitor_get callback is required when measured_freq_get is provided.
Patch 3 implements the feature in the ZL3073x driver by extracting a common measurement latch helper from the existing FFO update path, adding a frequency measurement function, and wiring up the new callbacks.
Changes v3 -> v4:
- Moved freq_monitor_{g,s}et validation from netlink to pin registration with WARN_ON (Vadim)
Changes v2 -> v3:
- Improved frequency-monitor doc wording (Jakub)
- Changed measured-frequency to mHz with divider constant (Jakub)
- Made freq_monitor_get required when measured_freq_get is present (Jakub)
Changes v1 -> v2:
- Renamed actual-frequency to measured-frequency (Vadim)
Ivan Vecera (3):
dpll: add frequency monitoring to netlink spec
dpll: add frequency monitoring callback ops
dpll: zl3073x: implement frequency monitoring
Documentation/driver-api/dpll.rst | 20 ++++++ Documentation/netlink/specs/dpll.yaml | 35 +++++++++ drivers/dpll/dpll_core.c | 5 +- drivers/dpll/dpll_netlink.c | 90 +++++++++++++++++++++++ drivers/dpll/dpll_nl.c | 5 +- drivers/dpll/zl3073x/core.c | 88 +++++++++++++++++++---- drivers/dpll/zl3073x/dpll.c | 100 ++++++++++++++++++++++++-- drivers/dpll/zl3073x/dpll.h | 2 + drivers/dpll/zl3073x/ref.h | 14 ++++ include/linux/dpll.h | 10 +++ include/uapi/linux/dpll.h | 5 +- 11 files changed, 353 insertions(+), 21 deletions(-)
Signature · 1 line
2.52.0