Skip to content

Introduce Completion Counters

Michael Margolin linux-rdma 12 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v11 Latest6 patches 1 replyApplied
  2. v106 patches 4 repliesSuperseded
  3. v96 patches 0 repliesSuperseded
Earlier versions · 9
VersionPostedPatchesRepliesStatus
v85 patches3 repliesSuperseded
v75 patches0 repliesSuperseded
v6 posting 2/21 of 5 patches0 repliesSuperseded
v6 posting 1/24 of 5 patches0 repliesSuperseded
v55 patches0 repliesSuperseded
v45 patches0 repliesSuperseded
v33 of 5 patches0 repliesSuperseded
v25 patches9 repliesSuperseded
v14 patches11 repliesSuperseded

Changes in v11 from the cover letter

- Moved restrack init to be prior to call to driver
- Link to v10: https://lore.kernel.org/all/[email protected]/

Patches in v11 Applied

#Subject and filesSizeRepliesApplied
1/6RDMA/core: Add Completion Counters supportdrivers/infiniband/core/Makefile drivers/infiniband/core/device.c drivers/infiniband/core/rdma_core.h +6 more+310 -10 replies
2/6RDMA/core: Prevent destroying in-use completion countersdrivers/infiniband/core/uverbs_std_types_comp_cntr.c drivers/infiniband/core/uverbs_std_types_qp.c drivers/infiniband/core/verbs.c +1 more+31 -10 replies
3/6RDMA/core: Expose Completion Counter capabilities to userspacedrivers/infiniband/core/device.c drivers/infiniband/core/uverbs_std_types_device.c include/rdma/ib_verbs.h +1 more+67 -10 replies
4/6RDMA/core: Add Completion Counters to resource trackingdrivers/infiniband/core/nldev.c drivers/infiniband/core/restrack.c drivers/infiniband/core/uverbs_std_types_comp_cntr.c +2 more+22 -00 replies
5/6RDMA/efa: Update device interfacedrivers/infiniband/hw/efa/efa_admin_cmds_defs.h drivers/infiniband/hw/efa/efa_io_defs.h+202 -40 replies
6/6RDMA/efa: Add Completion Counters supportdrivers/infiniband/hw/efa/efa.h drivers/infiniband/hw/efa/efa_com_cmd.c drivers/infiniband/hw/efa/efa_com_cmd.h +3 more+450 -20 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchYonatan NachumDaniel Kinsbursky
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v11 thread

Cover letter [PATCH for-next v11 0/6] Introduce Completion Counters

Add core infrastructure for Completion Counters, a light-weight alternative to polling CQ for tracking operation completions. The related rdma-core support is linked in [1].

Define the UVERBS_OBJECT_COMP_CNTR ioctl object with create, destroy, modify and read methods for both success and error counters. Add a QP attach method on the QP object to associate a completion counter with a queue pair.

Add EFA Completion Counters support as first implementer.

[1] https://github.com/linux-rdma/rdma-core/pull/1701

---
Changes in v11:
- Moved restrack init to be prior to call to driver
- Link to v10: https://lore.kernel.org/all/[email protected]/
Changes in v10:
- No changes, v9 email thread got corrupted
Changes in v9:
- Moved counter max value report from per counter create response to a new device level command that aggregates completion counter capabilities
- Exposed supported ops in QP attach as part of the above command response
- Link to v8: https://lore.kernel.org/all/[email protected]/
Changes in v8:
- Added device event counter detach support and its use in attach error handling
- Prevented completion counters attach to wrapper QPs
- Added max completion counters report in nldev
- Link to v7: https://lore.kernel.org/all/[email protected]/
Changes in v7:
- Rebased on latest rdma for-next
- Link to v6: https://lore.kernel.org/all/[email protected]/
Changes in v6:
- Moved to using ib_umem_get_attr util
- Resolved additional Sashiko comments
- Link to v5: https://lore.kernel.org/all/[email protected]/
Changes in v5:
- Fixed Sashiko findings
- Minor naming improvements
- Link to v4: https://lore.kernel.org/all/[email protected]/
Changes in v4:
- Replaced inc and set commands by a single modify command
- Changed to passing buffers as EFA specific attributes using desc struct aligned with the suggested common method of passing and consuming umem in RDMA drivers
- Link to v2: https://lore.kernel.org/all/[email protected]/
Changes in v3:
- Skipped this version because of a wrong patch list
Changes in v2:
- United set, inc and read flows for successful and error completions counters
- Added comp_cntr usage count
- Minor cleanups
- Link to v1: https://lore.kernel.org/all/[email protected]/

Michael Margolin (6):
RDMA/core: Add Completion Counters support RDMA/core: Prevent destroying in-use completion counters RDMA/core: Expose Completion Counter capabilities to userspace RDMA/core: Add Completion Counters to resource tracking RDMA/efa: Update device interface
RDMA/efa: Add Completion Counters support

 drivers/infiniband/core/Makefile              |   1 +
 drivers/infiniband/core/device.c              |   7 +
 drivers/infiniband/core/nldev.c               |   8 +
 drivers/infiniband/core/rdma_core.h           |   1 +
 drivers/infiniband/core/restrack.c            |   2 +
 .../core/uverbs_std_types_comp_cntr.c         | 169 +++++++++++++
 .../infiniband/core/uverbs_std_types_device.c |  51 +++-
 drivers/infiniband/core/uverbs_std_types_qp.c |  67 ++++-
 drivers/infiniband/core/uverbs_uapi.c         |   1 +
 drivers/infiniband/core/verbs.c               |   8 +
 drivers/infiniband/hw/efa/efa.h               |  20 +-
 .../infiniband/hw/efa/efa_admin_cmds_defs.h   | 186 +++++++++++++-
 drivers/infiniband/hw/efa/efa_com_cmd.c       | 136 ++++++++++
 drivers/infiniband/hw/efa/efa_com_cmd.h       |  45 ++++
 drivers/infiniband/hw/efa/efa_io_defs.h       |  20 +-
 drivers/infiniband/hw/efa/efa_main.c          |   8 +-
 drivers/infiniband/hw/efa/efa_verbs.c         | 237 ++++++++++++++++++
 include/rdma/ib_verbs.h                       |  50 ++++
 include/rdma/restrack.h                       |   4 +
 include/uapi/rdma/efa-abi.h                   |   6 +
 include/uapi/rdma/ib_user_ioctl_cmds.h        |  43 ++++
 include/uapi/rdma/ib_user_ioctl_verbs.h       |  19 ++
 22 files changed, 1081 insertions(+), 8 deletions(-)
 create mode 100644 drivers/infiniband/core/uverbs_std_types_comp_cntr.c
Signature · 1 line
2.47.3