Introduce Completion Counters
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v11 Latest6 patches 1 replyApplied
- v106 patches 4 repliesSuperseded
- v96 patches 0 repliesSuperseded
Earlier versions · 9
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v8 | 5 patches | 3 replies | Superseded | |
| v7 | 5 patches | 0 replies | Superseded | |
| v6 posting 2/2 | 1 of 5 patches | 0 replies | Superseded | |
| v6 posting 1/2 | 4 of 5 patches | 0 replies | Superseded | |
| v5 | 5 patches | 0 replies | Superseded | |
| v4 | 5 patches | 0 replies | Superseded | |
| v3 | 3 of 5 patches | 0 replies | Superseded | |
| v2 | 5 patches | 9 replies | Superseded | |
| v1 | 4 patches | 11 replies | Superseded |
Changes in v11 from the cover letter
- Moved restrack init to be prior to call to driver
- Link to v10: https://lore.kernel.org/all/[email protected]/
Patches in v11 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | RDMA/core: Add Completion Counters supportdrivers/ drivers/ drivers/ +6 more | +310 | 0 replies | |
| 2/6 | RDMA/core: Prevent destroying in-use completion countersdrivers/ drivers/ drivers/ +1 more | +31 | 0 replies | |
| 3/6 | RDMA/core: Expose Completion Counter capabilities to userspacedrivers/ drivers/ include/ +1 more | +67 | 0 replies | |
| 4/6 | RDMA/core: Add Completion Counters to resource trackingdrivers/ drivers/ drivers/ +2 more | +22 | 0 replies | |
| 5/6 | RDMA/efa: Update device interfacedrivers/ drivers/ | +202 | 0 replies | |
| 6/6 | RDMA/efa: Add Completion Counters supportdrivers/ drivers/ drivers/ +3 more | +450 | 0 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Yonatan Nachum | Daniel Kinsbursky |
|---|---|---|
| 1/6 | R-b | |
| 2/6 | R-b | |
| 3/6 | R-b | |
| 4/6 | R-b | |
| 5/6 | R-b | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH for-next v11 0/6] Introduce Completion Counters
Add core infrastructure for Completion Counters, a light-weight alternative to polling CQ for tracking operation completions. The related rdma-core support is linked in [1].
Define the UVERBS_OBJECT_COMP_CNTR ioctl object with create, destroy, modify and read methods for both success and error counters. Add a QP attach method on the QP object to associate a completion counter with a queue pair.
Add EFA Completion Counters support as first implementer.
[1] https://github.com/linux-rdma/rdma-core/pull/1701
---
Changes in v11:
- Moved restrack init to be prior to call to driver
- Link to v10: https://lore.kernel.org/all/[email protected]/
Changes in v10:
- No changes, v9 email thread got corrupted
Changes in v9:
- Moved counter max value report from per counter create response to a new device level command that aggregates completion counter capabilities
- Exposed supported ops in QP attach as part of the above command response
- Link to v8: https://lore.kernel.org/all/[email protected]/
Changes in v8:
- Added device event counter detach support and its use in attach error handling
- Prevented completion counters attach to wrapper QPs
- Added max completion counters report in nldev
- Link to v7: https://lore.kernel.org/all/[email protected]/
Changes in v7:
- Rebased on latest rdma for-next
- Link to v6: https://lore.kernel.org/all/[email protected]/
Changes in v6:
- Moved to using ib_umem_get_attr util
- Resolved additional Sashiko comments
- Link to v5: https://lore.kernel.org/all/[email protected]/
Changes in v5:
- Fixed Sashiko findings
- Minor naming improvements
- Link to v4: https://lore.kernel.org/all/[email protected]/
Changes in v4:
- Replaced inc and set commands by a single modify command
- Changed to passing buffers as EFA specific attributes using desc struct aligned with the suggested common method of passing and consuming umem in RDMA drivers
- Link to v2: https://lore.kernel.org/all/[email protected]/
Changes in v3:
- Skipped this version because of a wrong patch list
Changes in v2:
- United set, inc and read flows for successful and error completions counters
- Added comp_cntr usage count
- Minor cleanups
- Link to v1: https://lore.kernel.org/all/[email protected]/
Michael Margolin (6):
RDMA/core: Add Completion Counters support RDMA/core: Prevent destroying in-use completion counters RDMA/core: Expose Completion Counter capabilities to userspace RDMA/core: Add Completion Counters to resource tracking RDMA/efa: Update device interface
RDMA/efa: Add Completion Counters support
drivers/infiniband/core/Makefile | 1 + drivers/infiniband/core/device.c | 7 + drivers/infiniband/core/nldev.c | 8 + drivers/infiniband/core/rdma_core.h | 1 + drivers/infiniband/core/restrack.c | 2 + .../core/uverbs_std_types_comp_cntr.c | 169 +++++++++++++ .../infiniband/core/uverbs_std_types_device.c | 51 +++- drivers/infiniband/core/uverbs_std_types_qp.c | 67 ++++- drivers/infiniband/core/uverbs_uapi.c | 1 + drivers/infiniband/core/verbs.c | 8 + drivers/infiniband/hw/efa/efa.h | 20 +- .../infiniband/hw/efa/efa_admin_cmds_defs.h | 186 +++++++++++++- drivers/infiniband/hw/efa/efa_com_cmd.c | 136 ++++++++++ drivers/infiniband/hw/efa/efa_com_cmd.h | 45 ++++ drivers/infiniband/hw/efa/efa_io_defs.h | 20 +- drivers/infiniband/hw/efa/efa_main.c | 8 +- drivers/infiniband/hw/efa/efa_verbs.c | 237 ++++++++++++++++++ include/rdma/ib_verbs.h | 50 ++++ include/rdma/restrack.h | 4 + include/uapi/rdma/efa-abi.h | 6 + include/uapi/rdma/ib_user_ioctl_cmds.h | 43 ++++ include/uapi/rdma/ib_user_ioctl_verbs.h | 19 ++ 22 files changed, 1081 insertions(+), 8 deletions(-) create mode 100644 drivers/infiniband/core/uverbs_std_types_comp_cntr.c
Signature · 1 line
2.47.3