Introduce Completion Counters
v9 cover Introduce Completion Counters
Add core infrastructure for Completion Counters, a light-weight alternative to polling CQ for tracking operation completions. The related rdma-core support is linked in [1].
Define the UVERBS_OBJECT_COMP_CNTR ioctl object with create, destroy, modify and read methods for both success and error counters. Add a QP attach method on the QP object to associate a completion counter with a queue pair.
Add EFA Completion Counters support as first implementer.
[1] https://github.com/linux-rdma/rdma-core/pull/1701
---
Changes in v9:
- Moved counter max value report from per counter create response to a new device level command that aggregates completion counter capabilities
- Exposed supported ops in QP attach as part of the above command response
- Link to v8: https://lore.kernel.org/all/[email protected]/
Changes in v8:
- Added device event counter detach support and its use in attach error handling
- Prevented completion counters attach to wrapper QPs
- Added max completion counters report in nldev
- Link to v7: https://lore.kernel.org/all/[email protected]/
Changes in v7:
- Rebased on latest rdma for-next
- Link to v6: https://lore.kernel.org/all/[email protected]/
Changes in v6:
- Moved to using ib_umem_get_attr util
- Resolved additional Sashiko comments
- Link to v5: https://lore.kernel.org/all/[email protected]/
Changes in v5:
- Fixed Sashiko findings
- Minor naming improvements
- Link to v4: https://lore.kernel.org/all/[email protected]/
Changes in v4:
- Replaced inc and set commands by a single modify command
- Changed to passing buffers as EFA specific attributes using desc struct aligned with the suggested common method of passing and consuming umem in RDMA drivers
- Link to v2: https://lore.kernel.org/all/[email protected]/
Changes in v3:
- Skipped this version because of a wrong patch list
Changes in v2:
- United set, inc and read flows for successful and error completions counters
- Added comp_cntr usage count
- Minor cleanups
- Link to v1: https://lore.kernel.org/all/[email protected]/
Michael Margolin (6):
RDMA/core: Add Completion Counters support RDMA/core: Prevent destroying in-use completion counters RDMA/core: Expose Completion Counter capabilities to userspace RDMA/core: Add Completion Counters to resource tracking RDMA/efa: Update device interface
RDMA/efa: Add Completion Counters support
drivers/infiniband/core/Makefile | 1 + drivers/infiniband/core/device.c | 7 + drivers/infiniband/core/nldev.c | 8 + drivers/infiniband/core/rdma_core.h | 1 + drivers/infiniband/core/restrack.c | 2 + .../core/uverbs_std_types_comp_cntr.c | 168 +++++++++++++ .../infiniband/core/uverbs_std_types_device.c | 51 +++- drivers/infiniband/core/uverbs_std_types_qp.c | 67 ++++- drivers/infiniband/core/uverbs_uapi.c | 1 + drivers/infiniband/core/verbs.c | 8 + drivers/infiniband/hw/efa/efa.h | 20 +- .../infiniband/hw/efa/efa_admin_cmds_defs.h | 186 +++++++++++++- drivers/infiniband/hw/efa/efa_com_cmd.c | 136 ++++++++++ drivers/infiniband/hw/efa/efa_com_cmd.h | 45 ++++ drivers/infiniband/hw/efa/efa_io_defs.h | 20 +- drivers/infiniband/hw/efa/efa_main.c | 8 +- drivers/infiniband/hw/efa/efa_verbs.c | 237 ++++++++++++++++++ include/rdma/ib_verbs.h | 50 ++++ include/rdma/restrack.h | 4 + include/uapi/rdma/efa-abi.h | 6 + include/uapi/rdma/ib_user_ioctl_cmds.h | 43 ++++ include/uapi/rdma/ib_user_ioctl_verbs.h | 19 ++ 22 files changed, 1080 insertions(+), 8 deletions(-) create mode 100644 drivers/infiniband/core/uverbs_std_types_comp_cntr.c
Signature · 1 line
2.47.3
PATCH v9 1/6 RDMA/core: Add Completion Counters support
Add core infrastructure for Completion Counters, a light-weight alternative to polling CQ for tracking operation completions.
Define the UVERBS_OBJECT_COMP_CNTR ioctl object with create, destroy, modify and read methods for both success and error counters. Add a QP attach method on the QP object to associate a completion counter with a queue pair.
Add ib_comp_cntr struct, ib_comp_cntr_attach_attr, device ops, and DECLARE_RDMA_OBJ_SIZE for driver object allocation.
Only userspace Completion Counters are supported at this stage.
--- drivers/infiniband/core/Makefile | 1 + drivers/infiniband/core/device.c | 6 + drivers/infiniband/core/rdma_core.h | 1 + .../core/uverbs_std_types_comp_cntr.c | 159 ++++++++++++++++++ drivers/infiniband/core/uverbs_std_types_qp.c | 51 +++++- drivers/infiniband/core/uverbs_uapi.c | 1 + include/rdma/ib_verbs.h | 37 ++++ include/uapi/rdma/ib_user_ioctl_cmds.h | 36 ++++ include/uapi/rdma/ib_user_ioctl_verbs.h | 19 +++ 9 files changed, 310 insertions(+), 1 deletion(-) create mode 100644 drivers/infiniband/core/uverbs_std_types_comp_cntr.c
drivers/infiniband/core/Makefile +1 -0
@@ -38,6 +38,7 @@ ib_umad-y := user_mad.o ib_uverbs-y := uverbs_main.o uverbs_cmd.o uverbs_marshall.o \ uverbs_std_types.o uverbs_ioctl.o \ uverbs_std_types_cq.o \ + uverbs_std_types_comp_cntr.o \ uverbs_std_types_dmabuf.o \ uverbs_std_types_dmah.o \ uverbs_std_types_flow_action.o uverbs_std_types_dm.o \
drivers/infiniband/core/device.c +6 -0
@@ -2742,6 +2742,7 @@ void ib_set_device_ops(struct ib_device *dev, const struct ib_device_ops *ops)SET_DEVICE_OP (dev_ops, create_ah);SET_DEVICE_OP (dev_ops, create_counters);SET_DEVICE_OP (dev_ops, create_cq); +SET_DEVICE_OP (dev_ops, create_comp_cntr);SET_DEVICE_OP (dev_ops, create_user_cq);SET_DEVICE_OP (dev_ops, create_flow);SET_DEVICE_OP (dev_ops, create_qp);
@@ -2762,6 +2763,7 @@ void ib_set_device_ops(struct ib_device *dev, const struct ib_device_ops *ops)SET_DEVICE_OP (dev_ops, destroy_ah);SET_DEVICE_OP (dev_ops, destroy_counters);SET_DEVICE_OP (dev_ops, destroy_cq); +SET_DEVICE_OP (dev_ops, destroy_comp_cntr);SET_DEVICE_OP (dev_ops, destroy_flow);SET_DEVICE_OP (dev_ops, destroy_flow_action);SET_DEVICE_OP (dev_ops, destroy_qp);
@@ -2813,6 +2815,7 @@ void ib_set_device_ops(struct ib_device *dev, const struct ib_device_ops *ops)SET_DEVICE_OP (dev_ops, modify_hw_stat);SET_DEVICE_OP (dev_ops, modify_port);SET_DEVICE_OP (dev_ops, modify_qp); +SET_DEVICE_OP (dev_ops, qp_attach_comp_cntr);SET_DEVICE_OP (dev_ops, modify_srq);SET_DEVICE_OP (dev_ops, modify_wq);SET_DEVICE_OP (dev_ops, peek_cq);
@@ -2836,12 +2839,14 @@ void ib_set_device_ops(struct ib_device *dev, const struct ib_device_ops *ops)SET_DEVICE_OP (dev_ops, query_ucontext);SET_DEVICE_OP (dev_ops, rdma_netdev_get_params);SET_DEVICE_OP (dev_ops, read_counters); +SET_DEVICE_OP (dev_ops, read_comp_cntr);SET_DEVICE_OP (dev_ops, reg_dm_mr);SET_DEVICE_OP (dev_ops, reg_user_mr);SET_DEVICE_OP (dev_ops, reg_user_mr_dmabuf);SET_DEVICE_OP (dev_ops, req_notify_cq);SET_DEVICE_OP (dev_ops, rereg_user_mr);SET_DEVICE_OP (dev_ops, resize_user_cq); +SET_DEVICE_OP (dev_ops, modify_comp_cntr);SET_DEVICE_OP (dev_ops, set_vf_guid);SET_DEVICE_OP (dev_ops, set_vf_link_state);SET_DEVICE_OP (dev_ops, ufile_hw_cleanup);
@@ -2850,6 +2855,7 @@ void ib_set_device_ops(struct ib_device *dev, const struct ib_device_ops *ops)SET_OBJ_SIZE (dev_ops, ib_ah);SET_OBJ_SIZE (dev_ops, ib_counters);SET_OBJ_SIZE (dev_ops, ib_cq); +SET_OBJ_SIZE (dev_ops, ib_comp_cntr);SET_OBJ_SIZE (dev_ops, ib_dmah);SET_OBJ_SIZE (dev_ops, ib_mw);SET_OBJ_SIZE (dev_ops, ib_pd);
drivers/infiniband/core/rdma_core.h +1 -0
@@ -159,6 +159,7 @@ void uverbs_user_mmap_disassociate(struct ib_uverbs_file *ufile);extern const struct uapi_definition uverbs_def_obj_async_fd[];extern const struct uapi_definition uverbs_def_obj_counters[]; +extern const struct uapi_definition uverbs_def_obj_comp_cntr[];extern const struct uapi_definition uverbs_def_obj_cq[];extern const struct uapi_definition uverbs_def_obj_device[];extern const struct uapi_definition uverbs_def_obj_dm[];
drivers/infiniband/core/uverbs_std_types_comp_cntr.c new file +159 -0
159 lines not on this page · raw message
drivers/infiniband/core/uverbs_std_types_qp.c +50 -1
61 lines not on this page · raw message
drivers/infiniband/core/uverbs_uapi.c +1 -0
@@ -628,6 +628,7 @@ void uverbs_destroy_api(struct uverbs_api *uapi)static const struct uapi_definition uverbs_core_api[] = {UAPI_DEF_CHAIN (uverbs_def_obj_async_fd),UAPI_DEF_CHAIN (uverbs_def_obj_counters), +UAPI_DEF_CHAIN (uverbs_def_obj_comp_cntr),UAPI_DEF_CHAIN (uverbs_def_obj_cq),UAPI_DEF_CHAIN (uverbs_def_obj_device),UAPI_DEF_CHAIN (uverbs_def_obj_dm),
include/rdma/ib_verbs.h +37 -0
@@ -1746,6 +1746,34 @@ struct ib_cq {struct rdma_restrack_entry res; }; +enum ib_qp_attach_comp_cntr_op { +IB_QP_ATTACH_COMP_CNTR_OP_SEND =IB_UVERBS_QP_ATTACH_COMP_CNTR_OP_SEND , +IB_QP_ATTACH_COMP_CNTR_OP_RECV =IB_UVERBS_QP_ATTACH_COMP_CNTR_OP_RECV , +IB_QP_ATTACH_COMP_CNTR_OP_RDMA_READ =IB_UVERBS_QP_ATTACH_COMP_CNTR_OP_RDMA_READ , +IB_QP_ATTACH_COMP_CNTR_OP_REMOTE_RDMA_READ =IB_UVERBS_QP_ATTACH_COMP_CNTR_OP_REMOTE_RDMA_READ , +IB_QP_ATTACH_COMP_CNTR_OP_RDMA_WRITE =IB_UVERBS_QP_ATTACH_COMP_CNTR_OP_RDMA_WRITE , +IB_QP_ATTACH_COMP_CNTR_OP_REMOTE_RDMA_WRITE =IB_UVERBS_QP_ATTACH_COMP_CNTR_OP_REMOTE_RDMA_WRITE , +}; + +struct ib_comp_cntr { +struct ib_device *device; +struct ib_uobject *uobject; +}; + +enum ib_comp_cntr_entry { +IB_COMP_CNTR_ENTRY_COMP =IB_UVERBS_COMP_CNTR_ENTRY_COMP , +IB_COMP_CNTR_ENTRY_ERR =IB_UVERBS_COMP_CNTR_ENTRY_ERR , +}; + +enum ib_comp_cntr_modify_op { +IB_COMP_CNTR_MODIFY_OP_SET =IB_UVERBS_COMP_CNTR_MODIFY_OP_SET , +IB_COMP_CNTR_MODIFY_OP_INC =IB_UVERBS_COMP_CNTR_MODIFY_OP_INC , +}; + +struct ib_qp_attach_comp_cntr_attr { +u32 op_mask;/* Bitmask of enum ib_qp_attach_comp_cntr_op */ +}; +struct ib_srq {struct ib_device *device;struct ib_pd *pd;
@@ -2629,6 +2657,8 @@ struct ib_device_ops { struct ib_udata *udata);int (*modify_qp)(struct ib_qp *qp,struct ib_qp_attr *qp_attr,int qp_attr_mask,struct ib_udata *udata); +int (*qp_attach_comp_cntr)(struct ib_qp *qp,struct ib_comp_cntr *cc, +struct ib_qp_attach_comp_cntr_attr *attr);int (*query_qp)(struct ib_qp *qp,struct ib_qp_attr *qp_attr,int qp_attr_mask,struct ib_qp_init_attr *qp_init_attr);int (*destroy_qp)(struct ib_qp *qp,struct ib_udata *udata);
@@ -2650,6 +2680,12 @@ struct ib_device_ops {* post_destroy_cq - Free all kernel resources */ void (*post_destroy_cq)(struct ib_cq *cq); +int (*create_comp_cntr)(struct ib_comp_cntr *cc, +struct uverbs_attr_bundle *attrs); +int (*destroy_comp_cntr)(struct ib_comp_cntr *cc); +int (*modify_comp_cntr)(struct ib_comp_cntr *cc,enum ib_comp_cntr_entry entry, +enum ib_comp_cntr_modify_op op,u64 value); +int (*read_comp_cntr)(struct ib_comp_cntr *cc,enum ib_comp_cntr_entry entry,u64 *value);struct ib_mr *(*get_dma_mr)(struct ib_pd *pd,int mr_access_flags); struct ib_mr *(*reg_user_mr)(struct ib_pd *pd, u64 start, u64 length, u64 virt_addr, int mr_access_flags,
@@ -2883,6 +2919,7 @@ struct ib_device_ops {DECLARE_RDMA_OBJ_SIZE (ib_ah);DECLARE_RDMA_OBJ_SIZE (ib_counters);DECLARE_RDMA_OBJ_SIZE (ib_cq); +DECLARE_RDMA_OBJ_SIZE (ib_comp_cntr);DECLARE_RDMA_OBJ_SIZE (ib_dmah);DECLARE_RDMA_OBJ_SIZE (ib_mw);DECLARE_RDMA_OBJ_SIZE (ib_pd);
include/uapi/rdma/ib_user_ioctl_cmds.h +36 -0
@@ -57,6 +57,7 @@ enum uverbs_default_objects {UVERBS_OBJECT_ASYNC_EVENT ,UVERBS_OBJECT_DMAH ,UVERBS_OBJECT_DMABUF , + UVERBS_OBJECT_COMP_CNTR, }; enum {
@@ -169,9 +170,16 @@ enum uverbs_attrs_destroy_qp_cmd_attr_ids { UVERBS_ATTR_DESTROY_QP_RESP, }; +enum uverbs_attrs_qp_attach_comp_cntr_cmd_attr_ids { +UVERBS_ATTR_QP_ATTACH_COMP_CNTR_HANDLE , +UVERBS_ATTR_QP_ATTACH_COMP_CNTR_CNTR_HANDLE , +UVERBS_ATTR_QP_ATTACH_COMP_CNTR_OP_MASK , +}; +enum uverbs_methods_qp {UVERBS_METHOD_QP_CREATE ,UVERBS_METHOD_QP_DESTROY , +UVERBS_METHOD_QP_ATTACH_COMP_CNTR , };enum uverbs_attrs_create_srq_cmd_attr_ids {
@@ -438,4 +446,32 @@ enum uverbs_attrs_query_gid_entry_cmd_attr_ids { UVERBS_ATTR_QUERY_GID_ENTRY_RESP_ENTRY, }; +enum uverbs_methods_comp_cntr { +UVERBS_METHOD_COMP_CNTR_CREATE , +UVERBS_METHOD_COMP_CNTR_DESTROY , +UVERBS_METHOD_COMP_CNTR_MODIFY , +UVERBS_METHOD_COMP_CNTR_READ , +}; + +enum uverbs_attrs_create_comp_cntr_cmd_attr_ids { +UVERBS_ATTR_CREATE_COMP_CNTR_HANDLE , +}; + +enum uverbs_attrs_destroy_comp_cntr_cmd_attr_ids { +UVERBS_ATTR_DESTROY_COMP_CNTR_HANDLE , +}; + +enum uverbs_attrs_modify_comp_cntr_cmd_attr_ids { +UVERBS_ATTR_MODIFY_COMP_CNTR_HANDLE , +UVERBS_ATTR_MODIFY_COMP_CNTR_ENTRY , +UVERBS_ATTR_MODIFY_COMP_CNTR_OP , +UVERBS_ATTR_MODIFY_COMP_CNTR_VALUE , +}; + +enum uverbs_attrs_read_comp_cntr_cmd_attr_ids { +UVERBS_ATTR_READ_COMP_CNTR_HANDLE , +UVERBS_ATTR_READ_COMP_CNTR_ENTRY , +UVERBS_ATTR_READ_COMP_CNTR_RESP_VALUE , +}; +#endif
include/uapi/rdma/ib_user_ioctl_verbs.h +19 -0
@@ -300,4 +300,23 @@ struct ib_uverbs_buffer_desc { __aligned_u64 length; }; +enum ib_uverbs_comp_cntr_entry { +IB_UVERBS_COMP_CNTR_ENTRY_COMP , +IB_UVERBS_COMP_CNTR_ENTRY_ERR , +}; + +enum ib_uverbs_comp_cntr_modify_op { +IB_UVERBS_COMP_CNTR_MODIFY_OP_SET , +IB_UVERBS_COMP_CNTR_MODIFY_OP_INC , +}; + +enum ib_uverbs_qp_attach_comp_cntr_op { +IB_UVERBS_QP_ATTACH_COMP_CNTR_OP_SEND =1 <<0 , +IB_UVERBS_QP_ATTACH_COMP_CNTR_OP_RECV =1 <<1 , +IB_UVERBS_QP_ATTACH_COMP_CNTR_OP_RDMA_READ =1 <<2 , +IB_UVERBS_QP_ATTACH_COMP_CNTR_OP_REMOTE_RDMA_READ =1 <<3 , +IB_UVERBS_QP_ATTACH_COMP_CNTR_OP_RDMA_WRITE =1 <<4 , +IB_UVERBS_QP_ATTACH_COMP_CNTR_OP_REMOTE_RDMA_WRITE =1 <<5 , +}; +#endif
Signature · 1 line
2.47.3