Skip to content

leds: Add powerdown gpio for is31fl32xx

Jun Yan linux-devicetree linux-leds lkml 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest6 patches 3 repliesIn review
  2. v76 patches 5 repliesSuperseded
  3. v66 patches 0 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v55 patches2 repliesSuperseded
v45 patches2 repliesSuperseded
v35 patches4 repliesSuperseded
v25 patches2 repliesSuperseded
v1 posting 2/25 patches1 replySuperseded
v1 posting 1/25 patches1 replySuperseded

Changes in v8 from the cover letter

- Fix code and commit message style issues noted by Lee Jones.
- https://lore.kernel.org/all/[email protected]

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6dt-bindings: leds: issi,is31fl32xx: convert the binding to yamlDocumentation/devicetree/bindings/leds/issi,is31fl32xx.yaml Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt+151 -530 replies
2/6dt-bindings: leds: issi,is31fl32xx: add support for is31fl3236aDocumentation/devicetree/bindings/leds/issi,is31fl32xx.yaml+24 -00 replies
3/6dt-bindings: leds: issi,is31fl32xx: Add powerdown-gpios propertyDocumentation/devicetree/bindings/leds/issi,is31fl32xx.yaml+12 -00 replies
4/6leds: is31fl32xx: Add powerdown pin for hardware shutdown modedrivers/leds/leds-is31fl32xx.c+14 -01 reply
5/6leds: is31fl32xx: Fix missing brightness_steps for is31fl3236drivers/leds/leds-is31fl32xx.c+1 -01 reply
6/6leds: is31fl32xx: Move pwm frequency setting to init_regs()drivers/leds/leds-is31fl32xx.c+9 -121 reply

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiRob Herring (Arm)
1/6R-b
2/6R-b
3/6R-b
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/6] leds: Add powerdown gpio for is31fl32xx

This patch series primarily adds the powerdown-gpios support for the IS31FL32xx controller.It also includes a fix and dt-bindings updates derived from previous attempts [1].

Patch 1 and patch 2 are based on a previous attempt [1]. The driver-related updates in patch 2 have already been merged.

Patch 3 and Patch 4 add support for the powerdown-gpios property, which corresponds to the SDB pin of the IS31FL32xx series chips. This pin is used to enter and exit the hardware powerdown mode.

Patch 5 fixes errors introduced by previous changes. It impacts the brightness control function of the IS31FL3236.

Patch 6 resolves regression caused by prior changes, and fixes the 22kHz PWM output functionality for IS31FL3236A.

[1] https://lore.kernel.org/all/[email protected]/

Changes in v8:
- Fix code and commit message style issues noted by Lee Jones.
- https://lore.kernel.org/all/[email protected]

Changes in v7:
- Fix code style (spaces/tabs) and commit messages per checkpatch.pl outputs
- Link to v6: https://lore.kernel.org/all/[email protected]/

Changes in v6:
- Add fix for 22kHz PWM output regression on IS31FL3236A
- Correct typo in vendor prefix for Integrated Silicon Solution
- Restore hardware shutdown state upon driver removal
- Link to v5: https://lore.kernel.org/all/[email protected]/

Changes in v5:
- Adjust the unit-address in dt-binding to hex addresses, and remove unnecessary if/then constraints.
- Link to v4: https://lore.kernel.org/all/[email protected]/

Changes in v4:
- Fixed compilation build errors due to missing header files
- Link to v3: https://lore.kernel.org/all/[email protected]/

Changes in v3:
- Replace shutdown-gpios with powerdown-gpios, follow gpio-consumer-common binding.
- Link to v2: https://lore.kernel.org/all/[email protected]/

Changes in v2:
- Fix $id mismatch with file name in dt-binding.
- Link to v1: https://lore.kernel.org/all/[email protected]/

Jun Yan (6):
dt-bindings: leds: issi,is31fl32xx: convert the binding to yaml
dt-bindings: leds: issi,is31fl32xx: add support for is31fl3236a
dt-bindings: leds: issi,is31fl32xx: Add powerdown-gpios property
leds: is31fl32xx: Add powerdown pin for hardware shutdown mode
leds: is31fl32xx: Fix missing brightness_steps for is31fl3236
leds: is31fl32xx: Move pwm frequency setting to init_regs()

 .../bindings/leds/issi,is31fl32xx.yaml        | 187 ++++++++++++++++++
 .../bindings/leds/leds-is31fl32xx.txt         |  53 -----
 drivers/leds/leds-is31fl32xx.c                |  34 ++--
 3 files changed, 210 insertions(+), 64 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml
 delete mode 100644 Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt
Signature · 1 line
2.54.0