Skip to content

RFC target/tcg: Rename some helpers common to various targets

Philippe Mathieu-Daudé qemu-arm qemu-devel qemu-riscv 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 RFC Latest4 patches 2 repliesIn review

Changes in v2 from the cover letter

- rebased on b0df6e2f2c6c45df8d4d286933799c623e124d98 (Merge tag 'pull-riscv-to-apply-20260616')

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4target/tcg: Rename bitswap() helperstarget/loongarch/tcg/helper.h target/loongarch/tcg/insn_trans/trans_bit.c.inc target/loongarch/tcg/op_helper.c +3 more+7 -70 replies
2/4target/tcg: Rename crc32*() helperstarget/arm/tcg/arith_helper.c target/arm/tcg/helper-defs.h target/arm/tcg/translate.c +9 more+27 -270 replies
3/4target/tcg: Rename raise_exception() helperstarget/hexagon/gen_tcg.h target/hexagon/helper.h target/hexagon/op_helper.c +16 more+23 -230 replies
4/4target/tcg: Rename set_rounding_mode() helperstarget/loongarch/tcg/fpu_helper.c target/loongarch/tcg/helper.h target/loongarch/tcg/insn_trans/trans_fmov.c.inc +3 more+6 -62 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchBrian CainPierrick BouvierDaniel Henrique BarbozaAlistair Francis
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [RFC PATCH v2 0/4] target/tcg: Rename some helpers common to various targets

TCG helpers are declared using the DEF_HELPER*() macros which imply global symbol scope. Unfortunately when building a single binary (containing multiple TCG 'target' frontends) these symbols clash.

This series takes the dumbest approach, renaming the symbols.

There are still around 20 symbol clashes (usually FPU helpers), but this series is good for my proof-of-concept.

Since v1:
- rebased on b0df6e2f2c6c45df8d4d286933799c623e124d98 (Merge tag 'pull-riscv-to-apply-20260616')

Philippe Mathieu-Daudé (4):
target/tcg: Rename bitswap() helpers
target/tcg: Rename crc32*() helpers
target/tcg: Rename raise_exception() helpers
target/tcg: Rename set_rounding_mode() helpers

 target/arm/tcg/helper-defs.h                     |  4 ++--
 target/hexagon/gen_tcg.h                         |  2 +-
 target/hexagon/helper.h                          |  2 +-
 target/i386/helper.h                             |  2 +-
 target/i386/ops_sse.h                            |  2 +-
 target/loongarch/tcg/helper.h                    |  8 ++++----
 target/m68k/helper.h                             |  2 +-
 target/microblaze/helper.h                       |  2 +-
 target/mips/helper.h                             |  6 +++---
 target/ppc/helper.h                              |  2 +-
 target/riscv/helper.h                            |  2 +-
 target/sparc/helper.h                            |  2 +-
 target/i386/tcg/ops_sse_header.h.inc             |  2 +-
 target/arm/tcg/arith_helper.c                    |  4 ++--
 target/arm/tcg/translate.c                       |  4 ++--
 target/hexagon/op_helper.c                       |  2 +-
 target/hexagon/translate.c                       |  2 +-
 target/i386/tcg/excp_helper.c                    |  2 +-
 target/i386/tcg/translate.c                      |  2 +-
 target/loongarch/tcg/fpu_helper.c                |  2 +-
 target/loongarch/tcg/op_helper.c                 |  6 +++---
 target/m68k/op_helper.c                          |  2 +-
 target/m68k/translate.c                          |  2 +-
 target/microblaze/op_helper.c                    |  2 +-
 target/microblaze/translate.c                    |  2 +-
 target/mips/tcg/op_helper.c                      |  6 +++---
 target/mips/tcg/translate.c                      |  6 +++---
 target/ppc/tcg-excp_helper.c                     |  2 +-
 target/ppc/translate.c                           |  6 +++---
 target/riscv/fpu_helper.c                        |  2 +-
 target/riscv/translate.c                         |  2 +-
 target/sparc/helper.c                            |  2 +-
 target/sparc/translate.c                         |  6 +++---
 target/i386/tcg/emit.c.inc                       |  2 +-
 target/loongarch/tcg/insn_trans/trans_bit.c.inc  |  4 ++--
 .../loongarch/tcg/insn_trans/trans_extra.c.inc   | 16 ++++++++--------
 target/loongarch/tcg/insn_trans/trans_fmov.c.inc |  2 +-
 37 files changed, 63 insertions(+), 63 deletions(-)
Signature · 1 line
2.53.0