Skip to content

crypto: use timing-safe digest comparison

Stephen Hemminger dpdk-dev 2 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 3 repliesApplied
  2. v15 patches 3 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6eal: take experimental flag off of rte_memeq_timingsafedoc/guides/rel_notes/release_26_07.rst lib/eal/include/rte_memory.h+4 -40 replies
2/6crypto/uadk: use timing-safe digest comparisondrivers/crypto/uadk/uadk_crypto_pmd.c+2 -20 replies
3/6crypto/ccp: use timing-safe digest comparisondrivers/crypto/ccp/ccp_crypto.c+4 -40 replies
4/6crypto/armv8: use timing-safe digest comparisondrivers/crypto/armv8/rte_armv8_pmd.c+2 -20 replies
5/6crypto/cnxk: use timing-safe digest comparisondrivers/crypto/cnxk/cnxk_ae.h drivers/crypto/cnxk/cnxk_se.h+4 -20 replies
6/6crypto/octeontx: use timing-safe RSA signature verificationdrivers/crypto/octeontx/otx_cryptodev_ops.c+2 -11 reply

Reviews trailers per patch

3 of 6 patches have a Reviewed-by or Acked-by.

PatchJack Bond-PrestonTejasree KondojMorten Brørup
SeriesSeries-acked-by
1/6
2/6
3/6
4/6A-b
5/6A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/6] crypto: use timing-safe digest comparison

Timing attacks in DPDK crypto were fixed earlier but several drivers did not use the new timing safe comparison operation.

First patch drops the experimental flag off rte_memeq_timingsafe(). The function is a static inline with no exported symbol, no ABI change. This avoids having to turn on experimental flag in other drivers.

The rest convert the digest verify comparisons in the uadk, ccp, armv8 and cnxk PMDs.

This problem was reported for several drivers and for those the Reported-by was added.

v2 - pick up a couple of other memcmp() locations

Stephen Hemminger (6):
eal: take experimental flag off of rte_memeq_timingsafe crypto/uadk: use timing-safe digest comparison crypto/ccp: use timing-safe digest comparison crypto/armv8: use timing-safe digest comparison crypto/cnxk: use timing-safe digest comparison crypto/octeontx: use timing-safe RSA signature verification

 doc/guides/rel_notes/release_26_07.rst      | 4 ++++
 drivers/crypto/armv8/rte_armv8_pmd.c        | 4 ++--
 drivers/crypto/ccp/ccp_crypto.c             | 8 ++++----
 drivers/crypto/cnxk/cnxk_ae.h               | 4 +++-
 drivers/crypto/cnxk/cnxk_se.h               | 2 +-
 drivers/crypto/octeontx/otx_cryptodev_ops.c | 3 ++-
 drivers/crypto/uadk/uadk_crypto_pmd.c       | 4 ++--
 lib/eal/include/rte_memory.h                | 4 ----
 8 files changed, 18 insertions(+), 15 deletions(-)
Signature · 1 line
2.53.0