Skip to content

tests/qtest: aspeed_smc: Add fast-read variant test coverage

Cédric Le Goater qemu-arm qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 3 repliesIn review
  2. v14 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Introduced spi_ctrl_set_fast_read() helper, replacing open-coded ctrl register setup in read_page_mem_fast_read/dor/qor()
- Replaced MIT license boilerplate with SPDX-License-Identifier
- Collected Reviewed-by: Bin Meng on patches 1 and 3

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4tests/qtest: aspeed_smc: Introduce read_page_mem_fn for page read helperstests/qtest/aspeed-smc-utils.c+21 -80 replies
2/4tests/qtest: aspeed_smc: Add fast-read test coveragetests/qtest/aspeed-smc-utils.c tests/qtest/aspeed-smc-utils.h tests/qtest/aspeed_smc-test.c +1 more+90 -511 reply
3/4tests/qtest: aspeed_smc: Add Dual Output Read (DOR) test coveragetests/qtest/aspeed-smc-utils.c tests/qtest/aspeed-smc-utils.h tests/qtest/aspeed_smc-test.c +1 more+69 -00 replies
4/4tests/qtest: aspeed_smc: Add Quad Output Read (QOR) test coveragetests/qtest/aspeed-smc-utils.c tests/qtest/aspeed-smc-utils.h tests/qtest/aspeed_smc-test.c +1 more+67 -01 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchBin Meng
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] tests/qtest: aspeed_smc: Add fast-read variant test coverage

Hello,

This series extends the Aspeed SMC qtest suite with coverage for fast-read and multi-IO read commands :
- Fast Read (single IO with dummy byte)
- Dual Output Read (DOR, dual data IO)
- Quad Output Read (QOR, quad data IO)

Each patch tests both the memory-mapped CTRL_FREADMODE path and the user-mode command path, to exercise the dummy cycle handling recently reworked in the m25p80 flash model.

Thanks,

C.

Changes in v2:

- Introduced spi_ctrl_set_fast_read() helper, replacing open-coded ctrl register setup in read_page_mem_fast_read/dor/qor()
- Replaced MIT license boilerplate with SPDX-License-Identifier
- Collected Reviewed-by: Bin Meng on patches 1 and 3

Cédric Le Goater (4):
tests/qtest: aspeed_smc: Introduce read_page_mem_fn for page read
helpers
tests/qtest: aspeed_smc: Add fast-read test coverage tests/qtest: aspeed_smc: Add Dual Output Read (DOR) test coverage tests/qtest: aspeed_smc: Add Quad Output Read (QOR) test coverage

 tests/qtest/aspeed-smc-utils.h |  31 +++---
 tests/qtest/aspeed-smc-utils.c | 192 ++++++++++++++++++++++++++++-----
 tests/qtest/aspeed_smc-test.c  |  71 +++++++++---
 tests/qtest/ast2700-smc-test.c |  12 +++
 4 files changed, 247 insertions(+), 59 deletions(-)
Signature · 1 line
2.54.0