tests/qtest: aspeed_smc: Add fast-read variant test coverage
cover tests/qtest: aspeed_smc: Add fast-read variant test coverage
Hello,
This series extends the Aspeed SMC qtest suite with coverage for fast-read and multi-IO read commands :
- Fast Read (single IO with dummy byte)
- Dual Output Read (DOR, dual data IO)
- Quad Output Read (QOR, quad data IO)
Each patch tests both the memory-mapped CTRL_FREADMODE path and the user-mode command path, to exercise the dummy cycle handling recently reworked in the m25p80 flash model.
Thanks,
C.
Cédric Le Goater (4):
tests/qtest: aspeed_smc: Introduce read_page_mem_fn for page read
helpers
tests/qtest: aspeed_smc: Add fast-read test coverage tests/qtest: aspeed_smc: Add Dual Output Read (DOR) test coverage tests/qtest: aspeed_smc: Add Quad Output Read (QOR) test coverage
tests/qtest/aspeed-smc-utils.h | 13 +++ tests/qtest/aspeed-smc-utils.c | 178 +++++++++++++++++++++++++++++++-- tests/qtest/aspeed_smc-test.c | 53 ++++++++++ tests/qtest/ast2700-smc-test.c | 12 +++ 4 files changed, 248 insertions(+), 8 deletions(-)
Signature · 1 line
2.54.0
PATCH 1/4 tests/qtest: aspeed_smc: Introduce read_page_mem_fn for page read helpers
This to prepare for fast-read variants. No functional change.
--- tests/qtest/aspeed-smc-utils.c | 29 +++++++++++++++++++++-------- 1 file changed, 21 insertions(+), 8 deletions(-)
tests/qtest/aspeed-smc-utils.c +21 -8
@@ -186,6 +186,9 @@ static void read_page_mem(const AspeedSMCTestData *data, uint32_t addr, } } +typedef void (*read_page_mem_fn )(const AspeedSMCTestData *data, +uint32_t addr,uint32_t *page); +static void write_page_mem (const AspeedSMCTestData *data,uint32_t addr,uint32_t write_value) {
@@ -327,9 +330,9 @@ void aspeed_smc_test_erase_all(const void *data)flash_reset (test_data); } -void aspeed_smc_test_write_page (const void *data) +static void test_write_page (const AspeedSMCTestData *test_data, +read_page_mem_fn reader) { -const AspeedSMCTestData *test_data = (const AspeedSMCTestData *)data;uint32_t my_page_addr = test_data->page_addr;uint32_t some_page_addr = my_page_addr +FLASH_PAGE_SIZE ;uint32_t page[FLASH_PAGE_SIZE /4 ];
@@ -350,13 +353,13 @@ void aspeed_smc_test_write_page(const void *data)spi_ctrl_stop_user (test_data);/* Check what was written */ -read_page (test_data, my_page_addr, page); +reader (test_data, my_page_addr, page);for (i =0 ; i <FLASH_PAGE_SIZE /4 ; i++) { g_assert_cmphex(page[i], ==, my_page_addr + i * 4); }/* Check some other page. It should be full of 0xff */ -read_page (test_data, some_page_addr, page); +reader (test_data, some_page_addr, page);for (i =0 ; i <FLASH_PAGE_SIZE /4 ; i++) { g_assert_cmphex(page[i], ==, 0xffffffff); }
@@ -364,9 +367,14 @@ void aspeed_smc_test_write_page(const void *data)flash_reset (test_data); } -void aspeed_smc_test_read_page_mem (const void *data) +void aspeed_smc_test_write_page (const void *data) +{ +test_write_page (data, read_page); +} + +static void test_read_page_mem (const AspeedSMCTestData *test_data, +read_page_mem_fn reader) { -const AspeedSMCTestData *test_data = (const AspeedSMCTestData *)data;uint32_t my_page_addr = test_data->page_addr;uint32_t some_page_addr = my_page_addr +FLASH_PAGE_SIZE ;uint32_t page[FLASH_PAGE_SIZE /4 ];
@@ -393,13 +401,13 @@ void aspeed_smc_test_read_page_mem(const void *data)spi_conf_remove (test_data,1 << (CONF_ENABLE_W0 + test_data->cs));/* Check what was written */ -read_page_mem (test_data, my_page_addr, page); +reader (test_data, my_page_addr, page);for (i =0 ; i <FLASH_PAGE_SIZE /4 ; i++) { g_assert_cmphex(page[i], ==, my_page_addr + i * 4); }/* Check some other page. It should be full of 0xff */ -read_page_mem (test_data, some_page_addr, page); +reader (test_data, some_page_addr, page);for (i =0 ; i <FLASH_PAGE_SIZE /4 ; i++) { g_assert_cmphex(page[i], ==, 0xffffffff); }
@@ -407,6 +415,11 @@ void aspeed_smc_test_read_page_mem(const void *data)flash_reset (test_data); } +void aspeed_smc_test_read_page_mem (const void *data) +{ +test_read_page_mem (data, read_page_mem); +} +void aspeed_smc_test_write_page_mem (const void *data) {const AspeedSMCTestData *test_data = (const AspeedSMCTestData *)data;
Signature · 1 line
2.54.0
Re: [PATCH 1/4] tests/qtest: aspeed_smc: Introduce read_page_mem_fn for page read helpers
Quoted 8 lines · Cédric Le Goater
This to prepare for fast-read variants. No functional change.
Signed-off-by Cedric Le Goater <[email protected]>--- tests/qtest/aspeed-smc-utils.c | 29 +++++++++++++++++++++-------- 1 file changed, 21 insertions(+), 8 deletions(-)
PATCH 2/4 tests/qtest: aspeed_smc: Add fast-read test coverage
In reply to Cédric Le GoaterAdd read_page_mem_fast_read (CTRL_FREADMODE with dummy byte) and write_page_fast_read (user-mode FAST_READ) tests.
--- tests/qtest/aspeed-smc-utils.h | 5 ++++ tests/qtest/aspeed-smc-utils.c | 49 ++++++++++++++++++++++++++++++++++ tests/qtest/aspeed_smc-test.c | 21 +++++++++++++++ tests/qtest/ast2700-smc-test.c | 4 +++ 4 files changed, 79 insertions(+)
tests/qtest/aspeed-smc-utils.h +5 -0
@@ -44,6 +44,8 @@#define CTRL_FREADMODE 0x1#define CTRL_WRITEMODE 0x2#define CTRL_USERMODE 0x3 +#define CTRL_DUMMY_LOW_SHIFT 6 +#define CTRL_DUMMY_HIGH_SHIFT 14#define SR_WEL BIT(1)/*
@@ -55,6 +57,7 @@ enum {WRDI =0x4 ,BULK_ERASE =0xc7 ,READ =0x03 , +FAST_READ =0x0b ,PP =0x02 ,WRSR =0x1 , WREN = 0x6,
@@ -90,5 +93,7 @@ void aspeed_smc_test_status_reg_write_protection(const void *data);void aspeed_smc_test_write_block_protect (const void *data);void aspeed_smc_test_write_block_protect_bottom_bit (const void *data);void aspeed_smc_test_write_page_qpi (const void *data); +void aspeed_smc_test_read_page_mem_fast_read (const void *data); +void aspeed_smc_test_write_page_fast_read (const void *data);#endif /* TESTS_ASPEED_SMC_UTILS_H */
tests/qtest/aspeed-smc-utils.c +49 -0
52 lines not on this page · raw message
tests/qtest/aspeed_smc-test.c +21 -0
@@ -68,6 +68,15 @@ static void test_palmetto_bmc(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast2400/smc/status_reg_write_protection" , data, aspeed_smc_test_status_reg_write_protection); +qtest_add_data_func ("/ast2400/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast2400/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); +/* +* Block protect tests must be run last because the block protect +* state is not cleared by reset_memory() and silently prevents +* subsequent flash writes. +*/ qtest_add_data_func ("/ast2400/smc/write_block_protect" , data, aspeed_smc_test_write_block_protect); qtest_add_data_func("/ast2400/smc/write_block_protect_bottom_bit",
@@ -115,6 +124,10 @@ static void test_ast2500_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast2500/smc/write_page_qpi" , data, aspeed_smc_test_write_page_qpi); +qtest_add_data_func ("/ast2500/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast2500/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); }static void test_ast2600_evb (AspeedSMCTestData *data)
@@ -158,6 +171,10 @@ static void test_ast2600_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast2600/smc/write_page_qpi" , data, aspeed_smc_test_write_page_qpi); +qtest_add_data_func ("/ast2600/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast2600/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); }static void test_ast1030_evb (AspeedSMCTestData *data)
@@ -201,6 +218,10 @@ static void test_ast1030_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast1030/smc/write_page_qpi" , data, aspeed_smc_test_write_page_qpi); +qtest_add_data_func ("/ast1030/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast1030/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); }int main (int argc,char **argv)
tests/qtest/ast2700-smc-test.c +4 -0
@@ -52,6 +52,10 @@ static void test_ast2700_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast2700/smc/write_page_qpi" , data, aspeed_smc_test_write_page_qpi); +qtest_add_data_func ("/ast2700/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast2700/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); }int main (int argc,char **argv)
Signature · 1 line
2.54.0
Re: [PATCH 2/4] tests/qtest: aspeed_smc: Add fast-read test coverage
Quoted 54 lines · Cédric Le Goater
Add
read_page_mem_fast_read(CTRL_FREADMODEwith dummy byte) andwrite_page_fast_read(user-modeFAST_READ) tests.Signed-off-by Cedric Le Goater <[email protected]>--- tests/qtest/aspeed-smc-utils.h | 5 ++++ tests/qtest/aspeed-smc-utils.c | 49 ++++++++++++++++++++++++++++++++++ tests/qtest/aspeed_smc-test.c | 21 +++++++++++++++ tests/qtest/ast2700-smc-test.c | 4 +++ 4 files changed, 79 insertions(+)tests/qtest/aspeed-smc-utils.h +5
-0@@ -44,6 +44,8 @@#define CTRL_FREADMODE 0x1#define CTRL_WRITEMODE 0x2#define CTRL_USERMODE 0x3 +#define CTRL_DUMMY_LOW_SHIFT 6 +#define CTRL_DUMMY_HIGH_SHIFT 14#define SR_WEL BIT(1)/* @@ -55,6 +57,7 @@ enum {WRDI =0x4 ,BULK_ERASE =0xc7 ,READ =0x03 , +FAST_READ =0x0b ,PP =0x02 ,WRSR =0x1 , WREN = 0x6,@@ -90,5 +93,7 @@ void aspeed_smc_test_status_reg_write_protection(const void *data);void aspeed_smc_test_write_block_protect (const void *data);void aspeed_smc_test_write_block_protect_bottom_bit (const void *data);void aspeed_smc_test_write_page_qpi (const void *data); +void aspeed_smc_test_read_page_mem_fast_read (const void *data); +void aspeed_smc_test_write_page_fast_read (const void *data);#endif /* TESTS_ASPEED_SMC_UTILS_H */ tests/qtest/aspeed-smc-utils.c +5
-0@@ -697,3 +697,52 @@ void aspeed_smc_test_write_page_qpi(const void *data)flash_reset (test_data); } +static void read_page_mem_fast_read (const AspeedSMCTestData *data, +uint32_t addr,uint32_t *page) +{ +uint32_t ctrl_reg =R_CTRL0 + data->cs *4 ; +uint32_t ctrl =spi_readl (data, ctrl_reg);
tests/qtest/aspeed-smc-utils.c void aspeed_smc_test_write_page_qpi(const void *data) · line 714
Quoted 10 lines
tests/qtest/aspeed-smc-utils.c +10
-0+int i; + +/* Set FREADMODE with FAST_READ command and 1 dummy byte */ + ctrl &= ~(CTRL_USERMODE | (0xff <<16 ) | + (0x3 <<CTRL_DUMMY_LOW_SHIFT ) | + (0x1 <<CTRL_DUMMY_HIGH_SHIFT ) | +CTRL_IO_MODE_MASK ); + ctrl |=CTRL_FREADMODE | (FAST_READ <<16 ) | + (1 <<CTRL_DUMMY_LOW_SHIFT ); +spi_writel (data, ctrl_reg, ctrl);
Could just call spi_ctrl_set_fast_read()?
Quoted 92 lines
tests/qtest/aspeed-smc-utils.c +34
-0+ +for (i =0 ; i <FLASH_PAGE_SIZE /4 ; i++) { + page[i] =make_be32 (flash_readl (data, addr + i *4 )); + } +} + +void aspeed_smc_test_read_page_mem_fast_read (const void *data) +{ +test_read_page_mem (data, read_page_mem_fast_read); +} + +static void read_page_fast_read (const AspeedSMCTestData *data, +uint32_t addr,uint32_t *page) +{ +int i; + +spi_ctrl_start_user (data); + +flash_writeb (data,0 ,EN_4BYTE_ADDR ); +flash_writeb (data,0 ,FAST_READ ); +flash_writel (data,0 ,make_be32 (addr)); +/* 1 dummy byte for standard SPI fast-read */ +flash_writeb (data,0 ,0x00 ); + +for (i =0 ; i <FLASH_PAGE_SIZE /4 ; i++) { + page[i] =make_be32 (flash_readl (data,0 )); + } +spi_ctrl_stop_user (data); +} + +void aspeed_smc_test_write_page_fast_read (const void *data) +{ +test_write_page (data, read_page_fast_read); +}tests/qtest/aspeed_smc-test.c +21
-0@@ -68,6 +68,15 @@ static void test_palmetto_bmc(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast2400/smc/status_reg_write_protection" , data, aspeed_smc_test_status_reg_write_protection); +qtest_add_data_func ("/ast2400/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast2400/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); +/* +* Block protect tests must be run last because the block protect +* state is not cleared by reset_memory() and silently prevents +* subsequent flash writes. +*/ qtest_add_data_func ("/ast2400/smc/write_block_protect" , data, aspeed_smc_test_write_block_protect); qtest_add_data_func("/ast2400/smc/write_block_protect_bottom_bit",@@ -115,6 +124,10 @@ static void test_ast2500_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast2500/smc/write_page_qpi" , data, aspeed_smc_test_write_page_qpi); +qtest_add_data_func ("/ast2500/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast2500/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); }static void test_ast2600_evb (AspeedSMCTestData *data)@@ -158,6 +171,10 @@ static void test_ast2600_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast2600/smc/write_page_qpi" , data, aspeed_smc_test_write_page_qpi); +qtest_add_data_func ("/ast2600/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast2600/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); }static void test_ast1030_evb (AspeedSMCTestData *data)@@ -201,6 +218,10 @@ static void test_ast1030_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast1030/smc/write_page_qpi" , data, aspeed_smc_test_write_page_qpi); +qtest_add_data_func ("/ast1030/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast1030/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); }int main (int argc,char **argv)tests/qtest/ast2700-smc-test.c +0
-0
tests/qtest/ast2700-smc-test.c static void test_ast2700_evb(AspeedSMCTestData *data) · line 61
Quoted 10 lines
tests/qtest/ast2700-smc-test.c +4
-0@@ -52,6 +52,10 @@ static void test_ast2700_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast2700/smc/write_page_qpi" , data, aspeed_smc_test_write_page_qpi); +qtest_add_data_func ("/ast2700/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast2700/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); }int main (int argc,char **argv)
Regards,
Bin
Re: [PATCH 2/4] tests/qtest: aspeed_smc: Add fast-read test coverage
Quoted 59 lines · Bin Meng
Quoted 58 lines · Cédric Le Goater
Add
read_page_mem_fast_read(CTRL_FREADMODEwith dummy byte) andwrite_page_fast_read(user-modeFAST_READ) tests.Signed-off-by Cedric Le Goater <[email protected]>--- tests/qtest/aspeed-smc-utils.h | 5 ++++ tests/qtest/aspeed-smc-utils.c | 49 ++++++++++++++++++++++++++++++++++ tests/qtest/aspeed_smc-test.c | 21 +++++++++++++++ tests/qtest/ast2700-smc-test.c | 4 +++ 4 files changed, 79 insertions(+)tests/qtest/aspeed-smc-utils.h +5
-0@@ -44,6 +44,8 @@#define CTRL_FREADMODE 0x1#define CTRL_WRITEMODE 0x2#define CTRL_USERMODE 0x3 +#define CTRL_DUMMY_LOW_SHIFT 6 +#define CTRL_DUMMY_HIGH_SHIFT 14#define SR_WEL BIT(1)/* @@ -55,6 +57,7 @@ enum {WRDI =0x4 ,BULK_ERASE =0xc7 ,READ =0x03 , +FAST_READ =0x0b ,PP =0x02 ,WRSR =0x1 , WREN = 0x6,@@ -90,5 +93,7 @@ void aspeed_smc_test_status_reg_write_protection(const void *data);void aspeed_smc_test_write_block_protect (const void *data);void aspeed_smc_test_write_block_protect_bottom_bit (const void *data);void aspeed_smc_test_write_page_qpi (const void *data); +void aspeed_smc_test_read_page_mem_fast_read (const void *data); +void aspeed_smc_test_write_page_fast_read (const void *data);#endif /* TESTS_ASPEED_SMC_UTILS_H */ tests/qtest/aspeed-smc-utils.c +9
-0@@ -697,3 +697,52 @@ void aspeed_smc_test_write_page_qpi(const void *data)flash_reset (test_data); } +static void read_page_mem_fast_read (const AspeedSMCTestData *data, +uint32_t addr,uint32_t *page) +{ +uint32_t ctrl_reg =R_CTRL0 + data->cs *4 ; +uint32_t ctrl =spi_readl (data, ctrl_reg); +int i; + +/* Set FREADMODE with FAST_READ command and 1 dummy byte */ + ctrl &= ~(CTRL_USERMODE | (0xff << 16) |
Quoted 8 lines
tests/qtest/aspeed-smc-utils.c void aspeed_smc_test_write_page_qpi(const void *data) · line 714
Quoted 6 lines
tests/qtest/aspeed-smc-utils.c +6
-0+ (0x3 <<CTRL_DUMMY_LOW_SHIFT ) | + (0x1 <<CTRL_DUMMY_HIGH_SHIFT ) | + CTRL_IO_MODE_MASK); + ctrl |=CTRL_FREADMODE | (FAST_READ <<16 ) | + (1 <<CTRL_DUMMY_LOW_SHIFT ); +spi_writel (data, ctrl_reg, ctrl);Could just call
spi_ctrl_set_fast_read()?
Yeah. I could introduce a common helper if it's what you mean.
Thanks,
C.
Quoted 107 lines
Quoted 93 lines
tests/qtest/aspeed-smc-utils.c +34
-0+ +for (i =0 ; i <FLASH_PAGE_SIZE /4 ; i++) { + page[i] =make_be32 (flash_readl (data, addr + i *4 )); + } +} + +void aspeed_smc_test_read_page_mem_fast_read (const void *data) +{ +test_read_page_mem (data, read_page_mem_fast_read); +} + +static void read_page_fast_read (const AspeedSMCTestData *data, +uint32_t addr,uint32_t *page) +{ +int i; + +spi_ctrl_start_user (data); + +flash_writeb (data,0 ,EN_4BYTE_ADDR ); +flash_writeb (data,0 ,FAST_READ ); +flash_writel (data,0 ,make_be32 (addr)); +/* 1 dummy byte for standard SPI fast-read */ +flash_writeb (data,0 ,0x00 ); + +for (i =0 ; i <FLASH_PAGE_SIZE /4 ; i++) { + page[i] =make_be32 (flash_readl (data,0 )); + } +spi_ctrl_stop_user (data); +} + +void aspeed_smc_test_write_page_fast_read (const void *data) +{ +test_write_page (data, read_page_fast_read); +}tests/qtest/aspeed_smc-test.c +21
-0@@ -68,6 +68,15 @@ static void test_palmetto_bmc(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast2400/smc/status_reg_write_protection" , data, aspeed_smc_test_status_reg_write_protection); +qtest_add_data_func ("/ast2400/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast2400/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); +/* +* Block protect tests must be run last because the block protect +* state is not cleared by reset_memory() and silently prevents +* subsequent flash writes. +*/ qtest_add_data_func ("/ast2400/smc/write_block_protect" , data, aspeed_smc_test_write_block_protect); qtest_add_data_func("/ast2400/smc/write_block_protect_bottom_bit",@@ -115,6 +124,10 @@ static void test_ast2500_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast2500/smc/write_page_qpi" , data, aspeed_smc_test_write_page_qpi); +qtest_add_data_func ("/ast2500/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast2500/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); }static void test_ast2600_evb (AspeedSMCTestData *data)@@ -158,6 +171,10 @@ static void test_ast2600_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast2600/smc/write_page_qpi" , data, aspeed_smc_test_write_page_qpi); +qtest_add_data_func ("/ast2600/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast2600/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); }static void test_ast1030_evb (AspeedSMCTestData *data)@@ -201,6 +218,10 @@ static void test_ast1030_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast1030/smc/write_page_qpi" , data, aspeed_smc_test_write_page_qpi); +qtest_add_data_func ("/ast1030/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast1030/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); }int main (int argc,char **argv)tests/qtest/ast2700-smc-test.c +0
-0tests/qtest/ast2700-smc-test.c static void test_ast2700_evb(AspeedSMCTestData *data) · line 61
Quoted 10 lines
tests/qtest/ast2700-smc-test.c +4
-0@@ -52,6 +52,10 @@ static void test_ast2700_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg);qtest_add_data_func ("/ast2700/smc/write_page_qpi" , data, aspeed_smc_test_write_page_qpi); +qtest_add_data_func ("/ast2700/smc/read_page_mem_fast_read" , + data, aspeed_smc_test_read_page_mem_fast_read); +qtest_add_data_func ("/ast2700/smc/write_page_fast_read" , + data, aspeed_smc_test_write_page_fast_read); }int main (int argc,char **argv)Regards,
Bin
PATCH 3/4 tests/qtest: aspeed_smc: Add Dual Output Read (DOR) test coverage
In reply to Cédric Le GoaterAdd read_page_mem_dor (CTRL_FREADMODE with DOR command and dual data IO mode) and write_page_dor (user-mode DOR) tests.
--- tests/qtest/aspeed-smc-utils.h | 4 +++ tests/qtest/aspeed-smc-utils.c | 50 ++++++++++++++++++++++++++++++++++ tests/qtest/aspeed_smc-test.c | 16 +++++++++++ tests/qtest/ast2700-smc-test.c | 4 +++ 4 files changed, 74 insertions(+)
tests/qtest/aspeed-smc-utils.h +4 -0
@@ -44,6 +44,7 @@#define CTRL_FREADMODE 0x1#define CTRL_WRITEMODE 0x2#define CTRL_USERMODE 0x3 +#define CTRL_IO_DUAL_DATA BIT(29)#define CTRL_DUMMY_LOW_SHIFT 6#define CTRL_DUMMY_HIGH_SHIFT 14#define SR_WEL BIT(1)
@@ -58,6 +59,7 @@ enum {BULK_ERASE =0xc7 ,READ =0x03 ,FAST_READ =0x0b , +DOR =0x3b ,PP =0x02 ,WRSR =0x1 , WREN = 0x6,
@@ -95,5 +97,7 @@ void aspeed_smc_test_write_block_protect_bottom_bit(const void *data);void aspeed_smc_test_write_page_qpi (const void *data);void aspeed_smc_test_read_page_mem_fast_read (const void *data);void aspeed_smc_test_write_page_fast_read (const void *data); +void aspeed_smc_test_read_page_mem_dor (const void *data); +void aspeed_smc_test_write_page_dor (const void *data);#endif /* TESTS_ASPEED_SMC_UTILS_H */
tests/qtest/aspeed-smc-utils.c +50 -0
53 lines not on this page · raw message
tests/qtest/aspeed_smc-test.c +16 -0
@@ -72,6 +72,10 @@ static void test_palmetto_bmc(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_fast_read);qtest_add_data_func ("/ast2400/smc/write_page_fast_read" , data, aspeed_smc_test_write_page_fast_read); +qtest_add_data_func ("/ast2400/smc/read_page_mem_dor" , + data, aspeed_smc_test_read_page_mem_dor); +qtest_add_data_func ("/ast2400/smc/write_page_dor" , + data, aspeed_smc_test_write_page_dor);/* * Block protect tests must be run last because the block protect * state is not cleared by reset_memory() and silently prevents
@@ -128,6 +132,10 @@ static void test_ast2500_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_fast_read);qtest_add_data_func ("/ast2500/smc/write_page_fast_read" , data, aspeed_smc_test_write_page_fast_read); +qtest_add_data_func ("/ast2500/smc/read_page_mem_dor" , + data, aspeed_smc_test_read_page_mem_dor); +qtest_add_data_func ("/ast2500/smc/write_page_dor" , + data, aspeed_smc_test_write_page_dor); }static void test_ast2600_evb (AspeedSMCTestData *data)
@@ -175,6 +183,10 @@ static void test_ast2600_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_fast_read);qtest_add_data_func ("/ast2600/smc/write_page_fast_read" , data, aspeed_smc_test_write_page_fast_read); +qtest_add_data_func ("/ast2600/smc/read_page_mem_dor" , + data, aspeed_smc_test_read_page_mem_dor); +qtest_add_data_func ("/ast2600/smc/write_page_dor" , + data, aspeed_smc_test_write_page_dor); }static void test_ast1030_evb (AspeedSMCTestData *data)
@@ -222,6 +234,10 @@ static void test_ast1030_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_fast_read);qtest_add_data_func ("/ast1030/smc/write_page_fast_read" , data, aspeed_smc_test_write_page_fast_read); +qtest_add_data_func ("/ast1030/smc/read_page_mem_dor" , + data, aspeed_smc_test_read_page_mem_dor); +qtest_add_data_func ("/ast1030/smc/write_page_dor" , + data, aspeed_smc_test_write_page_dor); }int main (int argc,char **argv)
tests/qtest/ast2700-smc-test.c +4 -0
@@ -56,6 +56,10 @@ static void test_ast2700_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_fast_read);qtest_add_data_func ("/ast2700/smc/write_page_fast_read" , data, aspeed_smc_test_write_page_fast_read); +qtest_add_data_func ("/ast2700/smc/read_page_mem_dor" , + data, aspeed_smc_test_read_page_mem_dor); +qtest_add_data_func ("/ast2700/smc/write_page_dor" , + data, aspeed_smc_test_write_page_dor); }int main (int argc,char **argv)
Signature · 1 line
2.54.0
Re: [PATCH 3/4] tests/qtest: aspeed_smc: Add Dual Output Read (DOR) test coverage
Quoted 17 lines · Cédric Le Goater
Add
read_page_mem_dor(CTRL_FREADMODEwith DOR command and dual data IO mode) andwrite_page_dor(user-mode DOR) tests.Signed-off-by Cédric Le Goater <[email protected]>--- tests/qtest/aspeed-smc-utils.h | 4 +++ tests/qtest/aspeed-smc-utils.c | 50 ++++++++++++++++++++++++++++++++++ tests/qtest/aspeed_smc-test.c | 16 +++++++++++ tests/qtest/ast2700-smc-test.c | 4 +++ 4 files changed, 74 insertions(+)tests/qtest/aspeed-smc-utils.h +0
-0
tests/qtest/aspeed-smc-utils.h line 47
Quoted 4 lines
tests/qtest/aspeed-smc-utils.h +1
-0@@ -44,6 +44,7 @@#define CTRL_FREADMODE 0x1#define CTRL_WRITEMODE 0x2#define CTRL_USERMODE 0x3 +#define CTRL_IO_DUAL_DATA BIT(29)
This macro is already defined in aspeed-smc-utils.h:43
Quoted 131 lines
tests/qtest/aspeed-smc-utils.h +3
-0#define CTRL_DUMMY_LOW_SHIFT 6#define CTRL_DUMMY_HIGH_SHIFT 14#define SR_WEL BIT(1)@@ -58,6 +59,7 @@ enum {BULK_ERASE =0xc7 ,READ =0x03 ,FAST_READ =0x0b , +DOR =0x3b ,PP =0x02 ,WRSR =0x1 , WREN = 0x6,@@ -95,5 +97,7 @@ void aspeed_smc_test_write_block_protect_bottom_bit(const void *data);void aspeed_smc_test_write_page_qpi (const void *data);void aspeed_smc_test_read_page_mem_fast_read (const void *data);void aspeed_smc_test_write_page_fast_read (const void *data); +void aspeed_smc_test_read_page_mem_dor (const void *data); +void aspeed_smc_test_write_page_dor (const void *data);#endif /* TESTS_ASPEED_SMC_UTILS_H */ tests/qtest/aspeed-smc-utils.c +50
-0@@ -746,3 +746,53 @@ void aspeed_smc_test_write_page_fast_read(const void *data) {test_write_page (data, read_page_fast_read); } + +static void read_page_mem_dor (const AspeedSMCTestData *data, +uint32_t addr,uint32_t *page) +{ +uint32_t ctrl_reg =R_CTRL0 + data->cs *4 ; +uint32_t ctrl =spi_readl (data, ctrl_reg); +int i; + + ctrl &= ~(CTRL_USERMODE | (0xff <<16 ) | + (0x3 <<CTRL_DUMMY_LOW_SHIFT ) | + (0x1 <<CTRL_DUMMY_HIGH_SHIFT ) | +CTRL_IO_MODE_MASK ); + ctrl |=CTRL_FREADMODE | (DOR <<16 ) | + (1 <<CTRL_DUMMY_LOW_SHIFT ) | +CTRL_IO_DUAL_DATA ; +spi_writel (data, ctrl_reg, ctrl); + +for (i =0 ; i <FLASH_PAGE_SIZE /4 ; i++) { + page[i] =make_be32 (flash_readl (data, addr + i *4 )); + } +} + +void aspeed_smc_test_read_page_mem_dor (const void *data) +{ +test_read_page_mem (data, read_page_mem_dor); +} + +static void read_page_dor (const AspeedSMCTestData *data, +uint32_t addr,uint32_t *page) +{ +int i; + +spi_ctrl_start_user (data); + +flash_writeb (data,0 ,EN_4BYTE_ADDR ); +flash_writeb (data,0 ,DOR ); +flash_writel (data,0 ,make_be32 (addr)); +/* 1 dummy byte for standard SPI DOR */ +flash_writeb (data,0 ,0x00 ); + +for (i =0 ; i <FLASH_PAGE_SIZE /4 ; i++) { + page[i] =make_be32 (flash_readl (data,0 )); + } +spi_ctrl_stop_user (data); +} + +void aspeed_smc_test_write_page_dor (const void *data) +{ +test_write_page (data, read_page_dor); +}tests/qtest/aspeed_smc-test.c +16
-0@@ -72,6 +72,10 @@ static void test_palmetto_bmc(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_fast_read);qtest_add_data_func ("/ast2400/smc/write_page_fast_read" , data, aspeed_smc_test_write_page_fast_read); +qtest_add_data_func ("/ast2400/smc/read_page_mem_dor" , + data, aspeed_smc_test_read_page_mem_dor); +qtest_add_data_func ("/ast2400/smc/write_page_dor" , + data, aspeed_smc_test_write_page_dor);/* * Block protect tests must be run last because the block protect * state is not cleared by reset_memory() and silently prevents @@ -128,6 +132,10 @@ static void test_ast2500_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_fast_read);qtest_add_data_func ("/ast2500/smc/write_page_fast_read" , data, aspeed_smc_test_write_page_fast_read); +qtest_add_data_func ("/ast2500/smc/read_page_mem_dor" , + data, aspeed_smc_test_read_page_mem_dor); +qtest_add_data_func ("/ast2500/smc/write_page_dor" , + data, aspeed_smc_test_write_page_dor); }static void test_ast2600_evb (AspeedSMCTestData *data)@@ -175,6 +183,10 @@ static void test_ast2600_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_fast_read);qtest_add_data_func ("/ast2600/smc/write_page_fast_read" , data, aspeed_smc_test_write_page_fast_read); +qtest_add_data_func ("/ast2600/smc/read_page_mem_dor" , + data, aspeed_smc_test_read_page_mem_dor); +qtest_add_data_func ("/ast2600/smc/write_page_dor" , + data, aspeed_smc_test_write_page_dor); }static void test_ast1030_evb (AspeedSMCTestData *data)@@ -222,6 +234,10 @@ static void test_ast1030_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_fast_read);qtest_add_data_func ("/ast1030/smc/write_page_fast_read" , data, aspeed_smc_test_write_page_fast_read); +qtest_add_data_func ("/ast1030/smc/read_page_mem_dor" , + data, aspeed_smc_test_read_page_mem_dor); +qtest_add_data_func ("/ast1030/smc/write_page_dor" , + data, aspeed_smc_test_write_page_dor); }int main (int argc,char **argv)tests/qtest/ast2700-smc-test.c +0
-0@@ -56,6 +56,10 @@ static void test_ast2700_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_fast_read);
tests/qtest/ast2700-smc-test.c static void test_ast2700_evb(AspeedSMCTestData *data)
Quoted 10 lines
tests/qtest/ast2700-smc-test.c +4
-1qtest_add_data_func ("/ast2700/smc/write_page_fast_read" , data, aspeed_smc_test_write_page_fast_read); +qtest_add_data_func ("/ast2700/smc/read_page_mem_dor" , + data, aspeed_smc_test_read_page_mem_dor); +qtest_add_data_func ("/ast2700/smc/write_page_dor" , + data, aspeed_smc_test_write_page_dor); }int main (int argc,char **argv) --
Otherwise,
Re: [PATCH 3/4] tests/qtest: aspeed_smc: Add Dual Output Read (DOR) test coverage
Quoted 13 lines · Bin Meng
Quoted 12 lines · Cédric Le Goater
Add
read_page_mem_dor(CTRL_FREADMODEwith DOR command and dual data IO mode) andwrite_page_dor(user-mode DOR) tests.Signed-off-by Cédric Le Goater <[email protected]>--- tests/qtest/aspeed-smc-utils.h | 4 +++ tests/qtest/aspeed-smc-utils.c | 50 ++++++++++++++++++++++++++++++++++ tests/qtest/aspeed_smc-test.c | 16 +++++++++++ tests/qtest/ast2700-smc-test.c | 4 +++ 4 files changed, 74 insertions(+)
Quoted 11 lines
tests/qtest/aspeed-smc-utils.h line 47
Quoted 9 lines
tests/qtest/aspeed-smc-utils.h +1
-0@@ -44,6 +44,7 @@#define CTRL_FREADMODE 0x1#define CTRL_WRITEMODE 0x2#define CTRL_USERMODE 0x3 +#define CTRL_IO_DUAL_DATA BIT(29)This macro is already defined in aspeed-smc-utils.h:43
I am confused. I only see this CTRL_IO_DUAL_DATA define in hw/ssi/aspeed_smc.c.
Thanks,
C.
Re: [PATCH 3/4] tests/qtest: aspeed_smc: Add Dual Output Read (DOR) test coverage
Quoted 27 lines · Cédric Le Goater
Quoted 13 lines · Bin Meng
Quoted 12 lines · Cédric Le Goater
Add
read_page_mem_dor(CTRL_FREADMODEwith DOR command and dual data IO mode) andwrite_page_dor(user-mode DOR) tests.Signed-off-by Cédric Le Goater <[email protected]>--- tests/qtest/aspeed-smc-utils.h | 4 +++ tests/qtest/aspeed-smc-utils.c | 50 ++++++++++++++++++++++++++++++++++ tests/qtest/aspeed_smc-test.c | 16 +++++++++++ tests/qtest/ast2700-smc-test.c | 4 +++ 4 files changed, 74 insertions(+)Quoted 11 lines
tests/qtest/aspeed-smc-utils.h line 47
Quoted 9 lines
tests/qtest/aspeed-smc-utils.h +1
-0@@ -44,6 +44,7 @@#define CTRL_FREADMODE 0x1#define CTRL_WRITEMODE 0x2#define CTRL_USERMODE 0x3 +#define CTRL_IO_DUAL_DATA BIT(29)This macro is already defined in aspeed-smc-utils.h:43
Quoted 3 lines
I am confused. I only see this
CTRL_IO_DUAL_DATAdefine inhw/ssi/aspeed_smc.c.
Sorry, my fault. I had a local tree that modified some of these qtests before.
Regards,
Bin
PATCH 4/4 tests/qtest: aspeed_smc: Add Quad Output Read (QOR) test coverage
In reply to Cédric Le GoaterAdd read_page_mem_qor (CTRL_FREADMODE with QOR command and quad data IO mode) and write_page_qor (user-mode QOR) tests.
--- tests/qtest/aspeed-smc-utils.h | 4 +++ tests/qtest/aspeed-smc-utils.c | 50 ++++++++++++++++++++++++++++++++++ tests/qtest/aspeed_smc-test.c | 16 +++++++++++ tests/qtest/ast2700-smc-test.c | 4 +++ 4 files changed, 74 insertions(+)
tests/qtest/aspeed-smc-utils.h +4 -0
@@ -44,6 +44,7 @@#define CTRL_FREADMODE 0x1#define CTRL_WRITEMODE 0x2#define CTRL_USERMODE 0x3 +#define CTRL_IO_QUAD_DATA BIT(30)#define CTRL_IO_DUAL_DATA BIT(29)#define CTRL_DUMMY_LOW_SHIFT 6#define CTRL_DUMMY_HIGH_SHIFT 14
@@ -60,6 +61,7 @@ enum {READ =0x03 ,FAST_READ =0x0b ,DOR =0x3b , +QOR =0x6b ,PP =0x02 ,WRSR =0x1 , WREN = 0x6,
@@ -99,5 +101,7 @@ void aspeed_smc_test_read_page_mem_fast_read(const void *data);void aspeed_smc_test_write_page_fast_read (const void *data);void aspeed_smc_test_read_page_mem_dor (const void *data);void aspeed_smc_test_write_page_dor (const void *data); +void aspeed_smc_test_read_page_mem_qor (const void *data); +void aspeed_smc_test_write_page_qor (const void *data);#endif /* TESTS_ASPEED_SMC_UTILS_H */
tests/qtest/aspeed-smc-utils.c +50 -0
53 lines not on this page · raw message
tests/qtest/aspeed_smc-test.c +16 -0
@@ -76,6 +76,10 @@ static void test_palmetto_bmc(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_dor);qtest_add_data_func ("/ast2400/smc/write_page_dor" , data, aspeed_smc_test_write_page_dor); +qtest_add_data_func ("/ast2400/smc/read_page_mem_qor" , + data, aspeed_smc_test_read_page_mem_qor); +qtest_add_data_func ("/ast2400/smc/write_page_qor" , + data, aspeed_smc_test_write_page_qor);/* * Block protect tests must be run last because the block protect * state is not cleared by reset_memory() and silently prevents
@@ -136,6 +140,10 @@ static void test_ast2500_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_dor);qtest_add_data_func ("/ast2500/smc/write_page_dor" , data, aspeed_smc_test_write_page_dor); +qtest_add_data_func ("/ast2500/smc/read_page_mem_qor" , + data, aspeed_smc_test_read_page_mem_qor); +qtest_add_data_func ("/ast2500/smc/write_page_qor" , + data, aspeed_smc_test_write_page_qor); }static void test_ast2600_evb (AspeedSMCTestData *data)
@@ -187,6 +195,10 @@ static void test_ast2600_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_dor);qtest_add_data_func ("/ast2600/smc/write_page_dor" , data, aspeed_smc_test_write_page_dor); +qtest_add_data_func ("/ast2600/smc/read_page_mem_qor" , + data, aspeed_smc_test_read_page_mem_qor); +qtest_add_data_func ("/ast2600/smc/write_page_qor" , + data, aspeed_smc_test_write_page_qor); }static void test_ast1030_evb (AspeedSMCTestData *data)
@@ -238,6 +250,10 @@ static void test_ast1030_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_dor);qtest_add_data_func ("/ast1030/smc/write_page_dor" , data, aspeed_smc_test_write_page_dor); +qtest_add_data_func ("/ast1030/smc/read_page_mem_qor" , + data, aspeed_smc_test_read_page_mem_qor); +qtest_add_data_func ("/ast1030/smc/write_page_qor" , + data, aspeed_smc_test_write_page_qor); }int main (int argc,char **argv)
tests/qtest/ast2700-smc-test.c +4 -0
@@ -60,6 +60,10 @@ static void test_ast2700_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_dor);qtest_add_data_func ("/ast2700/smc/write_page_dor" , data, aspeed_smc_test_write_page_dor); +qtest_add_data_func ("/ast2700/smc/read_page_mem_qor" , + data, aspeed_smc_test_read_page_mem_qor); +qtest_add_data_func ("/ast2700/smc/write_page_qor" , + data, aspeed_smc_test_write_page_qor); }int main (int argc,char **argv)
Signature · 1 line
2.54.0
Re: [PATCH 4/4] tests/qtest: aspeed_smc: Add Quad Output Read (QOR) test coverage
Quoted 17 lines · Cédric Le Goater
Add
read_page_mem_qor(CTRL_FREADMODEwith QOR command and quad data IO mode) andwrite_page_qor(user-mode QOR) tests.Signed-off-by Cédric Le Goater <[email protected]>--- tests/qtest/aspeed-smc-utils.h | 4 +++ tests/qtest/aspeed-smc-utils.c | 50 ++++++++++++++++++++++++++++++++++ tests/qtest/aspeed_smc-test.c | 16 +++++++++++ tests/qtest/ast2700-smc-test.c | 4 +++ 4 files changed, 74 insertions(+)tests/qtest/aspeed-smc-utils.h +0
-0
tests/qtest/aspeed-smc-utils.h line 47
Quoted 4 lines
tests/qtest/aspeed-smc-utils.h +1
-0@@ -44,6 +44,7 @@#define CTRL_FREADMODE 0x1#define CTRL_WRITEMODE 0x2#define CTRL_USERMODE 0x3 +#define CTRL_IO_QUAD_DATA BIT(30)
Already defined in line 42.
Quoted 33 lines
tests/qtest/aspeed-smc-utils.h +3
-0#define CTRL_IO_DUAL_DATA BIT(29)#define CTRL_DUMMY_LOW_SHIFT 6#define CTRL_DUMMY_HIGH_SHIFT 14@@ -60,6 +61,7 @@ enum {READ =0x03 ,FAST_READ =0x0b ,DOR =0x3b , +QOR =0x6b ,PP =0x02 ,WRSR =0x1 , WREN = 0x6,@@ -99,5 +101,7 @@ void aspeed_smc_test_read_page_mem_fast_read(const void *data);void aspeed_smc_test_write_page_fast_read (const void *data);void aspeed_smc_test_read_page_mem_dor (const void *data);void aspeed_smc_test_write_page_dor (const void *data); +void aspeed_smc_test_read_page_mem_qor (const void *data); +void aspeed_smc_test_write_page_qor (const void *data);#endif /* TESTS_ASPEED_SMC_UTILS_H */ tests/qtest/aspeed-smc-utils.c +6
-0@@ -796,3 +796,53 @@ void aspeed_smc_test_write_page_dor(const void *data) {test_write_page (data, read_page_dor); } + +static void read_page_mem_qor (const AspeedSMCTestData *data, +uint32_t addr,uint32_t *page) +{ +uint32_t ctrl_reg =R_CTRL0 + data->cs *4 ; +uint32_t ctrl =spi_readl (data, ctrl_reg);
tests/qtest/aspeed-smc-utils.c void aspeed_smc_test_write_page_dor(const void *data) · line 814
Quoted 10 lines
tests/qtest/aspeed-smc-utils.c +10
-0+int i; + + ctrl &= ~(CTRL_USERMODE | (0xff <<16 ) | + (0x3 <<CTRL_DUMMY_LOW_SHIFT ) | + (0x1 <<CTRL_DUMMY_HIGH_SHIFT ) | +CTRL_IO_MODE_MASK ); + ctrl |=CTRL_FREADMODE | (QOR <<16 ) | + (1 <<CTRL_DUMMY_LOW_SHIFT ) | +CTRL_IO_QUAD_DATA ; +spi_writel (data, ctrl_reg, ctrl);
Just call spi_ctrl_set_fast_read()?
Quoted 88 lines
tests/qtest/aspeed-smc-utils.c +34
-0+ +for (i =0 ; i <FLASH_PAGE_SIZE /4 ; i++) { + page[i] =make_be32 (flash_readl (data, addr + i *4 )); + } +} + +void aspeed_smc_test_read_page_mem_qor (const void *data) +{ +test_read_page_mem (data, read_page_mem_qor); +} + +static void read_page_qor (const AspeedSMCTestData *data, +uint32_t addr,uint32_t *page) +{ +int i; + +spi_ctrl_start_user (data); + +flash_writeb (data,0 ,EN_4BYTE_ADDR ); +flash_writeb (data,0 ,QOR ); +flash_writel (data,0 ,make_be32 (addr)); +/* 1 dummy byte for standard SPI QOR */ +flash_writeb (data,0 ,0x00 ); + +for (i =0 ; i <FLASH_PAGE_SIZE /4 ; i++) { + page[i] =make_be32 (flash_readl (data,0 )); + } +spi_ctrl_stop_user (data); +} + +void aspeed_smc_test_write_page_qor (const void *data) +{ +test_write_page (data, read_page_qor); +}tests/qtest/aspeed_smc-test.c +16
-0@@ -76,6 +76,10 @@ static void test_palmetto_bmc(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_dor);qtest_add_data_func ("/ast2400/smc/write_page_dor" , data, aspeed_smc_test_write_page_dor); +qtest_add_data_func ("/ast2400/smc/read_page_mem_qor" , + data, aspeed_smc_test_read_page_mem_qor); +qtest_add_data_func ("/ast2400/smc/write_page_qor" , + data, aspeed_smc_test_write_page_qor);/* * Block protect tests must be run last because the block protect * state is not cleared by reset_memory() and silently prevents @@ -136,6 +140,10 @@ static void test_ast2500_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_dor);qtest_add_data_func ("/ast2500/smc/write_page_dor" , data, aspeed_smc_test_write_page_dor); +qtest_add_data_func ("/ast2500/smc/read_page_mem_qor" , + data, aspeed_smc_test_read_page_mem_qor); +qtest_add_data_func ("/ast2500/smc/write_page_qor" , + data, aspeed_smc_test_write_page_qor); }static void test_ast2600_evb (AspeedSMCTestData *data)@@ -187,6 +195,10 @@ static void test_ast2600_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_dor);qtest_add_data_func ("/ast2600/smc/write_page_dor" , data, aspeed_smc_test_write_page_dor); +qtest_add_data_func ("/ast2600/smc/read_page_mem_qor" , + data, aspeed_smc_test_read_page_mem_qor); +qtest_add_data_func ("/ast2600/smc/write_page_qor" , + data, aspeed_smc_test_write_page_qor); }static void test_ast1030_evb (AspeedSMCTestData *data)@@ -238,6 +250,10 @@ static void test_ast1030_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_dor);qtest_add_data_func ("/ast1030/smc/write_page_dor" , data, aspeed_smc_test_write_page_dor); +qtest_add_data_func ("/ast1030/smc/read_page_mem_qor" , + data, aspeed_smc_test_read_page_mem_qor); +qtest_add_data_func ("/ast1030/smc/write_page_qor" , + data, aspeed_smc_test_write_page_qor); }int main (int argc,char **argv)tests/qtest/ast2700-smc-test.c +0
-0@@ -60,6 +60,10 @@ static void test_ast2700_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_page_mem_dor);
tests/qtest/ast2700-smc-test.c static void test_ast2700_evb(AspeedSMCTestData *data)
Quoted 10 lines
tests/qtest/ast2700-smc-test.c +4
-1qtest_add_data_func ("/ast2700/smc/write_page_dor" , data, aspeed_smc_test_write_page_dor); +qtest_add_data_func ("/ast2700/smc/read_page_mem_qor" , + data, aspeed_smc_test_read_page_mem_qor); +qtest_add_data_func ("/ast2700/smc/write_page_qor" , + data, aspeed_smc_test_write_page_qor); }int main (int argc,char **argv) --
Regards,
Bin