iio: adc: ti-ads1015: modernize resource management and driver setup
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest11 patches 5 repliesIn review
- v510 patches 8 repliesSuperseded
- v48 patches 6 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 8 patches | 7 replies | Superseded | |
| v2 | 6 patches | 4 replies | Superseded | |
| v1 | 3 patches | 4 replies | Superseded |
Changes in v6 from the cover letter
- Added a patch to remove the unnecessary ads1015_set_power_state() helper.
- Incorporated review feedback into the existing patches, including the FIELD_PREP()/FIELD_GET() conversion.
Patches in v6 No applies recorded yet
Reviews trailers per patch
2 of 11 patches have a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko |
|---|---|
| 1/11 | |
| 2/11 | |
| 3/11 | |
| 4/11 | |
| 5/11 | |
| 6/11 | |
| 7/11 | R-b |
| 8/11 | |
| 9/11 | |
| 10/11 | |
| 11/11 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 00/11] iio: adc: ti-ads1015: modernize resource management and driver setup
This series modernizes the ti-ads1015 driver by updating its runtime PM handling, error handling, resource management, and register bitfield operations.
This series builds on top of Stepan Ionichev's devm error path fix [1] and:
- Replaces SET_RUNTIME_PM_OPS() with DEFINE_RUNTIME_DEV_PM_OPS().
- Sorts the driver headers alphabetically.
- Returns -ENODATA when match data is missing.
- Uses a local device pointer in probe.
- Converts suitable error paths to dev_err_probe().
- Drops unnecessary '< 0' error checks for functions returning 0 or an error.
- Converts mutex initialization to devm_mutex_init().
- Transitions runtime PM setup to devm_pm_runtime_set_active_enabled().
- Removes the unnecessary ads1015_set_power_state() helper and uses runtime PM helpers directly at the call sites.
- Inlines the redundant ads1015_set_conv_mode() helper.
- Replaces custom shift macros with FIELD_PREP()/FIELD_GET().
[1] https://lore.kernel.org/all/[email protected]/
---
Changes in v6:
- Added a patch to remove the unnecessary ads1015_set_power_state() helper.
- Incorporated review feedback into the existing patches, including the FIELD_PREP()/FIELD_GET() conversion.
Changes in v5:
https://lore.kernel.org/linux-iio/[email protected]/
Archit Anant (11):
iio: adc: ti-ads1015: use DEFINE_RUNTIME_DEV_PM_OPS()
iio: adc: ti-ads1015: Sort headers alphabetically
iio: adc: ti-ads1015: use local device pointer in probe
iio: adc: ti-ads1015: return -ENODATA when match data is missing
iio: adc: ti-ads1015: use dev_err_probe() for error handling
iio: adc: ti-ads1015: Remove ads1015_set_power_state()
iio: adc: ti-ads1015: drop unneeded < 0 error checks
iio: adc: ti-ads1015: use devm_mutex_init()
iio: adc: ti-ads1015: use managed runtime PM setup
iio: adc: ti-ads1015: inline ads1015_set_conv_mode()
iio: adc: ti-ads1015: Replace custom shift macros with FIELD_PREP/GET
drivers/iio/adc/ti-ads1015.c | 237 +++++++++++++++++------------------ 1 file changed, 115 insertions(+), 122 deletions(-)
Signature · 1 line
2.39.5