Skip to content

iio: adc: ti-ads1015: modernize resource management and driver setup

Archit Anant linux-iio lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest11 patches 5 repliesIn review
  2. v510 patches 8 repliesSuperseded
  3. v48 patches 6 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v38 patches7 repliesSuperseded
v26 patches4 repliesSuperseded
v13 patches4 repliesSuperseded

Changes in v6 from the cover letter

- Added a patch to remove the unnecessary ads1015_set_power_state() helper.
- Incorporated review feedback into the existing patches, including the FIELD_PREP()/FIELD_GET() conversion.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11iio: adc: ti-ads1015: use DEFINE_RUNTIME_DEV_PM_OPS()drivers/iio/adc/ti-ads1015.c+5 -70 replies
2/11iio: adc: ti-ads1015: Sort headers alphabeticallydrivers/iio/adc/ti-ads1015.c+8 -90 replies
3/11iio: adc: ti-ads1015: use local device pointer in probedrivers/iio/adc/ti-ads1015.c+10 -90 replies
4/11iio: adc: ti-ads1015: return -ENODATA when match data is missingdrivers/iio/adc/ti-ads1015.c+1 -10 replies
5/11iio: adc: ti-ads1015: use dev_err_probe() for error handlingdrivers/iio/adc/ti-ads1015.c+12 -160 replies
6/11iio: adc: ti-ads1015: Remove ads1015_set_power_state()drivers/iio/adc/ti-ads1015.c+24 -351 reply
7/11iio: adc: ti-ads1015: drop unneeded < 0 error checksdrivers/iio/adc/ti-ads1015.c+1 -11 reply
8/11iio: adc: ti-ads1015: use devm_mutex_init()drivers/iio/adc/ti-ads1015.c+3 -10 replies
9/11iio: adc: ti-ads1015: use managed runtime PM setupdrivers/iio/adc/ti-ads1015.c+1 -40 replies
10/11iio: adc: ti-ads1015: inline ads1015_set_conv_mode()drivers/iio/adc/ti-ads1015.c+17 -151 reply
11/11iio: adc: ti-ads1015: Replace custom shift macros with FIELD_PREP/GETdrivers/iio/adc/ti-ads1015.c+44 -352 replies

Reviews trailers per patch

2 of 11 patches have a Reviewed-by or Acked-by.

PatchAndy Shevchenko
1/11
2/11
3/11
4/11
5/11
6/11
7/11R-b
8/11
9/11
10/11
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/11] iio: adc: ti-ads1015: modernize resource management and driver setup

This series modernizes the ti-ads1015 driver by updating its runtime PM handling, error handling, resource management, and register bitfield operations.

This series builds on top of Stepan Ionichev's devm error path fix [1] and:

- Replaces SET_RUNTIME_PM_OPS() with DEFINE_RUNTIME_DEV_PM_OPS().
- Sorts the driver headers alphabetically.
- Returns -ENODATA when match data is missing.
- Uses a local device pointer in probe.
- Converts suitable error paths to dev_err_probe().
- Drops unnecessary '< 0' error checks for functions returning 0 or an error.
- Converts mutex initialization to devm_mutex_init().
- Transitions runtime PM setup to devm_pm_runtime_set_active_enabled().
- Removes the unnecessary ads1015_set_power_state() helper and uses runtime PM helpers directly at the call sites.
- Inlines the redundant ads1015_set_conv_mode() helper.
- Replaces custom shift macros with FIELD_PREP()/FIELD_GET().

[1] https://lore.kernel.org/all/[email protected]/

---

Changes in v6:
- Added a patch to remove the unnecessary ads1015_set_power_state() helper.
- Incorporated review feedback into the existing patches, including the FIELD_PREP()/FIELD_GET() conversion.

Changes in v5:
https://lore.kernel.org/linux-iio/[email protected]/

Archit Anant (11):
iio: adc: ti-ads1015: use DEFINE_RUNTIME_DEV_PM_OPS()
iio: adc: ti-ads1015: Sort headers alphabetically
iio: adc: ti-ads1015: use local device pointer in probe
iio: adc: ti-ads1015: return -ENODATA when match data is missing
iio: adc: ti-ads1015: use dev_err_probe() for error handling
iio: adc: ti-ads1015: Remove ads1015_set_power_state()
iio: adc: ti-ads1015: drop unneeded < 0 error checks
iio: adc: ti-ads1015: use devm_mutex_init()
iio: adc: ti-ads1015: use managed runtime PM setup
iio: adc: ti-ads1015: inline ads1015_set_conv_mode()
iio: adc: ti-ads1015: Replace custom shift macros with FIELD_PREP/GET

 drivers/iio/adc/ti-ads1015.c | 237 +++++++++++++++++------------------
 1 file changed, 115 insertions(+), 122 deletions(-)
Signature · 1 line
2.39.5