Skip to content

cpus: Improvements around BQL locking, improving docstring

Philippe Mathieu-Daudé kvm qemu-arm qemu-devel qemu-riscv 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16accel: Label outer / inner vCPU execution loopsaccel/dummy-cpus.c accel/hvf/hvf-accel-ops.c accel/kvm/kvm-accel-ops.c +9 more+15 -30 replies
2/16cpus: Improve qemu_cpu_kick_self() docstringinclude/system/cpus.h+9 -13 replies
3/16cpus: Rename cpu_stop_current() -> qemu_cpu_stop_self()hw/ppc/spapr_rtas.c include/system/cpus.h system/cpus.c +1 more+12 -60 replies
4/16cpus: Rename qemu_cpu_stop() to qemu_cpu_ack_stop_request()system/cpus.c+4 -30 replies
5/16cpus: Improve cpu_pause() docstringinclude/hw/core/cpu.h+5 -20 replies
6/16cpus: Improve cpu_exit() docstringinclude/hw/core/cpu.h+4 -31 reply
7/16cpus: Document process_queued_cpu_work*() runs on current vCPUinclude/hw/core/cpu.h include/system/cpus.h+5 -00 replies
8/16cpus: Slightly improve *run_on_cpu() docstringsinclude/hw/core/cpu.h+20 -162 replies
9/16accel/tcg: Use RUN_ON_CPU_NULL for tcg_commit() callbackssystem/physmem.c+2 -20 replies
10/16accel/kvm: Clarify use of @r variable in vcpu thread loopaccel/kvm/kvm-accel-ops.c+5 -40 replies
11/16accel/kvm: Consistently return CPU halt state from process_async_eventstarget/arm/kvm.c target/riscv/kvm/kvm-cpu.c+2 -24 replies
12/16target/arm/hvf: Move flush_cpu_state() into the inner vCPU looptarget/arm/hvf/hvf.c+2 -20 replies
13/16target/arm/hvf: Lock BQL outside of the vCPU inner execution looptarget/arm/hvf/hvf.c+8 -52 replies
14/16target/i386/hvf: Lock BQL outside of the vCPU inner execution looptarget/i386/hvf/hvf.c+11 -81 reply
15/16target/arm/powerctl: Move BQL assertions to async work contexttarget/arm/arm-powerctl.c+1 -80 replies
16/16target/arm/whpx: Fix argument order typo in memory access error messagetarget/arm/whpx/whpx-all.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/16] cpus: Improvements around BQL locking, improving docstring

Hi,

While working on the hybrid-accelerator, I had to debug issues with vCPU scheduling and BQL. This series contains patches I wrote mostly as note for myself to better understand what was going on. Please review carefully as I'm way out of my confort zone...

Thanks,

Phil.

Philippe Mathieu-Daudé (16):
accel: Label outer / inner vCPU execution loops
cpus: Improve qemu_cpu_kick_self() docstring
cpus: Rename cpu_stop_current() -> qemu_cpu_stop_self()
cpus: Rename qemu_cpu_stop() to qemu_cpu_ack_stop_request()
cpus: Improve cpu_pause() docstring
cpus: Improve cpu_exit() docstring
cpus: Document process_queued_cpu_work*() runs on current vCPU
cpus: Slightly improve *run_on_cpu() docstrings accel/tcg: Use RUN_ON_CPU_NULL for tcg_commit() callbacks accel/kvm: Clarify use of @r variable in vcpu thread loop accel/kvm: Consistently return CPU halt state from
process_async_events
target/arm/hvf: Move flush_cpu_state() into the inner vCPU loop target/arm/hvf: Lock BQL outside of the vCPU inner execution loop target/i386/hvf: Lock BQL outside of the vCPU inner execution loop target/arm/powerctl: Move BQL assertions to async work context target/arm/whpx: Fix argument order typo in memory access error
message

 include/hw/core/cpu.h             | 54 +++++++++++++++++++------------
 include/system/cpus.h             | 19 +++++++++--
 accel/dummy-cpus.c                |  1 +
 accel/hvf/hvf-accel-ops.c         |  1 +
 accel/kvm/kvm-accel-ops.c         | 10 +++---
 accel/kvm/kvm-all.c               |  1 +
 accel/mshv/mshv-all.c             |  2 ++
 accel/tcg/tcg-accel-ops-mttcg.c   |  1 +
 accel/whpx/whpx-accel-ops.c       |  1 +
 hw/ppc/spapr_rtas.c               |  2 +-
 system/cpus.c                     |  9 +++---
 system/physmem.c                  |  4 +--
 system/runstate.c                 |  6 ++--
 target/arm/arm-powerctl.c         |  9 +-----
 target/arm/hvf/hvf.c              | 16 +++++----
 target/arm/kvm.c                  |  2 +-
 target/arm/whpx/whpx-all.c        | 10 +++---
 target/i386/hvf/hvf.c             | 20 +++++++-----
 target/i386/nvmm/nvmm-accel-ops.c |  1 +
 target/i386/whpx/whpx-all.c       |  1 +
 target/riscv/kvm/kvm-cpu.c        |  2 +-
 21 files changed, 106 insertions(+), 66 deletions(-)
Signature · 1 line
2.53.0