cpus: Constify @cpu in SysemuCPUOps::has_work() handler
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest13 patches 23 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | target/avr: Constify CPUAVRState for some cpu_*() getterstarget/ | +3 | 1 reply | |
| 2/13 | target/i386: Constify CPU*State for cpu_*_interrupt() getterstarget/ target/ | +5 | 1 reply | |
| 3/13 | target/loongarch: Constify CPULoongArchState for various cpu_*() getterstarget/ target/ target/ | +5 | 1 reply | |
| 4/13 | target/mips: Constify CPUMIPSState for various cpu_*() getterstarget/ target/ | +6 | 1 reply | |
| 5/13 | target/s390x: Constify S390CPU for cpu_has_*() getterstarget/ target/ target/ | +18 | 3 replies | |
| 6/13 | target/riscv: Constify @iprio argument in riscv_cpu_pending_to_irq()target/ target/ | +2 | 1 reply | |
| 7/13 | target/riscv: Constify CPURISCVState for various cpu_*() getterstarget/ target/ | +10 | 1 reply | |
| 8/13 | target/sparc: Constify CPUSPARCState for various cpu_*() getterstarget/ | +6 | 1 reply | |
| 9/13 | cpus: Add const-qualified CPU environment accessorsinclude/ include/ | +17 | 6 replies | |
| 10/13 | target/riscv: Constify CPURISCVState for various cpu_*() getterstarget/ target/ | +10 | 1 reply | |
| 11/13 | target/hexagon: Constify CPUHexagonState in hexagon_thread_is_enabled()target/ target/ | +3 | 2 replies | |
| 12/13 | target/mips: Constify CPUMIPSState in mips_vpe_active()target/ | +2 | 1 reply | |
| 13/13 | cpus: Constify @cpu in SysemuCPUOps::has_work() handlerinclude/ target/ target/ +20 more | +33 | 3 replies |
Reviews trailers per patch
12 of 13 patches have a Reviewed-by or Acked-by.
| Patch | Ilya Leoshkevich | Marc-André Lureau | Brian Cain | Eric Farman | Richard Henderson |
|---|---|---|---|---|---|
| 1/13 | R-b | ||||
| 2/13 | R-b | ||||
| 3/13 | R-b | ||||
| 4/13 | R-b | ||||
| 5/13 | R-b | R-b | A-b | ||
| 6/13 | R-b | ||||
| 7/13 | R-b | ||||
| 8/13 | R-b | ||||
| 9/13 | R-b R-b | R-b | |||
| 10/13 | R-b | ||||
| 11/13 | R-b | R-b | |||
| 12/13 | R-b | ||||
| 13/13 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH 00/13] cpus: Constify @cpu in SysemuCPUOps::has_work() handler
- Patches 1-8 trivially add const qualifier for various cpu_is/has() getters
- Patch 9 adds const-qualified variants of cpu_env() and env_archcpu(). Not sure if this is a good idea so marked as RFC.
- Patches 10-12 complete the cpu_is/has() getters const conversion using the new env_archcpu_const() variant
- Patch 13 finally convert the SysemuCPUOps::has_work hook and all target implementations.
No functional change; purely const-correctness improvment to enforce has_work() callees don't mutate CPUState.
Build-tested.
Based-on: <[email protected]>
"Make halt-to-exec transition explicit and remove cpu_exec_halt"
Philippe Mathieu-Daudé (13):
target/avr: Constify CPUAVRState for some cpu_*() getters target/i386: Constify CPU*State for cpu_*_interrupt() getters target/loongarch: Constify CPULoongArchState for various cpu_*()
getters
target/mips: Constify CPUMIPSState for various cpu_*() getters target/s390x: Constify S390CPU for cpu_has_*() getters target/riscv: Constify @iprio argument in riscv_cpu_pending_to_irq() target/riscv: Constify CPURISCVState for various cpu_*() getters target/sparc: Constify CPUSPARCState for various cpu_*() getters
cpus: Add const-qualified CPU environment accessors target/riscv: Constify CPURISCVState for various cpu_*() getters target/hexagon: Constify CPUHexagonState in
hexagon_thread_is_enabled()
target/mips: Constify CPUMIPSState in mips_vpe_active()
cpus: Constify @cpu in SysemuCPUOps::has_work() handler
include/exec/cpu-common.h | 11 +++++++++++ include/hw/core/cpu.h | 6 ++++++ include/hw/core/sysemu-cpu-ops.h | 4 ++-- target/avr/cpu.h | 6 +++--- target/hexagon/cpu.h | 2 +- target/i386/cpu.h | 4 ++-- target/loongarch/cpu.h | 6 +++--- target/loongarch/internals.h | 4 ++-- target/mips/cpu.h | 6 +++--- target/mips/internal.h | 10 +++++----- target/riscv/cpu.h | 31 ++++++++++++++++--------------- target/riscv/internals.h | 2 +- target/s390x/cpu.h | 2 +- target/s390x/s390x-internal.h | 14 +++++++------- target/sparc/cpu.h | 12 ++++++------ target/alpha/cpu.c | 2 +- target/arm/cpu.c | 4 ++-- target/avr/cpu.c | 5 +++-- target/hexagon/cpu.c | 8 ++++---- target/hppa/cpu.c | 2 +- target/i386/cpu.c | 8 ++++---- target/loongarch/cpu.c | 6 +++--- target/m68k/cpu.c | 2 +- target/microblaze/cpu.c | 2 +- target/mips/cpu.c | 4 ++-- target/or1k/cpu.c | 2 +- target/ppc/cpu_init.c | 2 +- target/riscv/cpu.c | 14 +++++++------- target/rx/cpu.c | 2 +- target/s390x/cpu-system.c | 2 +- target/s390x/interrupt.c | 22 +++++++++++----------- target/sh4/cpu.c | 2 +- target/sparc/cpu.c | 4 ++-- target/tricore/cpu.c | 4 ++-- target/xtensa/cpu.c | 4 ++-- 35 files changed, 120 insertions(+), 101 deletions(-)
Signature · 1 line
2.53.0