Skip to content

Fix static analyser and compiler warnings in int3472

Sakari Ailus linux-acpi linux-media platform-driver-x86 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 7 repliesIn review
  2. v25 patches 18 repliesSuperseded
  3. v12 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- Drop the __free(ACPI_FREE) change.

- Move ACPI_FREE() earlier in the function and save the object's integer value into a local variable.

- Fix return values -- 0 was returned by v2 in some cases where 1 was the right value.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3platform/x86: int3472: Address Coccinelle warning on an error printdrivers/platform/x86/intel/int3472/tps68470.c+1 -12 replies
2/3platform/x86: int3472: Fix uninitialised variable warningdrivers/platform/x86/intel/int3472/discrete.c+14 -113 replies
3/3platform/x86: int3472: Clean up GPIO parsingdrivers/platform/x86/intel/int3472/discrete.c+18 -241 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchIlpo JärvinenRicardo RibaldaRafael J. Wysocki (Intel)Daniel Scally
SeriesA-b
1/3R-b R-b R-b
2/3R-b R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/3] Fix static analyser and compiler warnings in int3472

Hi folks,

The two first patches address smatch and compiler warnings in int3472. The third patch clean up GPIO parsing in the int3472 driver.

since v2:

- Drop the __free(ACPI_FREE) change.

- Move ACPI_FREE() earlier in the function and save the object's integer value into a local variable.

- Fix return values -- 0 was returned by v2 in some cases where 1 was the right value.

Sakari Ailus (3):
platform/x86: int3472: Address Coccinelle warning on an error print platform/x86: int3472: Fix uninitialised variable warning platform/x86: int3472: Clean up GPIO parsing

 drivers/platform/x86/intel/int3472/discrete.c | 51 +++++++++----------
 drivers/platform/x86/intel/int3472/tps68470.c |  2 +-
 2 files changed, 25 insertions(+), 28 deletions(-)

base-commit: 56c29fa3ee666197516a231e75aed789ae9c530d

Signature · 1 line
2.47.3