Skip to content

arm64: dts: qcom: Add HP OmniBook X 16-cp1

Jeff Roach linux-arm-msm linux-devicetree lkml 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 0 repliesNew
  2. v42 patches 0 repliesSuperseded
  3. v32 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v22 patches3 repliesSuperseded
v12 patches1 replySuperseded

Changes in v5 from the cover letter

- Drop the &gpu and &gmu "disabled" overrides, mahua.dtsi now describes the Mahua GPU (reported by Sashiko)
- Drop refgen-supply from usb_2_qmpphy and use the common l4f1. The ACPI tables vote both l1c1 and l4f1 for this port, so they don't decide it (reported by Sashiko)
- Drop the stale regulator sentence from the commit message
- Link to v4: https://lore.kernel.org/r/[email protected]

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: arm: qcom: Add HP OmniBook X 16-cp1Documentation/devicetree/bindings/arm/qcom.yaml+1 -00 replies
2/2arm64: dts: qcom: Add HP OmniBook X 16-cp1arch/arm64/boot/dts/qcom/Makefile arch/arm64/boot/dts/qcom/mahua-hp-omnibook-x16.dts+648 -00 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchKrzysztof Kozlowski
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] arm64: dts: qcom: Add HP OmniBook X 16-cp1

This adds a device tree for the HP OmniBook X 16-cp1 (board 8F46), a 16" laptop with the 12-core Snapdragon X2 Elite (Mahua).

Tested with Ubuntu's 7.3-based linux-qcom-x1e
kernel. Everything listed in patch 2 works there, including suspend (s2idle).

Notes:
- DisplayPort at HBR2 needs "phy: qualcomm: qmp-combo: update DP PHY PLL programming on Glymur" v6 [1] (tested with v5). Without it the stream runs at half rate and the monitor shows no picture. With it, about 1 in 4 plug-ins still gives no picture; replugging fixes it.
- The GPU is enabled as in mahua.dtsi. Tested with the msm driver patch from "drm/msm: Mahua GPU support" [2].
- Audio needs a topology and UCM config for the "HP-OmniBook-X16" model, which are not upstream yet. The headphone jack (SDCA) is not described.

This series was written with the help of an AI coding assistant (Claude): the device tree started from glymur-hp-elitebook-x-g2q.dts and the laptop's ACPI tables. I went through the regulators against the ACPI power votes for v3. I reviewed it and tested it on the laptop.

Earlier bring-up report: [3]

Changes in v5:
- Drop the &gpu and &gmu "disabled" overrides, mahua.dtsi now describes the Mahua GPU (reported by Sashiko)
- Drop refgen-supply from usb_2_qmpphy and use the common l4f1. The ACPI tables vote both l1c1 and l4f1 for this port, so they don't decide it (reported by Sashiko)
- Drop the stale regulator sentence from the commit message
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Rebase on qcom for-next: drop the PMIC includes, &apps_rsc, &tcsr, the SMB2370 repeaters and the phy supplies that mahua.dtsi and glymur-cob.dtsi now provide, and use the new regulator labels
- vreg_l2f0 is now 944 mV from the common file (was 936 mV); tested
- Keep refgen-supply = <&vreg_l1c1> on usb_2_qmpphy, which matches the ACPI power votes on this laptop
- Move the pcie4 endpoint under &pcie4_port0, since glymur.dtsi no longer has pcie4_port0_ep
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Set vreg_l1f_e1 to 904 mV (was 880 mV, copied from the EliteBook) to match the ACPI power votes on this laptop, rename it to vreg_l1f_e1_0p9 (Konrad)
- Add Acked-by to patch 1 (Krzysztof)
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Add static data-lanes to usb_2_qmpphy so the PHY uses USB3-only mode (reported by Sashiko)
- Drop the Assisted-by tag, describe the tool use in the changelog instead (Krzysztof)
- Link to v1: https://lore.kernel.org/r/[email protected]

[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://lore.kernel.org/all/CAAnD8Rb4ZZrHFWMJayabioB_8bOHh1mqZ5LCXZz0jTNGMA7UZQ@mail.gmail.com/

Jeff Roach (2):
dt-bindings: arm: qcom: Add HP OmniBook X 16-cp1
arm64: dts: qcom: Add HP OmniBook X 16-cp1

 .../devicetree/bindings/arm/qcom.yaml         |   1 +
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 .../boot/dts/qcom/mahua-hp-omnibook-x16.dts   | 647 ++++++++++++++++++
 3 files changed, 649 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/mahua-hp-omnibook-x16.dts

base-commit: 14825c9204bad7f4e0bd3a528cbf4a7e24e757d0

Signature · 1 line
2.55.0