Skip to content

Support for board Calao USB A9263

Tom Rix u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/4] Support for board Calao USB A9263
Quoted 8 lines · Thomas Petazzoni

Hello,

This patchset implements the support for the Calao USB A9263 board (patch 4). The first three patches are preliminary work, to convert the Atmel Dataflash SPI driver to the new C struct accessors introduced a few months ago for AT91 support in U-Boot.

Thanks,

This is only a mechanical review.
I tested this patch using MAKEALL arm
and by running the kernel's checkpatch.pl against these patches

There are many at91 errors
Here is a sample, about 10 boards are broken in the same way.

atmel_dataflash_spi.c: In function 'AT91F_SpiInit':
atmel_dataflash_spi.c:42: error: 'AT91_SPI0_BASE' undeclared (first use in this
function)
atmel_dataflash_spi.c:42: error: (Each undeclared identifier is reported only once atmel_dataflash_spi.c:42: error: for each function it appears in.) atmel_dataflash_spi.c: In function 'AT91F_SpiEnable':
atmel_dataflash_spi.c:100: error: 'AT91_SPI0_BASE' undeclared (first use in
this function)
atmel_dataflash_spi.c: In function 'AT91F_SpiWrite':
atmel_dataflash_spi.c:138: error: 'AT91_SPI0_BASE' undeclared (first use in
this function)

	make[1]: *** [.../build/drivers/spi/atmel_dataflash_spi.o] Error 1
	make: *** [.../build/drivers/spi/libspi.a] Error 2
	make: *** Waiting for unfinished jobs....

usb9263 does not build

usb9263.ERR
did not build.

Many kernel check patch errors and warnings.

Please resolve these and resubmit.

Tom

Read the cover letter in its thread