Skip to content

target-arm: Fix Neon shift instructions.

[email protected] qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 14 repliesIn review
  2. v11 patch 3 repliesApplied

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6target-arm: Fix rounding constant addition for Neon shift instructions.target-arm/neon_helper.c+137 -122 replies
2/6target-arm: fix Neon right shifts with shift amount == input width.target-arm/neon_helper.c+3 -32 replies
3/6target-arm: fix unsigned 64 bit right shifts.target-arm/neon_helper.c+1 -11 reply
4/6target-arm: fix saturated values for Neon right shifts.target-arm/neon_helper.c+6 -23 replies
5/6target-arm: fix Neon VQSHRN and VSHRN.target-arm/translate.c+2 -21 reply
6/6target-arm: fix decoding of Neon 64 bit shifts.target-arm/translate.c+28 -151 reply

Reviews trailers per patch

2 of 6 patches have a Reviewed-by or Acked-by.

PatchPeter Maydell
1/6
2/6
3/6R-b
4/6
5/6R-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions.

From: Christophe Lyon <[email protected]>

This patch series provides fixes such that ARM Neon instructions VRSHR, VRSRA, VQRSHRN, VQRSHRUN, VRSHRN, VQSHRN, VSHRN, VQSHRUN now pass all my tests.

I have reworked all these patches and I hope they are now easier to review.

Christophe Lyon (6):
target-arm: Fix rounding constant addition for Neon shift
instructions.
target-arm: fix Neon right shifts with shift amount == input width.
target-arm: fix unsigned 64 bit right shifts.
target-arm: fix saturated values for Neon right shifts.
target-arm: fix Neon VQSHRN and VSHRN.
target-arm: fix decoding of Neon 64 bit shifts.

 target-arm/neon_helper.c |  163 +++++++++++++++++++++++++++++++++++++++++-----
 target-arm/translate.c   |   47 +++++++++-----
 2 files changed, 176 insertions(+), 34 deletions(-)
Signature · 1 line
1.7.2.3