Skip to content

Migrate Tegra to common clock framework

Stephen Warren linux-arm-kernel linux-tegra lkml 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 6/60 of 9 patches 0 repliesNew
  2. v3 posting 5/60 of 9 patches 0 repliesSuperseded
  3. v3 posting 4/60 of 9 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v3 posting 3/60 of 9 patches0 repliesSuperseded
v3 posting 2/60 of 9 patches0 repliesSuperseded
v3 posting 1/60 of 9 patches0 repliesSuperseded

Patches in v3 posting 6/6 No applies recorded yet

None of the 9 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/9] Migrate Tegra to common clock framework
Quoted 3 lines · Marc Dietrich
Quoted 2 lines · On Friday 11 January 2013 13:40:03 Prashant Gaikwad wrote:
Quoted 1 line · Stephen Warren

On 01/09/2013 10:34 AM, Stephen Warren wrote:

...

Quoted 19 lines
Quoted 19 lines
Quoted 19 lines

Your changes don't actually cause the driver to break though, since it abuses clk_get_sys() to retrieve clocks under a different driver name, which matches what the clock driver provides. However, I think you should also include the following patch at the end of your series to fix this up, so the clock looking happens through device tree:

Quoted 13 lines
drivers/staging/nvec/nvec.c +1 -1
index d8826ed..6d44076 100644
@@ -770,7 +770,7 @@ static int tegra_nvec_probe(struct platform_device
 *pdev)>> 
                 return -ENODEV;
 
         }
 
-       i2c_clk = clk_get_sys("tegra-i2c.2", "div-clk");
+       i2c_clk = clk_get(&pdev->dev, "div-clk");
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines
         if (IS_ERR(i2c_clk)) {
         
                 dev_err(nvec->dev, "failed to get controller clock\n");
                 return -ENODEV;

Included in the latest patches sent.

em, not yet in V4.

It's in V2 of the other series Prashant posted which sits on top of the CCF rework series.

Quoted 2 lines

Maybe you can also adjust the TODO (2nd entry) file now that this issue is fixed.

I'll try to remember to repost an updated version of the patch which does that...

Read the cover letter in its thread