ARM: OMAP: OMAP5 & AM43x DSS
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 of 11 patches 0 repliesNew
3 of 11 patches are in this archive. The cover letter announces 11.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | ARM: AM43xx: hwmod: add DSS hwmod data | +0 | 1 reply | |
| 1/11 | ARM: AM43xx: hwmod: add DSS hwmod data | +0 | 2 replies | |
| 1/11 | ARM: AM43xx: hwmod: add DSS hwmod data | +0 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Rajendra Nayak |
|---|---|
| 1/11 | A-b |
| 1/11 | A-b |
| 1/11 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/11] ARM: OMAP: OMAP5 & AM43x DSS
Quoted 23 lines · Archit Taneja
Hi,
Quoted 11 lines · Tomi Valkeinen
Quoted 9 lines · Tony Lindgren
Quoted 8 lines
Quoted 3 lines
Also, I'm wondering why we still have .clk and .opt_clks entries in the hwmod data for am43xx and omap5 which are both device tree based with all the clocks coming from .dts files?
I think they are needed for the omap_device/hwmod stuff to work. Only omapdss driver knows about the clocks defined in the .dts files, and the omap_device/hwmod code still needs to do the reset and maybe some other tasks that require the clocks.
Quoted 8 lines
Quoted 5 lines
We're already populating the hwmod data from dts entries, that's done by
omap_device_build_from_dt. Why aren't we doing that for dt defined clocks?I'd rather not start adding new data that will then just be removed, that's what people call "pointless extra churn".
I don't know why. I have to say I'm not 100% sure if that's done or not, but at least I can't find where it's done.
Quoted 7 lines
The reason why clocks are needed from hwmod data is because we still don't populate hwmod fields like
main_clkandopt_clockfrom DT clocks.The reason why this isn't done yet is because we currently haven't figured out a clean way to tell hwmod what clock is the
main_clk, and what clocks are optional clocks.One of the proposed methods was to assume the clock named to be "fck" as
main_clk, and the remaining clocks as optional clocks for hwmod. That method wasn't agreed upon, this looks like the thread which discusses this:
So I started to look through this again and I realized most of the opt clock information
is actually unused within hwmod and does not even need to be there. I just proposed an RFC here to clean some of that [1]
The only modules which do need this seem to be gpio and dss (though we still need to check if all the newer platforms need this, or this is one of those things just carried forward because some old platform had an issue with gpio and dss ocp reset)
As far as DSS is concerned, this is used within the custom reset function (not within hwmod) in display.c in mach-omap2/ Its just that the current code relies on hwmod structures, which can very easily now extract this from DT instead.
That just leaves gpio, which should be the only clock information that will have to exist in hwmod till we figure out how to move it to DT. All the main_clks from hwmod can very easily to moved to DT as already proposed using something like 'fck' to identify them.
[1] http://marc.info/?l=linux-omap&m=140057445618162&w=2
Quoted 4 lines
Archit