Skip to content

drm/panel: ilitek-ili9805: convert to *_multi API

Michail Tatas dri-devel lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 2 repliesIn review
  2. v33 patches 3 repliesSuperseded
  3. v23 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch3 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/panel: ilitek-ili9805: Use _multi variantsdrivers/gpu/drm/panel/panel-ilitek-ili9805.c+13 -380 replies
2/3drm/panel: ilitek-ili9805: Use dsi_multi in initdrivers/gpu/drm/panel/panel-ilitek-ili9805.c+76 -850 replies
3/3drm/panel: ilitek-ili9805: make cleanup funcs voiddrivers/gpu/drm/panel/panel-ilitek-ili9805.c+2 -60 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchNeil ArmstrongDouglas Anderson
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] drm/panel: ilitek-ili9805: convert to *_multi API

This series converts panel-ilitek-ili9805 to the mipi_dsi_*_multi helpers and cleans up the resulting code.

Patch 1: Convert the individual DSI calls to their *_multi variants

Patch 2: Replace the ILI9805_INSTR table with per panel init functions using the *_multi API, dropping struct ili9805_instr

Patch 3: makes ili9805_power_off() and ili9805_deactivate() return void, since no one checks their return values.

Michail Tatas (3):
drm/panel: ilitek-ili9805: Use _multi variants drm/panel: ilitek-ili9805: Use dsi_multi in init drm/panel: ilitek-ili9805: make cleanup funcs void

 drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 212 ++++++++-----------
 1 file changed, 87 insertions(+), 125 deletions(-)
Signature · 28 lines
Changes in v4:
Addresses review feedback from Doug on v3
- Delete unused field name in struct ili9805_desc
- convert MIPI_DCS_SET_PIXEL_FORMAT
  from mipi_dsi_dcs_write_seq_multi()
  to mipi_dsi_dcs_set_pixel_format_multi()
 
Changes in v3:
Addresses review feedback from Doug on v2
- Convert hex to lowercase
- Align to match open parenthesis
- Change lines to not cross 100 chars

Changes in v2:
Addresses review feedback from Doug on v1
- Patch 1 remains the same as v1
- Added patch 2 dropping struct ili9805_instr and used
  per-panel init functions
- Added patch 3 making the cleanup functions return void

Revisions
- v1: https://lore.kernel.org/all/allWpYxgHfpKughy@michalis-linux/
- v2: https://lore.kernel.org/all/[email protected]/
- v3: https://lore.kernel.org/all/[email protected]/

The changes are compile tested only. Also I run checkpatch.pl --strict, 
sparse, smatch, gcc W=1, clang W=1 and coccinelle.
2.43.0