bridge: support sending rntl info when we set attributes through sysfs/ioctl
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest6 patches 8 repliesIn review
- v26 patches 3 repliesSuperseded
- v16 patches 15 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | bridge: simplify the flush_store by calling store_bridge_parmnet/ | +7 | 1 reply | |
| 2/6 | bridge: simplify the forward_delay_store by calling store_bridge_parmnet/ | +10 | 1 reply | |
| 3/6 | bridge: simplify the stp_state_store by calling store_bridge_parmnet/ | +9 | 1 reply | |
| 4/6 | bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_brnet/ net/ | +14 | 1 reply | |
| 5/6 | bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_ifnet/ | +3 | 1 reply | |
| 6/6 | bridge: a netlink notification should be sent when those attributes are changed by ioctlnet/ | +24 | 1 reply |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Nikolay Aleksandrov |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl
This patchset is used to support sending rntl info to user in some places, and ensure that whenever those attributes change internally or from sysfs, that a netlink notification is sent out to listeners.
It also make some adjustment in bridge sysfs so that we can implement this easily.
I've done some tests on this patchset, like:
[br_sysfs]
1. change all the attribute values of br or brif:
$ echo $value > /sys/class/net/br0/bridge/{*}
$ echo $value > /sys/class/net/br0/brif/eth1/{*}2. meanwhile, on another terminal to observe the msg:
$ bridge monitor
[br_ioctl]
1. in bridge-utils package, do some changes in br_set, let brctl command use ioctl to set attribute:
if ((ret = set_sysfs(path, value)) < 0) { -->
if (1) {$ brctl set*
2. meanwhile, on another terminal to observe the msg:
$ bridge monitor
This test covers all the attributes that brctl and sysfs support to set.
Xin Long (6):
bridge: simplify the flush_store by calling store_bridge_parm
bridge: simplify the forward_delay_store by calling store_bridge_parm
bridge: simplify the stp_state_store by calling store_bridge_parm
bridge: a netlink notification should be sent when those attributes
are changed by br_sysfs_br
bridge: a netlink notification should be sent when those attributes
are changed by br_sysfs_if
bridge: a netlink notification should be sent when those attributes
are changed by ioctl
net/bridge/br_ioctl.c | 40 ++++++++++++++--------- net/bridge/br_sysfs_br.c | 84 ++++++++++++++++++++---------------------------- net/bridge/br_sysfs_if.c | 5 +-- net/bridge/br_vlan.c | 30 +++-------------- 4 files changed, 66 insertions(+), 93 deletions(-)
Signature · 1 line
2.1.0