Skip to content

Fix -Wunused-but-set-variable in mwifiex/

Kirtika Ruchandani linux-wireless 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 2 repliesIn review
  2. v17 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Reapplied patches on top of wireless-drivers-next.
- Patch 5/7 ("mwifiex: Remove unused 'pm_flag' variable") had to be redone slightly. The others applied cleanly with 'patch -p1'.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7mwifiex: Removed unused mwifiex_private* 'priv' variabledrivers/net/wireless/marvell/mwifiex/main.c+0 -31 reply
2/7mwifiex: Remove unused 'chan_num' variabledrivers/net/wireless/marvell/mwifiex/scan.c+3 -50 replies
3/7mwifiex: Remove unused 'sta_ptr' variabledrivers/net/wireless/marvell/mwifiex/sta_cmd.c+0 -20 replies
4/7mwifiex: Remove unused 'adapter'variabledrivers/net/wireless/marvell/mwifiex/cfg80211.c+0 -20 replies
5/7mwifiex: Remove unused 'pm_flag' variabledrivers/net/wireless/marvell/mwifiex/sdio.c+0 -20 replies
6/7mwifiex: Removed unused 'pkt_type' variabledrivers/net/wireless/marvell/mwifiex/sdio.c+0 -30 replies
7/7mwifiex: Remove unused 'bcd_usb' variabledrivers/net/wireless/marvell/mwifiex/usb.c+1 -20 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchArnd BergmannAmitkumar Karwar
SeriesA-b A-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] Fix -Wunused-but-set-variable in mwifiex/

This patchset is part of the effort led by Arnd Bergmann to clean up warnings in the kernel. This and following patchsets will focus on "-Wunused-but-set-variable" as it among the noisier ones. These were found compiling with W=1.

---
Changes in v2:
- Reapplied patches on top of wireless-drivers-next.
- Patch 5/7 ("mwifiex: Remove unused 'pm_flag' variable") had to be redone slightly. The others applied cleanly with 'patch -p1'.

Kirtika Ruchandani (7):
mwifiex: Removed unused mwifiex_private* 'priv' variable
mwifiex: Remove unused 'chan_num' variable
mwifiex: Remove unused 'sta_ptr' variable
mwifiex: Remove unused 'adapter'variable
mwifiex: Remove unused 'pm_flag' variable
mwifiex: Removed unused 'pkt_type' variable
mwifiex: Remove unused 'bcd_usb' variable

 drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 --
 drivers/net/wireless/marvell/mwifiex/main.c     | 3 ---
 drivers/net/wireless/marvell/mwifiex/scan.c     | 8 +++-----
 drivers/net/wireless/marvell/mwifiex/sdio.c     | 5 -----
 drivers/net/wireless/marvell/mwifiex/sta_cmd.c  | 2 --
 drivers/net/wireless/marvell/mwifiex/usb.c      | 3 +--
 6 files changed, 4 insertions(+), 19 deletions(-)
Signature · 1 line
2.8.0.rc3.226.g39d4020