Skip to content

drm/i915/dp: link rate and lane count refactoring

Jani Nikula intel-gfx 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm/i915/dp: use known correct array size in rate_to_indexdrivers/gpu/drm/i915/intel_dp.c+6 -50 replies
2/11drm/i915/dp: return errors from rate_to_index()drivers/gpu/drm/i915/intel_dp.c+9 -40 replies
3/11drm/i915/dp: rename rate_to_index() to intel_dp_find_rate() and reusedrivers/gpu/drm/i915/intel_dp.c+14 -190 replies
4/11drm/i915/dp: cache source rates at initdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h+24 -140 replies
5/11drm/i915/dp: generate and cache sink rate array for all DP, not just eDP 1.4drivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_dp_link_training.c drivers/gpu/drm/i915/intel_drv.h+55 -280 replies
6/11drm/i915/dp: use the sink rates array for max sink ratesdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h+8 -220 replies
7/11drm/i915/dp: cache common rates with sink ratesdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h+40 -260 replies
8/11drm/i915/dp: fallback link rate seek doesn't need to use rate limitdrivers/gpu/drm/i915/intel_dp.c+6 -150 replies
9/11drm/i915/dp: don't call the link parameters sink parametersdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h+15 -160 replies
10/11drm/i915/dp: add functions for max common link rate and lane countdrivers/gpu/drm/i915/intel_dp.c+17 -120 replies
11/11drm/i915/mst: use max link not sink lane countdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_dp_mst.c drivers/gpu/drm/i915/intel_drv.h+4 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] drm/i915/dp: link rate and lane count refactoring

The link rate and lane count management has become quite convoluted. Clean it up. Calculate source/sink/common rates only once. Separate the max link rate and lane count from the source/sink max link rate and lane counts; the former are dynamic and depend on the link conditions, the latter are static properties of the source/sink devices. Reduce link bw code use, and prefer rate throughout.

There are two potential bug fixes in the series, but presumably they can only happen with the link fallback codes. Max sink rate usage was wrong for eDP 1.4. Max lane count was probably wrong for DP MST.

This probably conflicts royally with Manasi's work, but eventually this is where we should go. The current code just conflates and complicates too many things around link parameter management.

BR,
Jani.

Jani Nikula (11):
drm/i915/dp: use known correct array size in rate_to_index drm/i915/dp: return errors from rate_to_index() drm/i915/dp: rename rate_to_index() to intel_dp_find_rate() and reuse drm/i915/dp: cache source rates at init
drm/i915/dp: generate and cache sink rate array for all DP, not just

    eDP 1.4

drm/i915/dp: use the sink rates array for max sink rates drm/i915/dp: cache common rates with sink rates drm/i915/dp: fallback link rate seek doesn't need to use rate limit drm/i915/dp: don't call the link parameters sink parameters drm/i915/dp: add functions for max common link rate and lane count drm/i915/mst: use max link not sink lane count

 drivers/gpu/drm/i915/intel_dp.c               | 216 +++++++++++++++-----------
 drivers/gpu/drm/i915/intel_dp_link_training.c |   3 +-
 drivers/gpu/drm/i915/intel_dp_mst.c           |   4 +-
 drivers/gpu/drm/i915/intel_drv.h              |  19 ++-
 4 files changed, 138 insertions(+), 104 deletions(-)
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx