Skip to content

cpufreq: Add flag to auto-register as cooling device

Amit Kucheria linux-arm-kernel linux-mediatek linux-pm lkml 5 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest9 patches 11 repliesApplied
  2. v49 patches 13 repliesSuperseded
  3. v39 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v29 patches8 repliesSuperseded
v110 patches19 repliesSuperseded

Changes in v5 from the cover letter

- Added IS_ENABLED guards in cpufreq.c
- Changed flag name to CPUFREQ_IS_COOLING_DEV
- Collected various review tags

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/9thermal: cpu_cooling: Require thermal core to be compiled indrivers/cpufreq/Kconfig drivers/cpufreq/Kconfig.arm drivers/thermal/Kconfig+1 -81 reply
2/9cpufreq: Auto-register the driver as a thermal cooling device if askeddrivers/cpufreq/cpufreq.c include/linux/cpufreq.h+22 -011 replies
3/9cpufreq: qcom-hw: Register as a cpufreq cooling devicedrivers/cpufreq/qcom-cpufreq-hw.c+2 -10 replies
4/9cpufreq: imx6q: Use auto-registration of thermal cooling devicedrivers/cpufreq/imx6q-cpufreq.c+2 -220 replies
5/9cpufreq: cpufreq-dt: Use auto-registration of thermal cooling devicedrivers/cpufreq/cpufreq-dt.c+2 -120 replies
6/9cpufreq: mediatek: Use auto-registration of thermal cooling devicedrivers/cpufreq/mediatek-cpufreq.c+2 -121 reply
7/9cpufreq: qoriq: Use auto-registration of thermal cooling devicedrivers/cpufreq/qoriq-cpufreq.c+2 -130 replies
8/9cpufreq: scmi: Use auto-registration of thermal cooling devicedrivers/cpufreq/scmi-cpufreq.c+2 -120 replies
9/9cpufreq: scpi: Use auto-registration of thermal cooling devicedrivers/cpufreq/scpi-cpufreq.c+2 -120 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchViresh KumarMatthias KaehlckeStephen BoydDaniel LezcanoSudeep HollaMatthias Brugger
1/9A-b
2/9A-b A-b R-b T-b R-b T-b R-b
3/9A-b R-b T-b R-b R-b
4/9A-b R-b
5/9A-b R-b
6/9A-b R-b R-b
7/9A-b R-b
8/9A-b R-b A-b
9/9A-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/9] cpufreq: Add flag to auto-register as cooling device

Add a flag for cpufreq drivers to tell cpufreq core to auto-register themselves as a thermal cooling device.

There series converts over all the drivers except arm_big_little.c. Tested on SDM845 with the qcom-cpufreq-hw driver. Only compile-tested the others.

Things needing fixing (but not a blocker for the series):
- Look at how to detect that we're not in IKS mode in arm_big_little's .ready callback.

Changes since v4:
- Added IS_ENABLED guards in cpufreq.c
- Changed flag name to CPUFREQ_IS_COOLING_DEV
- Collected various review tags

Changes since v3:
- Got rid of wrapper function to register/unregister cooling devices. Directly call the function in cpufreq.c

Changes since v2:
- Get rid of #ifdef'ery and let the pointer exist in all cases
- Get rid of (!CPU_THERMAL || THERMAL) dependency in all cpufreq drivers' Kconfig

Changes since v1:
- Fix compilation failures with allmodconfig
- Get rid of #ifdef in cpufreq.c
- Removed miscellaneous patches and sent them separately
- Merged patches 1 and 2 from v1

Amit Kucheria (9):
thermal: cpu_cooling: Require thermal core to be compiled in
cpufreq: Auto-register the driver as a thermal cooling device if asked
cpufreq: qcom-hw: Register as a cpufreq cooling device
cpufreq: imx6q: Use auto-registration of thermal cooling device
cpufreq: cpufreq-dt: Use auto-registration of thermal cooling device
cpufreq: mediatek: Use auto-registration of thermal cooling device
cpufreq: qoriq: Use auto-registration of thermal cooling device
cpufreq: scmi: Use auto-registration of thermal cooling device
cpufreq: scpi: Use auto-registration of thermal cooling device

 drivers/cpufreq/Kconfig            |  3 ---
 drivers/cpufreq/Kconfig.arm        |  5 -----
 drivers/cpufreq/cpufreq-dt.c       | 14 ++------------
 drivers/cpufreq/cpufreq.c          | 13 +++++++++++++
 drivers/cpufreq/imx6q-cpufreq.c    | 24 ++----------------------
 drivers/cpufreq/mediatek-cpufreq.c | 14 ++------------
 drivers/cpufreq/qcom-cpufreq-hw.c  |  3 ++-
 drivers/cpufreq/qoriq-cpufreq.c    | 15 ++-------------
 drivers/cpufreq/scmi-cpufreq.c     | 14 ++------------
 drivers/cpufreq/scpi-cpufreq.c     | 14 ++------------
 drivers/thermal/Kconfig            |  1 +
 include/linux/cpufreq.h            |  9 +++++++++
 12 files changed, 37 insertions(+), 92 deletions(-)
Signature · 1 line
2.17.1