Skip to content

net: dev: BYPASS for lockless qdisc

Paolo Abeni netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesIn review
  2. v22 patches 3 repliesSuperseded
  3. v12 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- qdisc_is_empty() has a const argument (Eric)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: sched: add empty status flag for NOLOCK qdiscinclude/net/sch_generic.h net/sched/sch_generic.c+14 -02 replies
2/2net: dev: introduce support for sch BYPASS for lockless qdiscnet/core/dev.c+9 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchIvan VeceraEric Dumazet
1/2R-b R-b
2/2T-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/2] net: dev: BYPASS for lockless qdisc

This patch series is aimed at improving xmit performances of lockless qdisc in the uncontended scenario.

After the lockless refactor pfifo_fast can't leverage the BYPASS optimization. Due to retpolines the overhead for the avoidables enqueue and dequeue operations has increased and we see measurable regressions.

The first patch introduces the BYPASS code path for lockless qdisc, and the second one optimizes such path further. Overall this avoids up to 3 indirect calls per xmit packet. Detailed performance figures are reported in the 2nd patch.

v2 -> v3:
- qdisc_is_empty() has a const argument (Eric)

v1 -> v2:
- use really an 'empty' flag instead of 'not_empty', as suggested by Eric

Paolo Abeni (2):
net: sched: add empty status flag for NOLOCK qdisc
net: dev: introduce support for sch BYPASS for lockless qdisc

 include/net/sch_generic.h | 11 +++++++++++
 net/core/dev.c            |  9 +++++++++
 net/sched/sch_generic.c   |  3 +++
 3 files changed, 23 insertions(+)
Signature · 1 line
2.20.1