Skip to content

net/mlx5: use indirect call wrappers

Paolo Abeni netdev 3 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesApplied
  2. v23 patches 3 repliesSuperseded
  3. v13 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- do not add more INDIRECT_CALL_* macros
- use only the direct calls always available regardless of the mlx5 build options in the last patch

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2net/mlx5e: use indirect calls wrapper for skb allocationdrivers/net/ethernet/mellanox/mlx5/core/en_rx.c+17 -51 reply
2/2net/mlx5e: use indirect calls wrapper for the rx packet handlerdrivers/net/ethernet/mellanox/mlx5/core/en_rx.c+2 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSaeed Mahameed
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/2] net/mlx5: use indirect call wrappers

The mlx5_core driver uses several indirect calls in fast-path, some of them are invoked on each ingress packet, even for the XDP-only traffic.

This series leverage the indirect call wrappers infrastructure the avoid the expansive RETPOLINE overhead for 2 indirect calls in fast-path.

Each call is addressed on a different patch, plus we need to introduce a couple of additional helpers to cope with the higher number of possible direct-call alternatives.

v2 -> v3:
- do not add more INDIRECT_CALL_* macros
- use only the direct calls always available regardless of the mlx5 build options in the last patch

v1 -> v2:
- update the direct call list and use a macro to define it,
as per Saeed suggestion. An intermediated additional
macro is needed to allow arg list expansion
- patch 2/3 is unchanged, as the generated code looks better this way than with possible alternative (dropping BP hits)

Paolo Abeni (2):
net/mlx5e: use indirect calls wrapper for skb allocation net/mlx5e: use indirect calls wrapper for the rx packet handler

 .../net/ethernet/mellanox/mlx5/core/en_rx.c   | 25 ++++++++++++++-----
 1 file changed, 19 insertions(+), 6 deletions(-)
Signature · 1 line
2.20.1