Skip to content

net/mlx5: support for flow action on VLAN header

Moti Haimovsky dpdk-dev 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest7 patches 9 repliesIn review
  2. v47 patches 0 repliesSuperseded
  3. v37 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v27 patches0 repliesSuperseded
v17 patches28 repliesSuperseded

Changes in v5 from the cover letter

- Rebase on top of latest commits.
- Minor bug fix in vlan push action.
- Bug fix in the format of the release notes.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7net/mlx5: support for an action search in a listdrivers/net/mlx5/mlx5_flow.c drivers/net/mlx5/mlx5_flow.h+26 -01 reply
2/7net/mlx5: add VLAN push/pop DR commands to gluedrivers/net/mlx5/Makefile drivers/net/mlx5/meson.build drivers/net/mlx5/mlx5_glue.c +1 more+42 -01 reply
3/7net/mlx5: support pop flow action on VLAN headerdoc/guides/nics/mlx5.rst doc/guides/rel_notes/release_19_11.rst drivers/net/mlx5/mlx5.c +3 more+109 -11 reply
4/7net/mlx5: support push flow action on VLAN headerdoc/guides/nics/mlx5.rst doc/guides/rel_notes/release_19_11.rst drivers/net/mlx5/mlx5.h +2 more+295 -41 reply
5/7net/mlx5: support modify VLAN priority on VLAN hdrdoc/guides/nics/mlx5.rst doc/guides/rel_notes/release_19_11.rst drivers/net/mlx5/mlx5_flow_dv.c+67 -12 replies
6/7net/mlx5: supp modify VLAN ID on new VLAN headerdoc/guides/nics/mlx5.rst doc/guides/rel_notes/release_19_11.rst drivers/net/mlx5/mlx5_flow_dv.c+64 -10 replies
7/7net/mlx5: supp modify VLAN ID on existing VLAN hdrdoc/guides/nics/mlx5.rst drivers/net/mlx5/mlx5_flow.h drivers/net/mlx5/mlx5_flow_dv.c +1 more+92 -211 reply

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchViacheslav Ovsiienko
SeriesA-b
1/7A-b
2/7A-b
3/7A-b
4/7A-b
5/7A-b A-b
6/7
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [dpdk-dev] [PATCH v5 0/7] net/mlx5: support for flow action on VLAN header

VLAN actions support is implemented in librte_ethdev, and in test-pmd application, based on [1] Generic flow API. These actions conform to the VLAN actions defined in
[2] the OpenFlow Switch Specification.

rte_flow defines the following VLAN actions:
1. OF_POP_VLAN
Pop the outer-most VLAN header from the packet.
2. OF_PUSH_VLAN
Push a new VLAN header onto the packet.
3. OF_SET_VLAN_VID
Sets the ID of the outermost VLAN tag.
4. OF_SET_VLAN_PCP
Sets the 3-bit priority field of the outermost VLAN tag.

This series of patches adds support for those VLAN actions to the mlx5 PMD using the Direct Verbs interface.

v2:
- Code rebase on latest commits.

v3:
- mlx5 documentation update.

v4:
- Update the release notes with new the new features.
- Minor bug fixes.

v5:
- Rebase on top of latest commits.
- Minor bug fix in vlan push action.
- Bug fix in the format of the release notes.

Moti Haimovsky (7):
net/mlx5: support for an action search in a list net/mlx5: add VLAN push/pop DR commands to glue net/mlx5: support pop flow action on VLAN header net/mlx5: support push flow action on VLAN header net/mlx5: support modify VLAN priority on VLAN hdr net/mlx5: supp modify VLAN ID on new VLAN header net/mlx5: supp modify VLAN ID on existing VLAN hdr

 doc/guides/nics/mlx5.rst               |  34 ++-
 doc/guides/rel_notes/release_19_11.rst |   9 +
 drivers/net/mlx5/Makefile              |   5 +
 drivers/net/mlx5/meson.build           |   2 +
 drivers/net/mlx5/mlx5.c                |   9 +
 drivers/net/mlx5/mlx5.h                |   4 +
 drivers/net/mlx5/mlx5_flow.c           |  23 ++
 drivers/net/mlx5/mlx5_flow.h           |  27 +-
 drivers/net/mlx5/mlx5_flow_dv.c        | 538 +++++++++++++++++++++++++++++++++
 drivers/net/mlx5/mlx5_glue.c           |  29 ++
 drivers/net/mlx5/mlx5_glue.h           |   6 +
 drivers/net/mlx5/mlx5_prm.h            |   1 +
 12 files changed, 677 insertions(+), 10 deletions(-)
Signature · 1 line
1.8.3.1